From patchwork Wed Aug 5 16:13:08 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 27650 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5B47EC334B for ; Wed, 5 Aug 2026 16:14:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D2CBE68183; Wed, 5 Aug 2026 18:13:59 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Eh6QvPyM"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AFD6068161 for ; Wed, 5 Aug 2026 18:13:41 +0200 (CEST) Received: from [192.168.125.177] (mob-109-113-25-35.net.vodafone.it [109.113.25.35]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CD1123A1D; Wed, 5 Aug 2026 18:12:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1785946351; bh=6Obv0Wz/HJF7mOUnS6V31ONAzqtsTuCPOBefw8+/xCs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Eh6QvPyMkOnfIlnQqUolZyxt02MTqqPZufNLSQLm8GfylsNzuyLj7gpOaSU0LT9Ad W6++nsbMsUnxiBxyesDX1NBpzVxfteucWbEMWwU7SK1fBaMOLYXUdPg7bLNSuD0HvZ pu8Px1+g72hYNrfh1kMvTK90imQp5cNAfkNC8NPs= From: Jacopo Mondi Date: Wed, 05 Aug 2026 18:13:08 +0200 Subject: [PATCH v7 26/32] ipa: libipa: lsc: Document LscDescriptor::sensorSize usage MIME-Version: 1.0 Message-Id: <20260805-libipa-algorithms-v7-26-7425b5b795d4@ideasonboard.com> References: <20260805-libipa-algorithms-v7-0-7425b5b795d4@ideasonboard.com> In-Reply-To: <20260805-libipa-algorithms-v7-0-7425b5b795d4@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, Stefan Klug , Milan Zamazal Cc: Jacopo Mondi , Kieran Bingham X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=1079; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=6Obv0Wz/HJF7mOUnS6V31ONAzqtsTuCPOBefw8+/xCs=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqc2EiZ2qfeESd84cm3e4fP+NfLd3gg+QTUYBtE bfMqDSzEMKJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCanNhIgAKCRByNAaPFqFW PG2CEACqR8F1X6FLhSc/w/30KKxx/fmIDn9DA0KhpZVDCC2vb9wKgvhJx1GmWKA9Xm1KYbnG5OM HtvA33Nf7+J/owMzXiecZgpr77/8J338UUkNM0HQC2o9+OlROi+f0XKQRoTEhKVdWwY86cEU9hi PxenoiO6gMxx9YuVy1Rjm7/9qsU94tuizGmzwQjSig2o8JK4W7eS1uJagy1Nu8ujZN5jQK/segS LjobgJ+mpUzDlEw2cDhFZ1PfXh7l0okIOL6qC8HY0Ey2a8l0TfXeJO1VZLqSdEzHcwakA6Cy5ej rCvnOBVYgYoz9j4wtH6YUITgx3fEIGNV0OYipy7bTD+6j1tYWAOY1KarS5KIvvJeK6VQwPzD0ym ZWC9vlNZ+4/Rj2EU6fviPPNzXqCPFO1fSMjpP6hEtnVXYyrl3grTnuq+P4LrfWBOE5TY2J4JT2u Y0JY7xZDuHs33CbGIYSKbq88KgWnTN6AHGALkmnGGf9UTXNksifz8ko+F8pIm/nCXNg21atzM8+ XeBCxp8XzFnnqZYd2d2hsSfBqwQUkIRIVZ++Dly7OjU9SxVMMh+FsuaseH4Uwfoc6xOVpHX4cot uo9qi9p+jnuRGjTiECUNDnW6cyS2wb5jhksqxMMDqIn5Fts94aPSzemyHEbwMHQzjlMMQcX41ZQ RqeYQaQpkgKgOeQ== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Now that sensorSize_ has been removed from LscPolynomial and is passed to the Lsc algorithm through LscDescriptor document its intended purpose. Signed-off-by: Jacopo Mondi Reviewed-by: Stefan Klug Reviewed-by: Kieran Bingham --- src/ipa/libipa/lsc.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp index 2062b795991d..8c5c28077cce 100644 --- a/src/ipa/libipa/lsc.cpp +++ b/src/ipa/libipa/lsc.cpp @@ -179,6 +179,10 @@ namespace lsc { * k4: 0.0 * \endcode * + * The LSC polynomial definition is generated at tuning time in relation + * to the full sensor pixel array. This needs to be specified in + * LscDescriptor::sensorSize. + * * At LscAlgorithm::configure() time the LSC tables are re-sampled on the * sensor's crop rectangle in use to adapt them to the configuration in use for * a streaming session. Polynomial LSC tables support re-sampling and can be