From patchwork Wed Aug 5 16:13:07 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 27648 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 385C8C3349 for ; Wed, 5 Aug 2026 16:13:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B95D368176; Wed, 5 Aug 2026 18:13:58 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="gpXU2o7a"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 024146815D for ; Wed, 5 Aug 2026 18:13:41 +0200 (CEST) Received: from [192.168.125.177] (mob-109-113-25-35.net.vodafone.it [109.113.25.35]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 32CC03A1C; Wed, 5 Aug 2026 18:12:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1785946350; bh=M+fhDFMVeC56oP6o4RBljPBP/g+PMAsqSnprrwRtIGE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=gpXU2o7aUavh40D6VC91z5x08ekzih/zJ6LKuNZft4aH9qMAJZG/fk9ZMCy/JDUFK ZR/wd+tDBa03SOpJmxQSzuiAbujhYOxzMFjoNh5taJN/05zRZERstC3qUVNMKu4hr/ f2w16vvCudTZu4KwiYzqT2qvBLFzUr56zry3IHhU= From: Jacopo Mondi Date: Wed, 05 Aug 2026 18:13:07 +0200 Subject: [PATCH v7 25/32] ipa: libipa: lsc_polynomial: Remove sensorSize_ MIME-Version: 1.0 Message-Id: <20260805-libipa-algorithms-v7-25-7425b5b795d4@ideasonboard.com> References: <20260805-libipa-algorithms-v7-0-7425b5b795d4@ideasonboard.com> In-Reply-To: <20260805-libipa-algorithms-v7-0-7425b5b795d4@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, Stefan Klug , Milan Zamazal Cc: Jacopo Mondi , Kieran Bingham X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=3310; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=M+fhDFMVeC56oP6o4RBljPBP/g+PMAsqSnprrwRtIGE=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqc2EhLF0PSNsubEXvKKaAggussVkC7HraJm/Mu GA67W2uDJSJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCanNhIQAKCRByNAaPFqFW PFwJD/42edBnsf/JeLciDXrYV7PlgsJk6rMQpQAdDQyDCATBxj7uxNBoLpUdVE08cHcpxD5i037 eEG5G8V06coibazmQFwkAGh3Ae6TonG0Awp71eDujkzzwYTryZr//g+DMwIY2nVdr2moHGRMNH1 j0LgmUXoRapS4MIn0MJM/vy6ob0C3GgReDd8i6qyWcJlyvg0tJQ6I2Z8o0vzuEcVDkpdacF+tJU YXjnDr2W3zN+N9Wi6/SC6CzG3gC0EhVQR/m/hUJVvEIJnNWpzn8BP6WZTMcb/RZRViSfEVs2pEO n5bUC9Ksj62Jgb8qu98ToC9amG4qddK/iJ6wH1E4L8qtIL8gphnB7DRZnvfo3aO+vaImTqhI3DH 7xvAS8fgbSM/H5AHtX88l33cExhcsJg3tPQcHOJFZNvJPxRIkwMrJ9mulfDDhu4aqfRcWSnFZfb OlP8KrFOiB9/5r1PGhR8dHasymSfro4PUR/FaXGED8joFFwyznopWDbYSEY/yLmyD/1IRuI+gZ/ jYM9ggpECKzMu0DxpwiZtdRk/CBQ0n1rGgBbGqvlLaxoleZR4GLXpxUWNAvmY+6oCc2Y/MxSb+y vGRh5zWLAF7ihGcvKCBdB1L8WvmOD2U4o07r/GY8wB2lPRfcDNtGB1hLK4yZWI35ZuWSLMESZN9 VKPFg61aAmcx4rg== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The sensorSize_ field is only used during the init() function and is provided to LscPolynomial using the LscDescriptor type. There is no need to store it as a class member and to pass it in at class construction time. Remove it and move the \todo comment in the LscDescriptor type documentation. Signed-off-by: Jacopo Mondi Reviewed-by: Kieran Bingham Reviewed-by: Stefan Klug --- src/ipa/libipa/lsc.cpp | 6 +----- src/ipa/libipa/lsc_base.cpp | 3 +++ src/ipa/libipa/lsc_polynomial.cpp | 7 ------- src/ipa/libipa/lsc_polynomial.h | 6 ------ 4 files changed, 4 insertions(+), 18 deletions(-) diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp index 32626049a2e2..2062b795991d 100644 --- a/src/ipa/libipa/lsc.cpp +++ b/src/ipa/libipa/lsc.cpp @@ -215,11 +215,7 @@ int LscAlgorithm::init(const ValueNode &tuningData, ControlInfoMap::Map &control impl_ = std::make_unique(); LOG(Lsc, Debug) << "Using table-based Lsc"; } else if (type == "polynomial") { - /* - * \todo Most likely the reference frame should be native_size. - * Let's wait how the internal discussions progress. - */ - impl_ = std::make_unique(descriptor.sensorSize); + impl_ = std::make_unique(); polynomial_ = true; LOG(Lsc, Debug) << "Using polynomial Lsc"; } else { diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp index 289cb3da33f2..cb770f164d53 100644 --- a/src/ipa/libipa/lsc_base.cpp +++ b/src/ipa/libipa/lsc_base.cpp @@ -78,6 +78,9 @@ void Interpolator:: * \var LscDescriptor::sensorSize * \brief The physical sensor size. This is the largest frame size used to * generate the LSC table. Only used by the polynomial LSC algorithm + * + * \todo: Most likely the reference frame should be native_size. + * Let's wait how the internal discussions progress. */ /** diff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp index c3871eb3295c..0eb017de6b50 100644 --- a/src/ipa/libipa/lsc_polynomial.cpp +++ b/src/ipa/libipa/lsc_polynomial.cpp @@ -123,13 +123,6 @@ void Polynomial::setReferenceImageSize(const Size &size) * \sa LscImplementation */ -/** - * \fn LscPolynomial::LscPolynomial - * \param[in] sensorSize The physical sensor size - * - * Construct an LscPolynomial - */ - /** * \brief Parse polynomial LSC data * \param[in] sets The tuning file content diff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h index 4c6af2d4900d..548ed94b2461 100644 --- a/src/ipa/libipa/lsc_polynomial.h +++ b/src/ipa/libipa/lsc_polynomial.h @@ -57,11 +57,6 @@ private: using PolynomialComponentsMap = std::map; public: - LscPolynomial(const Size &sensorSize) - : sensorSize_(sensorSize) - { - } - int parseLscData(const ValueNode &sets, const LscDescriptor &descriptor) override; @@ -75,7 +70,6 @@ private: Span yPositions, const Rectangle &cropRectangle); PolynomialComponentsMap lscData_; - Size sensorSize_; }; } /* namespace ipa */