From patchwork Wed Aug 5 16:12:56 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 27637 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 45772C3340 for ; Wed, 5 Aug 2026 16:13:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CF34C68148; Wed, 5 Aug 2026 18:13:46 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="p8fwBCvM"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AF02868131 for ; Wed, 5 Aug 2026 18:13:33 +0200 (CEST) Received: from [192.168.125.177] (mob-109-113-25-35.net.vodafone.it [109.113.25.35]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D6C2339AA; Wed, 5 Aug 2026 18:12:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1785946343; bh=+BLekKS2khj7QSEHhQsHfSrQMgwm055rzcXMP/0cFSk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=p8fwBCvMTms+97fQ4ei/HqAZZfmCpzb44KRFukY9TjDr3H1yNG1A/zxpkZW9ctrXC Dm4kjoQG7swvLkDWe1nvU1Gxb9vklPaVEuIgftSLVUcBF59DvZp+86zRDzAfpt0OEa HjumqInVnGgEqfeih5cNs+7+dfsOS87kPmC3NsOw= From: Jacopo Mondi Date: Wed, 05 Aug 2026 18:12:56 +0200 Subject: [PATCH v7 14/32] ipa: libipa: lsc_polynomial: Do not inline functions MIME-Version: 1.0 Message-Id: <20260805-libipa-algorithms-v7-14-7425b5b795d4@ideasonboard.com> References: <20260805-libipa-algorithms-v7-0-7425b5b795d4@ideasonboard.com> In-Reply-To: <20260805-libipa-algorithms-v7-0-7425b5b795d4@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, Stefan Klug , Milan Zamazal Cc: Jacopo Mondi , Kieran Bingham X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=4087; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=+BLekKS2khj7QSEHhQsHfSrQMgwm055rzcXMP/0cFSk=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqc2Edvqe9kapT6BzUoVl8SAbfXSPDB0eKBmDD6 SI+7ideX6GJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCanNhHQAKCRByNAaPFqFW PKCrD/9jpR8CYPdWMjN30pO43lDur4X82n/rADY5zF2U+lUjloOZIvnvZS7N9XiP+WKN5n4XYvN jAAUM48RMlJU5Wmkk0lM+o8YSdTm+8cCHiO1YK0rXlhVb4XgPJl73yAnvT06I/hfquPleqGmYoz /yGd3fAdnDfVx4SgkopC7nxrLH+C9C+5Rh1U8TDTxZiPpGOaqyBsI1zzCHLXDExWPgk/9dCgbqP hU70kYLHbjqxW8ISHZjCQpY032hrt2U8tb01/yx45ZCnh6v4Njsp35bD+8gilYd4AXpa9c3PtdS 95sklilyQGSqgRSQL4bZWJ6rytBZOMvU0+cKOpxNVcNkiPLEds/kbl8Wz8PPmBhUOjxZE4n5rZD QGrzDp2YWmyqsGlWNa+IMMUTFSIe3a0Z4tEECHFpbkjkFBRbEhdAYd6tFAov+2hk/CdGCtX3RGX JbKL6EiVQdMc5Ks2Vf/SWtZlZiXAE/4wuW4l+TjF6ZV87/TssLP2B27wLVE8NCJkuKagn2QmJnU BFNEzhfuWjBYChcgkJuySHsEAmYXOyoXclKjGmH2+ZRifTeBbGlKNLQUdPLS5eTyHFSHn76Dx5Q eAAl8tgi4zOEASdP53V48tKbab8PD70W+MtKXnlqzi1ZrfdQDc9nc3hKAdBA7nMQSxxIwB3bti1 HxV8I+lqqTEQjRQ== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" There is no reason to inline the Polynomial class implementation. Move functions implementation to the corresponding .cpp file. While at it remove a rougue empty line between class members definitions. Signed-off-by: Jacopo Mondi Reviewed-by: Kieran Bingham Reviewed-by: Stefan Klug --- src/ipa/libipa/lsc_polynomial.cpp | 34 +++++++++++++++++++++++++++++++--- src/ipa/libipa/lsc_polynomial.h | 36 +++--------------------------------- 2 files changed, 34 insertions(+), 36 deletions(-) diff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp index b93063bf8bc7..fb6f959e5a09 100644 --- a/src/ipa/libipa/lsc_polynomial.cpp +++ b/src/ipa/libipa/lsc_polynomial.cpp @@ -47,7 +47,6 @@ namespace lsc { */ /** - * \fn Polynomial::sampleAtNormalizedPixelPos(double x, double y) * \brief Sample the polynomial at the given normalized pixel position * * This functions samples the polynomial at the given pixel position divided by @@ -57,9 +56,20 @@ namespace lsc { * \param y y position in normalized coordinates * \return The sampled value */ +double Polynomial::sampleAtNormalizedPixelPos(double x, double y) const +{ + double dx = x - cnx_; + double dy = y - cny_; + double r = sqrt(dx * dx + dy * dy); + double res = 1.0; + + for (unsigned int i = 0; i < coefficients_.size(); i++) + res += coefficients_[i] * std::pow(r, (i + 1) * 2); + + return res; +} /** - * \fn Polynomial::getM() * \brief Get the value m as described in the dng specification * * Returns m according to dng spec. m represents the Euclidean distance @@ -68,9 +78,17 @@ namespace lsc { * * \return The sampled value */ +double Polynomial::getM() const +{ + double cpx = imageSize_.width * cx_; + double cpy = imageSize_.height * cy_; + double mx = std::max(cpx, std::fabs(imageSize_.width - cpx)); + double my = std::max(cpy, std::fabs(imageSize_.height - cpy)); + + return sqrt(mx * mx + my * my); +} /** - * \fn Polynomial::setReferenceImageSize(const Size &size) * \brief Set the reference image size * * Set the reference image size that is used for subsequent calls to getM() and @@ -78,6 +96,16 @@ namespace lsc { * * \param size The size of the reference image */ +void Polynomial::setReferenceImageSize(const Size &size) +{ + assert(!size.isNull()); + imageSize_ = size; + + /* Calculate normalized centers */ + double m = getM(); + cnx_ = (size.width * cx_) / m; + cny_ = (size.height * cy_) / m; +} } /* namespace lsc */ diff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h index 3be33edfe7d8..2caf46d2d759 100644 --- a/src/ipa/libipa/lsc_polynomial.h +++ b/src/ipa/libipa/lsc_polynomial.h @@ -37,38 +37,9 @@ public: { } - double sampleAtNormalizedPixelPos(double x, double y) const - { - double dx = x - cnx_; - double dy = y - cny_; - double r = sqrt(dx * dx + dy * dy); - double res = 1.0; - for (unsigned int i = 0; i < coefficients_.size(); i++) { - res += coefficients_[i] * std::pow(r, (i + 1) * 2); - } - return res; - } - - double getM() const - { - double cpx = imageSize_.width * cx_; - double cpy = imageSize_.height * cy_; - double mx = std::max(cpx, std::fabs(imageSize_.width - cpx)); - double my = std::max(cpy, std::fabs(imageSize_.height - cpy)); - - return sqrt(mx * mx + my * my); - } - - void setReferenceImageSize(const Size &size) - { - assert(!size.isNull()); - imageSize_ = size; - - /* Calculate normalized centers */ - double m = getM(); - cnx_ = (size.width * cx_) / m; - cny_ = (size.height * cy_) / m; - } + double sampleAtNormalizedPixelPos(double x, double y) const; + double getM() const; + void setReferenceImageSize(const Size &size); private: double cx_; @@ -76,7 +47,6 @@ private: double cnx_; double cny_; std::array coefficients_; - Size imageSize_; };