From patchwork Tue Jul 28 17:24:44 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 27515 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 98F8BC328C for ; Tue, 28 Jul 2026 17:24:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AA1F167FAE; Tue, 28 Jul 2026 19:24:58 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="nthyymWC"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Y7Vf+6lW"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E066E67FAA for ; Tue, 28 Jul 2026 19:24:54 +0200 (CEST) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66SGJclv3328206 for ; Tue, 28 Jul 2026 17:24:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gV2YFhczcfA5MBc/tyL/MUyntQa4LIYH+mF84W7QfZM=; b=nthyymWCC2N9/KRM 7E5ypxqY1Y32WgV7ycjQgGl8GiiEpGhgNxHsLh1zDcWV06aqXDeJTnebfWzX9EXb 64sndQzjVrCuI+XOJOGJuwOhru1a10xtNXKqpMd6EMksclSThHGXYKuC1NLfS0Kl L+l43gFmmirEUucaiD0nPV/OB6Ts42UirP6wq4U5ECwfthCUEMzVFdajmDXhZPOd x1EnbPdlXUKgSs9HMV6MFPvZnUCcp1vVUiHPSdQ7Z42uDe9xOO3qV2LFH0b7Xt7V AMCU8vh+BEO6XMLwxH3hiKPogO5R9BknUr9GQzQ378IQrPKY1XcSCEAykAdrpSww US9elQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fpyukrach-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Jul 2026 17:24:53 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c21c01cf3so1269301cf.2 for ; Tue, 28 Jul 2026 10:24:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785259493; x=1785864293; darn=lists.libcamera.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gV2YFhczcfA5MBc/tyL/MUyntQa4LIYH+mF84W7QfZM=; b=Y7Vf+6lWwTBsthP2nA/qeUk+JiOV1HfDCVkdSbHpLiXyxCORKQ4QQCdxwqHDBZtErL KK1uj77eJQimPxwIzOiWsLJHrsZwdEEH8KWH7uSgsZn3ezHDNHOBpJS7KkSMM2BBOLzQ /hyupOgDTtMT/08J158DbEdGF9AGZXzVmuIrnkHOr/GNCcQnOL2FJCBcGb4rSL8D7NSD R+Q7W71na+YuEoOwARJ+pQRZWM7AUB4sAL0+b3Ux55twCEgvL0eLrAFk/xDp9UJS+1KF cBt0etTvqDy329N05LPwU8tSNdTo1XSFit6+mQt1K2QU6bNyzJUCGPMQm4v1USzSvb9V 797w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785259493; x=1785864293; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gV2YFhczcfA5MBc/tyL/MUyntQa4LIYH+mF84W7QfZM=; b=YPvLhes5wAJV5a9j35WLMH70IRb8BcTWiXSIHDzaijbTRdUWk/LxMgrfBquXogLc1g +5ILkeBrvNnHIs5PwwU5h1Y8N9Fr8wZ9ufvXG9s8+ZbNTxZmC10HtSY7Js3fwwJeJ68S on0zqrFURDv5tfntS2psySVLxCFyASSKI/fdYYgkSgeekbyUBkWp9N0SIpm2oalBPD3v 9wlRJlHVF2CcDjsCBGFxMQsMJSHnvrI+5zulzrHkby/5jLJbWbS8F+YPgYsl1O1IjfQC Y7rWWF2gOlRvx8qO632YAehU8O5NAYJMit4dHCnN1pAkRFPN2Xd2Cm+xK+b2NCaTIEud yoZg== X-Gm-Message-State: AOJu0Yx7merZov28+DDu2q82Aj0GvixPSfArW2nyJtKRRGH9MPH7lFGS cme6P5lhQtJLYt8g3WLgrX3mOnYprghN7pvB3wpyqn9zQQaOOV8qCQlpoImzRzCeNl5q4LoCgVB dVOs0ZR4kxwQ2oZxAQNOMBG/PBLvdg/aYPTv5cg9Y3qWgMP2eOwiGe8Ary58//6gxIvZsw9KgQ8 huhHIYJBtH X-Gm-Gg: AR+sD13eEem9b7f4RoCAZ6VRieW5q0BGiqNrtHhs5vacHG+cf9l3Le7s4dUj+xVsbe6 rFVcYfxfwZlmggn8sZBtRRWrp0bg7SMDtTOufU+1jR6zT7XDKdYbPfh5m1AqLDzpsSRjV1y2Uax P245SwW5+7hCEmkDS09fWepva4E68Q+6hTFJhWMV6ejJBh1VGqPOBufAI42SUml/wjKjbDhe2xM 5WcBnkQI1RoasXgyp1AiAWRGGPwVsscu9TgTBDi5hcBGXRf62PfzovuTzXsDf92ZBln5O86cH+h Y6j2C7qSS7+/vWJNR5kpY1yV4uunn2PaW7onWE/nIseZXEtDdqWuG/oSyykRBoQvR5HaOu0yciR NmzTidCRmWE6kqcDq8Orsh6V6F3bycsOuzo2Ba8M+4fsgR7bttkXomhAY9MP5ULoBnaVQhzRP/R pnA2w5QA1lwno= X-Received: by 2002:ac8:7d91:0:b0:51c:7b12:120b with SMTP id d75a77b69052e-529d7204039mr32536791cf.73.1785259492426; Tue, 28 Jul 2026 10:24:52 -0700 (PDT) X-Received: by 2002:ac8:7d91:0:b0:51c:7b12:120b with SMTP id d75a77b69052e-529d7204039mr32536361cf.73.1785259491845; Tue, 28 Jul 2026 10:24:51 -0700 (PDT) Received: from t14s (2001-1c00-0c32-7800-07d4-cca3-ec08-7ac7.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:7d4:cca3:ec08:7ac7]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1f83fabcdasm11136466b.48.2026.07.28.10.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 10:24:50 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , =?utf-8?q?Niklas_S=C3=B6?= =?utf-8?q?derlund?= , Loic Poulain , Hans de Goede , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , Kieran Bingham Subject: [PATCH v6 2/5] ipa: ipa_module: Remove pipelineName Date: Tue, 28 Jul 2026 19:24:44 +0200 Message-ID: <20260728172447.68551-3-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260728172447.68551-1-johannes.goede@oss.qualcomm.com> References: <20260728172447.68551-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Authority-Analysis: v=2.4 cv=O/kJeh9W c=1 sm=1 tr=0 ts=6a68e5e5 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=lvZftHTMWe99GEGio_gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-GUID: QwvTRXSwLHRq39sZv6DXVYls5EfL0iR- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI4MDE1MyBTYWx0ZWRfXzhenU0PRZwC1 w/2qlQ0BADDFiZtfyFryiZb1qIx3GADgAjTOpF8bakQvo53va6tCdqejQzfg10UvOfrpttZ3UDU JGV1uHUfQI38nyxuB+BcVjo8WW1ONedsoqw3QJ2wkvr5oXT+qydT+uFSlUE3jl1ep7P+/cyJWXg UFhtedcKDueeXan2dKVGYSR3EBx7WAsvI0F3+qz34muZg//d09pPXWYweHnoD4EDhgPEl7R7fNa KGqyvSJJX9B2YDWkouFWHVw3Lua9L9rpJ/ZiS7DTYrM6+ybpvdKfG9+IRnSUtZTiM8JgZPVuavL YtcFbpm1gDXzS+G9kX1E7CO0Vta4k/yfL8+unyFEAIQrfywQD44pZH3JtoP0Emh03sOOtj+XuyH P9YBiL4Qsx1NGy09kgYHUSKu/vJgJyf63JmzbpCNgluVlUI0Uw6gIe6d8ycovr688HaGaYHDLBZ d8lPUgdukwXH5fwzzlg== X-Proofpoint-ORIG-GUID: QwvTRXSwLHRq39sZv6DXVYls5EfL0iR- X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI4MDE1MyBTYWx0ZWRfX/zGxDvSX2kcU Ihsj76C73Wb1pI0AigMf17CZ81UJCK65azn1BqG7ySpa8+jlK+2g7FR/DqQlmyoG5/rEYKvEBq9 q8FtU08+FZnlMVgJu3UVb3zA1NTQjig= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.134, FMLib:17.12.100.49 definitions=2026-07-28_04,2026-07-28_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607280153 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Jacopo Mondi All the IPA modules declare a pipelineName that is identical to their name. As we now support creating IPAs by name (either explicitly provided by the pipeline handlers or by using the pipeline name), the duplicated information in IPAModuleInfo is redundant. Remove it. Reviewed-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Reviewed-by: Hans de Goede Tested-by: Niklas Söderlund Signed-off-by: Jacopo Mondi Signed-off-by: Hans de Goede --- include/libcamera/ipa/ipa_module_info.h | 1 - src/ipa/ipu3/ipu3.cpp | 1 - src/ipa/mali-c55/mali-c55.cpp | 1 - src/ipa/rkisp1/rkisp1.cpp | 1 - src/ipa/rpi/pisp/pisp.cpp | 1 - src/ipa/rpi/vc4/vc4.cpp | 1 - src/ipa/simple/soft_simple.cpp | 1 - src/ipa/vimc/vimc.cpp | 1 - src/libcamera/ipa_module.cpp | 15 ++++++--------- test/ipa/ipa_module_test.cpp | 3 --- 10 files changed, 6 insertions(+), 20 deletions(-) diff --git a/include/libcamera/ipa/ipa_module_info.h b/include/libcamera/ipa/ipa_module_info.h index 3507a6d76..436ec82d7 100644 --- a/include/libcamera/ipa/ipa_module_info.h +++ b/include/libcamera/ipa/ipa_module_info.h @@ -16,7 +16,6 @@ namespace libcamera { struct IPAModuleInfo { int moduleAPIVersion; uint32_t pipelineVersion; - char pipelineName[256]; char name[256]; } __attribute__((packed)); diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp index 4bdc4b767..42d475ecc 100644 --- a/src/ipa/ipu3/ipu3.cpp +++ b/src/ipa/ipu3/ipu3.cpp @@ -672,7 +672,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "ipu3", - "ipu3", }; /** diff --git a/src/ipa/mali-c55/mali-c55.cpp b/src/ipa/mali-c55/mali-c55.cpp index 1d3af0627..47bcd3748 100644 --- a/src/ipa/mali-c55/mali-c55.cpp +++ b/src/ipa/mali-c55/mali-c55.cpp @@ -380,7 +380,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "mali-c55", - "mali-c55", }; IPAInterface *ipaCreate() diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index 58ef163d8..e0dde542c 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -481,7 +481,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "rkisp1", - "rkisp1", }; IPAInterface *ipaCreate() diff --git a/src/ipa/rpi/pisp/pisp.cpp b/src/ipa/rpi/pisp/pisp.cpp index fd28fc385..88deccfd1 100644 --- a/src/ipa/rpi/pisp/pisp.cpp +++ b/src/ipa/rpi/pisp/pisp.cpp @@ -1147,7 +1147,6 @@ const IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "rpi/pisp", - "rpi/pisp", }; IPAInterface *ipaCreate() diff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp index b6ca44e7a..f30eee7ff 100644 --- a/src/ipa/rpi/vc4/vc4.cpp +++ b/src/ipa/rpi/vc4/vc4.cpp @@ -633,7 +633,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "rpi/vc4", - "rpi/vc4", }; IPAInterface *ipaCreate() diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp index 629e1a32d..d4ab91e30 100644 --- a/src/ipa/simple/soft_simple.cpp +++ b/src/ipa/simple/soft_simple.cpp @@ -343,7 +343,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 0, "simple", - "simple", }; IPAInterface *ipaCreate() diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp index 4162b848f..bae48ea90 100644 --- a/src/ipa/vimc/vimc.cpp +++ b/src/ipa/vimc/vimc.cpp @@ -183,7 +183,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 0, "vimc", - "vimc", }; IPAInterface *ipaCreate() diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp index c89887954..6e8513d0e 100644 --- a/src/libcamera/ipa_module.cpp +++ b/src/libcamera/ipa_module.cpp @@ -215,18 +215,15 @@ Span elfLoadSymbol(Span elf, const char *symbol) * \var IPAModuleInfo::pipelineVersion * \brief The pipeline handler version that the IPA module is for * - * \var IPAModuleInfo::pipelineName - * \brief The name of the pipeline handler that the IPA module is for - * - * This name is used to match a pipeline handler with the module. - * * \var IPAModuleInfo::name * \brief The name of the IPA module * - * The name may be used to build file system paths to IPA-specific resources. - * It shall only contain printable characters, and may not contain '*', '?' or - * '\'. For IPA modules included in libcamera, it shall match the directory of - * the IPA module in the source tree. + * This name is used to match the IPA module. + * + * The name may also be used to build file system paths to IPA-specific + * resources. It shall only contain printable characters, and may not contain + * '*', '?' or '\'. For IPA modules included in libcamera, it shall match the + * directory of the IPA module in the source tree. * * \todo Allow user to choose to isolate open source IPAs */ diff --git a/test/ipa/ipa_module_test.cpp b/test/ipa/ipa_module_test.cpp index 1c97da324..af71c3285 100644 --- a/test/ipa/ipa_module_test.cpp +++ b/test/ipa/ipa_module_test.cpp @@ -37,12 +37,10 @@ protected: cerr << "IPA module information mismatch: expected:" << endl << "moduleAPIVersion = " << testInfo.moduleAPIVersion << endl << "pipelineVersion = " << testInfo.pipelineVersion << endl - << "pipelineName = " << testInfo.pipelineName << endl << "name = " << testInfo.name << "got: " << endl << "moduleAPIVersion = " << info.moduleAPIVersion << endl << "pipelineVersion = " << info.pipelineVersion << endl - << "pipelineName = " << info.pipelineName << endl << "name = " << info.name << endl; } @@ -58,7 +56,6 @@ protected: IPA_MODULE_API_VERSION, 0, "vimc", - "vimc", }; count += runTest("src/ipa/vimc/ipa_vimc.so", testInfo);