From patchwork Tue Jul 21 14:59:52 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 27433 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A9315BDE4C for ; Tue, 21 Jul 2026 15:00:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 55D6C67E63; Tue, 21 Jul 2026 17:00:55 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="gq7l7GNi"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DINaFbK1"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E04167E67 for ; Tue, 21 Jul 2026 17:00:53 +0200 (CEST) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LDg8hu1842122 for ; Tue, 21 Jul 2026 15:00:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=+3RCnHl3qpA ursGcygSIZTEW6IU52Xet4/q1mpbNFAA=; b=gq7l7GNi/vHxkVkDkLjGyLqv/mX 4Fu0iAdLfnq+NwcAwoeG+nMhexLAflo4Sc8GB5oTA54k+g6gr9v9YeYKcbb6KM4w pQRLIckQhfqY1rfUwQ08Tc/CSpjC7salj9RvkdUrkyiEkCqqkLrhCyB53Z6DITID 15SMA4LyBFRgarL9YR60DOWGeA7Z+ljk7h0r4rkAShyIk6aaShp+6FgJdTrIyafQ QFuz8RXnucPQVwkScIYgXnpuQtp41YOmlfoA49cUM91cpKEa3k8xEJn8Pdm02Thh NquKhhcO11MYKTEVG/bmuWhvKLGkjTtX023CgOR9xtAPgkP2eyd4aS3Xm3w== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj1se2vn4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 15:00:51 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-5276aa86d00so4061101cf.2 for ; Tue, 21 Jul 2026 08:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784646051; x=1785250851; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+3RCnHl3qpAursGcygSIZTEW6IU52Xet4/q1mpbNFAA=; b=DINaFbK1rpZe9x26LpB9+/tB/9HdxnTZ7PRwb/gc2xj0la5qKlrtk18TxnlERZXt0g Ge+lnMdjBmH2+l1fM69iCWuBMnz48OrvzLqqgc7t/zUqmHd5Fuh7NlYjdza/95+t6Xju AUEQ09GITU8n2YS9bkBjJiCVsRecUTPjTMocoho8vI3kvwnUCjMUzO1kmONo8aLPL8W5 yvUOTi1Z3LPYJxpfUWWvKEYi47wDTgPH8RO/kSdDgQgZ3LAtEM4pYqKuZrgXOU6vFKLN Xsm0fsLTh6MpxdeAK8s9vrpfa596RyQ7ZZQgZzHYHI4cQ9vk5iZp66SdyNy3xBHsrdAw QOIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784646051; x=1785250851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+3RCnHl3qpAursGcygSIZTEW6IU52Xet4/q1mpbNFAA=; b=jDWV2MJxUHO5CNmtyva9NmGnOddOu0oY9B/P2l5sO/ipDmM0MIZTt0w1GzSnrSZhS9 gkXg1GXicWKCwkcmySAz6SHWrQiRDX7NTNDyHyG1tsCsqh0jfPQxUYt/CkIZvairKsLH hL6U09gWx1WTuKeV/SGnsRsmSZunY4lKwN4NtJT0zYFiGSrOlDUYlqpnIMWn/EjsjlCF mg4iVCXWbQOb+tsZAkhmf+WMipxosJ/L3HpxtaXUB6/GiZUBoikdYO8F3FwhzHMFNQDo gR4jEmpywvcg9q8YBDAX8fVmk3G6pzQNuBqUYUb5Owyr38SFQZBlw0EM/Gl2ERkIEapg B1Sw== X-Gm-Message-State: AOJu0YzOmQF19sNE3lwopoD6IjDUgklj00LCZvn7fXuip1cJFrb6JZCK aJN2FUFYPlVcSPTeCoHG6WcEODH1RGpbBam+C0pv2s5gXOOI0aHnSEGUN8N8FgKJAx6XNdfxe3b Kyfhm/KTqNmzJY4T3l/1RO6KmMEfpMkSfMb1r0wLlauj1tuIP7RWOZ2vYzBrog/wfFa1hswPET+ TcN/J7TTNN X-Gm-Gg: AfdE7clnN3l0EgjPjYEY9kD/1cIatFQyYVSNzYDV7W5gztQBmx8Aq6hFHZhzUb6VwpE 6bpiMus4HC09S92nJjyMbt+SoR7ChMtmy4aSP0H/WUpgYQG7R8r8oUevZDQOoNabvZk1ChlbX6m 0NddSquErzG3RxiGJzWMggR5W+T4ZuuFKQb6AmRT1yDxczn7vsiCqnWLYC8Q6cViPXTB45Ac8XC dZOwML/tJHlU8NSrgYg6cpVOBMPRsPeFtMFEyG4B5FOFDA/spUs44vhUU6HjqYUb+96xnXUp++W yt+m1hurJQb0ohj7aToEdd9upDQNBNXljPm5klOKyApu0U8pUU1nhn7V7eOKcoEHC/lx0EA2Qf9 22nf8EXxaogellHGSYSwstyQM+Ssv1OR9HbEmDnnq/ioNAJraMtKyi/0R/nddcFJfnfew/yA8Bh X6+Wzolo47hNOSFnM= X-Received: by 2002:ac8:5809:0:b0:51c:709:b81c with SMTP id d75a77b69052e-5213b1494c9mr180953511cf.32.1784646011114; Tue, 21 Jul 2026 08:00:11 -0700 (PDT) X-Received: by 2002:ac8:5809:0:b0:51c:709:b81c with SMTP id d75a77b69052e-5213b1494c9mr180943681cf.32.1784646002810; Tue, 21 Jul 2026 08:00:02 -0700 (PDT) Received: from shalem (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1712a5f837sm615968066b.32.2026.07.21.08.00.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 08:00:02 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Loic Poulain , Hans de Goede Subject: [PATCH v2 2/7] software_isp: Rename simple IPA setIspParams signal to paramsComputed Date: Tue, 21 Jul 2026 16:59:52 +0200 Message-ID: <20260721145958.68489-3-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721145958.68489-1-johannes.goede@oss.qualcomm.com> References: <20260721145958.68489-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: 93kTLbL8m6XAGgDP2kxfeS8uhjPH4WM5 X-Authority-Analysis: v=2.4 cv=TIZ1jVla c=1 sm=1 tr=0 ts=6a5f89a3 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=X9iWcBBwFAc5_HUTaPUA:9 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDE1OCBTYWx0ZWRfXwiTmHttPCHYp 4xKK8CU84VPkRCbmPHvuMoNa9eRX06yxjOMxKLl+D4otauRrbS9ZA3TMANjs4Dhpm6dIa7CrgfC pRq1WwgCP4IYNfeyp2N136CoK+BaoNg= X-Proofpoint-GUID: 93kTLbL8m6XAGgDP2kxfeS8uhjPH4WM5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDE1OCBTYWx0ZWRfX1M+j7yefVhNl XHcHD+VFwCICO+I8qcQFioODBfmVuTZVYZwUjG7sOVkwpBpBcZtCL0tYoltyUXnqRW2qtiVob2X YEH+EcJlD6ZUaUB+PIvyXeNEb78xpd4U1xzy3VIawkzWI34zjQhwxF8xwPVuPafBNv2eL2HDSR/ wbAtJWwgh9ZlaxOlRSHmBOY9JSbzwK9gOBFNSuv4IQVg5uWmc8Lu/wGLKR9wx16FAqI8/XCvGLH 3S4948wtnGg3LvEY1nvEGL/qnetecYpjgg0J5Yvg3UoPgozc90PG2XEsZ8alU+Vq1kaK0S4emWY m7KwSk+3LhjkCWrj3na1N/lNUBSsviph/TFh7Udu/NGLtji5XVjL2hO0q9DIyoy2l6kthiviz8B Ubx4sIEXUDZOQcSTOWrYiO0izXuxzIaJXhyUZM4LVE9ht7S+qrSwkOo6v8YIZLks+9ngKngWsq+ OSVRtKBpjkt8TOzwbfw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.134, FMLib:17.12.100.49 definitions=2026-07-21_03,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 spamscore=0 clxscore=1015 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210158 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Rename the simple IPA setIspParams signal to paramsComputed and pass the frame-number as argument to make the simple IPA behavior consistent with other IPA implementations. Signed-off-by: Hans de Goede --- include/libcamera/internal/software_isp/software_isp.h | 2 +- include/libcamera/ipa/soft.mojom | 2 +- src/ipa/simple/soft_simple.cpp | 2 +- src/libcamera/software_isp/software_isp.cpp | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h index 4f72dce9b..58353301f 100644 --- a/include/libcamera/internal/software_isp/software_isp.h +++ b/include/libcamera/internal/software_isp/software_isp.h @@ -89,7 +89,7 @@ public: Signal setSensorControls; private: - void saveIspParams(); + void saveIspParams(uint32_t frame); void setSensorCtrls(const ControlList &sensorControls); void statsReady(uint32_t frame, uint32_t bufferId); void inputReady(FrameBuffer *input); diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom index 77328c5fd..55a00b598 100644 --- a/include/libcamera/ipa/soft.mojom +++ b/include/libcamera/ipa/soft.mojom @@ -33,6 +33,6 @@ interface IPASoftInterface { interface IPASoftEventInterface { setSensorControls(libcamera.ControlList sensorControls); - setIspParams(); + paramsComputed(uint32 frame); metadataReady(uint32 frame, libcamera.ControlList metadata); }; diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp index d4ab91e30..3ee7b0d65 100644 --- a/src/ipa/simple/soft_simple.cpp +++ b/src/ipa/simple/soft_simple.cpp @@ -292,7 +292,7 @@ void IPASoftSimple::computeParams(const uint32_t frame) algo->prepare(context_, frame, frameContext, params_); params_->combinedMatrix = context_.activeState.combinedMatrix; - setIspParams.emit(); + paramsComputed.emit(frame); } void IPASoftSimple::processStats(const uint32_t frame, diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index 137341fe2..7efd5cf4c 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -170,7 +170,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor, return; } - ipa_->setIspParams.connect(this, &SoftwareIsp::saveIspParams); + ipa_->paramsComputed.connect(this, &SoftwareIsp::saveIspParams); ipa_->metadataReady.connect(this, [this](uint32_t frame, const ControlList &metadata) { metadataReady.emit(frame, metadata); @@ -431,7 +431,7 @@ void SoftwareIsp::process(uint32_t frame, FrameBuffer *input, FrameBuffer *outpu ConnectionTypeQueued, frame, input, output, debayerParams_); } -void SoftwareIsp::saveIspParams() +void SoftwareIsp::saveIspParams([[maybe_unused]] uint32_t frame) { debayerParams_ = *sharedParams_; }