From patchwork Tue Jul 21 14:59:53 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 27428 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 78C71BDE4C for ; Tue, 21 Jul 2026 15:00:11 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CC64567E7D; Tue, 21 Jul 2026 17:00:10 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="T1GBItW3"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ONohk9CK"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DDFFD67E79 for ; Tue, 21 Jul 2026 17:00:07 +0200 (CEST) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LDfvI61687427 for ; Tue, 21 Jul 2026 15:00:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=8MmRQKljRR3 2dXHcem2mQCWfAENUzFEK6jiQMlb0uCg=; b=T1GBItW3K/q35wY2t0CkvUkotlw e5UEMPczRKUMNDwJKzj9qho2nDht3f4vGf1aSnpEdYuIbQFUte+HvEBeAgFLzJ74 jyWyGaA3/hV7+W3WiPC+ClvU0n8TkKTcDpofSCWdD5tMwt8L8l8tNABSbCHr0Yg9 RK8rsh6oR7MmVMmOY3X/QidiLT2cEU7teC2jqcDov5PSboN/G+M9f+DfwUvIOLmb 8kNi2GDr8jRNm1FoC6uH6G+LGHgoYO0wimQwDvntPbN/i5UD03s6FEIkvOpX/glF oT7V+67pzjkN2+ujxDdysNzSUQ4hxhtJMgpD/+QJSD911F+VcekKp+9gerw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj9c40hbj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 15:00:05 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c19493ac2so11024051cf.1 for ; Tue, 21 Jul 2026 08:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784646005; x=1785250805; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8MmRQKljRR32dXHcem2mQCWfAENUzFEK6jiQMlb0uCg=; b=ONohk9CK1rdg59wuHLSgWpqpLwTuQgPQP/PK6gcivdZxYaQd+6hKfDuJ0qSuZywm5m pgzhDnHfB5ddarASbQZQxmTz0z0bAYpqhWJgG4Nv05LWWI8wdaNG2UIBM3MGM+OFW1ag tQ0kg2BrzVzPoelINQsfldsHeaSYNuTwqc7HI8Xr1FWNhrplQVKNMGie9xQ8G1PI5Lw0 iIysndKq3Dskitp7IsOTU3V3vvZJOnAb7/pyySvHGEtgfIRnHH5orpH30y8sTN6Jjq1v qCLeZ81IZmnXkZUAZt7WPAgmG2weXFgBGhpbCJhdt4gepR7LIfsHgadMPBfWdqzGzZ9n +EZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784646005; x=1785250805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=8MmRQKljRR32dXHcem2mQCWfAENUzFEK6jiQMlb0uCg=; b=K4mveVjjJZVtFZ6kM3MIqLqWtCvB+2cHHfbgve2w92yev8dp3xEFirCZrzhiJT/BsZ Rje8dT9MsrgLvwVmtLnp5SIWKyCMHdVL+17I9vPt55NvvuQNRxUD9+YcfIfXte7Tsx+H Zblv/wZyfhg7mUbnrl8U00CJYYkecNCnrIYpZ4n9E7FvSrpzNqy5pH3q9yon4n/euGvZ gjJbnCIjzctlLdXaE+mJ+BNkL+LoNC565QWAfyUNPAm1hBuD9kbH13kDe+YNCvODD+Zf NUI1pAztGCKWA4QfpfvYa4bx4UXEw+Zno1vWZ4f1plDCtPDgeLoziEkM3YrImgITnI8V 72zA== X-Gm-Message-State: AOJu0Yw456yialNCivQDbyRT/8kiU2kOd8uxw4QRLUN2uUC4oV0rs5qB 6bpDBzN2MK+MwnA3Av8CPjtcnvcp7i06XeMk4OvU5ZB+eZSQr5T9PN01Wmh+7MAU1OCfs+d1Otc XQ8p+s8tT/cU8Sqw0i8sDa/zG4O7mGkAxCnSoq0MieY6KAIE3JMG9iOlm5EEnCQ9qDkTLIkBj5d EvQPbsvH7m X-Gm-Gg: AfdE7cljAXa1KrxPquttBmOz9jCjkiVMiwYBzX4kjr0KPc46/yfBAOxEr8CoGXpDhOM 7dOtuAUztHEI51hzRtMM5tUGcSXB1dA32+XoWqaq2MeRcUrTdZ08hBlaND+w8y6Sdt/iK07eAuP 0j+eB6NtCRx/AG4Tk0MvSZ8uS5A90nRAc8chY7qcQX5vHffnJoS4BVselLqlq//drr9vroaaQNC uUfl0LRJa4bDMrqPRaLy+AH21DB0NNscKVcmFgv+IODSC9erbxT6Ks6Z1cGVWPKa6UTGL8SNYpR CWFEV6gcPT9OihU2KQ4BHOldswlqRjHoTvjjSae6B9m8dK4nVDnyZP3XECTM6+aSNcgvZUvg72B MiF0nmmI1Gy7SPUtm7e/cHAYcAv36TygJrrU6dieZoPsD+LPaeN9wm/Gq3e5/T4pYbF6as1l7zP 38GjpZQpRgBToG65A= X-Received: by 2002:a05:622a:4188:b0:51b:fb4f:afdc with SMTP id d75a77b69052e-5213c0081ccmr175885331cf.11.1784646004613; Tue, 21 Jul 2026 08:00:04 -0700 (PDT) X-Received: by 2002:a05:622a:4188:b0:51b:fb4f:afdc with SMTP id d75a77b69052e-5213c0081ccmr175884701cf.11.1784646003992; Tue, 21 Jul 2026 08:00:03 -0700 (PDT) Received: from shalem (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1712a5f837sm615968066b.32.2026.07.21.08.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 08:00:03 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Loic Poulain , Hans de Goede Subject: [PATCH v2 3/7] camss: Add cammss utility functions Date: Tue, 21 Jul 2026 16:59:53 +0200 Message-ID: <20260721145958.68489-4-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721145958.68489-1-johannes.goede@oss.qualcomm.com> References: <20260721145958.68489-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Authority-Analysis: v=2.4 cv=I4JVgtgg c=1 sm=1 tr=0 ts=6a5f8975 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=Z-vQv52y2RNpiqyDFZQA:9 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: AeH8dsJxIMqhCvLhzMSX_FVCAMmZPxwk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDE1OCBTYWx0ZWRfX5m7jyfByMSCc 2yXfEdPiw+DpEiGUeu83Vw7BbGUCM4pP4kQZ2RYqjjiZNYHU2s4kEujDfEKuBS53tF6qXnAPIy7 mRTH0jTXcTtTFuotXJ+QqWLvmoHLp2Jic4yfmdrkZK0ZstCBxrXPsgWblLa0XWGPqJ++/Br4/u2 Kv1iVEhVZGMfyv+o3EVGuUcBqBenKpxzhkfNq7STaMt9E2IKg1nMh4TnriurRAjsJrOkEe4/nce HiDjKb9XZTk2Ejhq/I5WE1aFLVUynw1ql4HYVZoNkuE9LafHEN5258XhdvN6lmNVaS04Bn4HAQK Da3OBTU1Ic1VO5/ChMx/ihRRz2VXglg/lZOdvMSFpIFCM9An9iYEXM0smH8KZ/zFSsy3Q2jslxP bKq1+JNbyNiE4qyBCZg8iL5uisYH+Kq7t65UUr1qkQqRcSAeT0indAQSWAsesb7bF4jwYq5Cl9e CqaBLnkY5hW5Cqel+dA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDE1OCBTYWx0ZWRfX/E57ePJ11ILH WsraElOwBIM/7r+4ac1wwKqwlf+7kST21bwPL35X0HPR6SB5umCG3MyPxHQIDZgkJM0KpHk5hFC aADPvjLgUIM0anJx6MRFtrzdZYUxbAA= X-Proofpoint-GUID: AeH8dsJxIMqhCvLhzMSX_FVCAMmZPxwk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.134, FMLib:17.12.100.49 definitions=2026-07-21_03,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210158 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add camss_util.[h|cpp] files with some small helper functions shared between Camss* classes. Signed-off-by: Hans de Goede --- src/libcamera/pipeline/camss/camss_util.cpp | 39 +++++++++++++++++++++ src/libcamera/pipeline/camss/camss_util.h | 19 ++++++++++ 2 files changed, 58 insertions(+) create mode 100644 src/libcamera/pipeline/camss/camss_util.cpp create mode 100644 src/libcamera/pipeline/camss/camss_util.h diff --git a/src/libcamera/pipeline/camss/camss_util.cpp b/src/libcamera/pipeline/camss/camss_util.cpp new file mode 100644 index 000000000..96b1bbc72 --- /dev/null +++ b/src/libcamera/pipeline/camss/camss_util.cpp @@ -0,0 +1,39 @@ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ +/* + * Qualcomm CAMSS utility functions + * + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ + +#include "camss_util.h" + +#include + +#include + +#include "libcamera/internal/v4l2_videodevice.h" + +namespace libcamera { + +LOG_DECLARE_CATEGORY(Camss) + +bool camssV4L2DeviceFormatMatchesStreamConfig(const V4L2DeviceFormat &fmt, + const StreamConfiguration &cfg, + const char *msgPrefix) +{ + if (cfg.pixelFormat != fmt.fourcc.toPixelFormat(false) || cfg.size != fmt.size || + cfg.stride != fmt.planes[0].bpl) { + LOG(Camss, Error) + << msgPrefix + << " StreamConfiguration vs V4L2DeviceFormat mismatch" + << " pixelFormat " << cfg.pixelFormat << ", " << fmt.fourcc.toPixelFormat(false) + << " size " << cfg.size << ", " << fmt.size + << " stride " << cfg.stride << ", " << fmt.planes[0].bpl + << " frameSize " << cfg.frameSize << ", " << fmt.planes[0].size; + return false; + } + + return true; +} + +} /* namespace libcamera */ diff --git a/src/libcamera/pipeline/camss/camss_util.h b/src/libcamera/pipeline/camss/camss_util.h new file mode 100644 index 000000000..111c305aa --- /dev/null +++ b/src/libcamera/pipeline/camss/camss_util.h @@ -0,0 +1,19 @@ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ +/* + * Qualcomm CAMSS utility functions + * + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ + +#pragma once + +namespace libcamera { + +struct StreamConfiguration; +class V4L2DeviceFormat; + +bool camssV4L2DeviceFormatMatchesStreamConfig(const V4L2DeviceFormat &fmt, + const StreamConfiguration &cfg, + const char *msgPrefix); + +} /* namespace libcamera */