From patchwork Wed Jul 8 15:51:11 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 27336 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C1ECCC3330 for ; Wed, 8 Jul 2026 15:51:54 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 27FB5660F6; Wed, 8 Jul 2026 17:51:54 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="sf10ONKg"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5865F660AB for ; Wed, 8 Jul 2026 17:51:21 +0200 (CEST) Received: from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it [93.46.82.201]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E8253FF5; Wed, 8 Jul 2026 17:50:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1783525831; bh=l3IWqtX/3k/0xTkpngmJmTTxrkKv+Uf3ZsubdNM+OxY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=sf10ONKgHbe23OqF9Nc6EI6oL3phy8XBTYNgpf1AP9909y3mtqSb0SnKeU/0JqwsH gn2XY0s9indGJJPoQQ5xcUdT0XN2sVhIj6thd6c416zfudMFDArSCm1/A3JMLFdkUB Zv2WMIUL4QYp4U423tllqUtNL9WrSc7mQQjVUMbI= From: Jacopo Mondi Date: Wed, 08 Jul 2026 17:51:11 +0200 Subject: [PATCH v5 29/36] ipa: libipa: lsc: Document LscDescriptor::sensorSize usage MIME-Version: 1.0 Message-Id: <20260708-libipa-algorithms-v5-29-0759d0359f52@ideasonboard.com> References: <20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com> In-Reply-To: <20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, Stefan Klug Cc: Jacopo Mondi X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=966; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=l3IWqtX/3k/0xTkpngmJmTTxrkKv+Uf3ZsubdNM+OxY=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqTnHriNByfvEG9L+aX61mBJ4JYPPHXHVMKhCNa FeSDhJCITiJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak5x6wAKCRByNAaPFqFW PP4OD/9gZ6gK29OZ5QMSPG7jZ7pI8/OC/IENvR/f8WjI0R+LzvfPiSnxFYFzLgQbi7EWw66YBUq o1zYfJfMUYZuWpFJmb5Is5VU46XKoIq5oEqOI1bErAfPsRngoBckVUT6ohlwTNZ5G2F3TeIRGUZ ZR1wr85laohZtmBmNuK6/BCmYE/UiyqldibhRpwSV0WdJQ3zSKZFjv46QWnT9U386g3+BLIzrKQ JAPFb8K+oQx72P7+YdXN1UGJ/n3uWfnfQIaEgnzcnP4hAyubyjwBlV5jL9FSMlnPuih/QwWrbGi fhluHA8aN16lTwYhW1G670lxMuYmp0FrmymG7Xt2JXBJNm21LQzyLC8++WbKvUe4W2QdmaMSVPH qnOHFIdfd+l3EhaFGZX1xVazU4qv+qUILe6rhhAX/oSf5B4Gg9gB40TwReKZ9U9B8gqaDtdhisd 1+Rdnhw8RkxI/pgq+ohXKl4y3aVeyxKLQTTRlEUjlDNDRPC0V7DNAbaauNFURVpzWVGkcca5LHW aO+ZBTFXsa5VWGcV1lktP2DaKiR+QQyDYqTX40Ve0Kj61uED1w8g1JjoxtyiGVY5+g2g6tL9qnF AmSXFhW63pYBPcrdu1elw7CFtYJkaIPGexYOYQdObYnNLIO0SyqMDel/emNYTDC45D3UVZvVULS TwuamAuvvngyMfA== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Now that sensorSize_ has been removed from LscPolynomial and is passed to the Lsc algorithm through LscDescriptor document its intended purpose. Signed-off-by: Jacopo Mondi --- src/ipa/libipa/lsc.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp index 1d2f8eb1b41b..13b1b738106b 100644 --- a/src/ipa/libipa/lsc.cpp +++ b/src/ipa/libipa/lsc.cpp @@ -179,6 +179,10 @@ namespace lsc { * k4: 0.0 * \endcode * + * The LSC tables or the polynomial definition are generated at tuning time + * using an image of known resolution which needs to be specified in + * LscDescriptor::sensorSize. + * * At LscAlgorithm::configure() time the LSC tables are re-sampled on the * sensor's crop rectangle in use to adapt them to the configuration in use for * a streaming session. Polynomial LSC tables support re-sampling and can be