From patchwork Wed Jul 8 09:25:19 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 27297 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6FFF5C333D for ; Wed, 8 Jul 2026 09:25:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 15BA0660D8; Wed, 8 Jul 2026 11:25:44 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="iu5xNLwM"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D15AA660A2 for ; Wed, 8 Jul 2026 11:25:14 +0200 (CEST) Received: from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it [93.46.82.201]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 42EA83FD4; Wed, 8 Jul 2026 11:24:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1783502665; bh=meGdcwZyy3+EywvA9mHqxiAiLqYzviZC14BmcAakpzk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=iu5xNLwM4OH94BnDYh9rCFkdD9p6ZOJJBVAcUOQtUsHRLbryoe0zwHEiNdJzZtzAJ Fmq8NqKy+0+Q06AIN5JodQCWY7/AOn5q7zbfiNEHurFdDPhmfv5FfNUPq4/QI3mtwo iJO1aKcNHRMFQ1IIIEa8EaOc+XyJx2vReeXpwxic= From: Jacopo Mondi Date: Wed, 08 Jul 2026 11:25:19 +0200 Subject: [PATCH v4 32/35] ipa: libipa: lsc: Rename sampleForCrop to resampleLscData MIME-Version: 1.0 Message-Id: <20260708-libipa-algorithms-v4-32-f0e99f035294@ideasonboard.com> References: <20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com> In-Reply-To: <20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, Stefan Klug Cc: Jacopo Mondi X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4426; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=meGdcwZyy3+EywvA9mHqxiAiLqYzviZC14BmcAakpzk=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqThdwb6tZ9q2McfZLJvbJHbe41sW0bUTN1gVan 9CzinBJsBiJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak4XcAAKCRByNAaPFqFW PJBmEAC1Rob3rp3W1PEK4zgW8lAR5ytNr/pYx14IP/qRx0Y3oNqsL+eQQxmJaRKKpTcN2zt6WlM s+B/lZTD2/skk0SDSVH6Fvyb4OYOAol51cxvAmraW1qo9x/Sio1tavWEbnexPZaTTakj6JuSBmj pUYgqIXrmpEGKQ5wkCCZPMXtTkrOIdEijKiu0B2OlQwi24lokmOBffqLxx6Cr0oOnhEEGJXVoql HS2+/Jq3jc9bwRkqTLf8IRWK7Xh356BE2o/uYL6QFzLB6x7D+p0ypWODZ4Hq6YXi6HjyQafDGJy Pxwdwh8KzHok+VLvfXHnQVrC7MhxH19pL1gtPjUMZ0E9sZfTwMhAXtFuni+ytLPRpce817GTkTy 4xq2XhJiwgIrc07Z8aKcY5xRUgQeGmwl47Cm6o+t4T/7r9BVHb1EO83//YYv2FQcQkL1oiKoftg 0vK6hwNE/SZY6hT0raCnh7JC/4Eecx9DVUQEeWQGC25amDm1+dGnw5D/iFpPLtuNwwojdE4Kl0P MXQNutwTpuhl/fNCOPtudYOs78yee4jPw1CBgy5kKURtUxAnzm+n+29/8CtUOMKj9XQHDQ5rJc+ OIA00W6zQPBvTN7o/cFY6jR/K9QHR/OtouyJUNPE44Q7bomBti0DUAVhadhO4UyEA83jnuGxbkz 02NbeMB/v2S6Q5A== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Rename the function to a more precise name. Signed-off-by: Jacopo Mondi --- src/ipa/libipa/lsc.cpp | 2 +- src/ipa/libipa/lsc.h | 2 +- src/ipa/libipa/lsc_base.cpp | 2 +- src/ipa/libipa/lsc_base.h | 4 ++-- src/ipa/libipa/lsc_polynomial.cpp | 2 +- src/ipa/libipa/lsc_polynomial.h | 4 ++-- src/ipa/libipa/lsc_table.h | 6 +++--- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp index f5646937c60a..0ce40c09caed 100644 --- a/src/ipa/libipa/lsc.cpp +++ b/src/ipa/libipa/lsc.cpp @@ -269,7 +269,7 @@ void LscAlgorithmBase::process(lsc::FrameContext &context, ControlList &metadata * analogCrop on a grid specified by \a xPos and \a yPos. Re-sampling of * LSC data is currently supported by polynomial-based LSC tables. * - * \sa LscImplementation::sampleForCrop + * \sa LscImplementation::resampleLscData * * \return 0 on success, a negative error code otherwise */ diff --git a/src/ipa/libipa/lsc.h b/src/ipa/libipa/lsc.h index 6dc76b6572b3..1f46555f9bf0 100644 --- a/src/ipa/libipa/lsc.h +++ b/src/ipa/libipa/lsc.h @@ -98,7 +98,7 @@ public: { LOG(Lsc, Debug) << "Sample Lsc data for " << analogCrop; lsc::ComponentsMap lscData = - impl_->sampleForCrop(analogCrop, xPos, yPos); + impl_->resampleLscData(analogCrop, xPos, yPos); /* * Retain a copy of the components table. diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp index 235f11e8c53b..c87e2680d973 100644 --- a/src/ipa/libipa/lsc_base.cpp +++ b/src/ipa/libipa/lsc_base.cpp @@ -127,7 +127,7 @@ void Interpolator>:: */ /** - * \fn LscImplementation::sampleForCrop + * \fn LscImplementation::resampleLscData * \brief Re-sample the LSC components for \a cropRectangle * \param[in] cropRectangle The sensor analogue crop rectangle * \param[in] xPos List of horizontal positions of the LSC grid nodes diff --git a/src/ipa/libipa/lsc_base.h b/src/ipa/libipa/lsc_base.h index 4edcb2637d1b..a25d951e8ddb 100644 --- a/src/ipa/libipa/lsc_base.h +++ b/src/ipa/libipa/lsc_base.h @@ -74,8 +74,8 @@ public: const LscDescriptor &descriptor) = 0; virtual lsc::ComponentsMap - sampleForCrop(const Rectangle &cropRectangle, - std::vector xPos, std::vector yPos); + resampleLscData(const Rectangle &cropRectangle, + std::vector xPos, std::vector yPos) = 0; }; } /* namespace ipa */ diff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp index 7d4381973646..b88048e873d9 100644 --- a/src/ipa/libipa/lsc_polynomial.cpp +++ b/src/ipa/libipa/lsc_polynomial.cpp @@ -190,7 +190,7 @@ int LscPolynomialBase::parseLscData(const ValueNode &sets, */ /** - * \fn LscPolynomial::sampleForCrop() + * \fn LscPolynomial::resampleLscData() * \brief Re-sample the LSC components for \a cropRectangle * \param[in] cropRectangle The sensor analogue crop rectangle * \param[in] xPos List of horizontal positions of the LSC grid nodes diff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h index a84a736734e1..00bbd068d537 100644 --- a/src/ipa/libipa/lsc_polynomial.h +++ b/src/ipa/libipa/lsc_polynomial.h @@ -78,8 +78,8 @@ public: } lsc::ComponentsMap - sampleForCrop(const Rectangle &cropRectangle, - std::vector xPos, std::vector yPos) override + resampleLscData(const Rectangle &cropRectangle, + std::vector xPos, std::vector yPos) override { lsc::ComponentsMap components; diff --git a/src/ipa/libipa/lsc_table.h b/src/ipa/libipa/lsc_table.h index fe4e133060a6..c3d6c6b95dcd 100644 --- a/src/ipa/libipa/lsc_table.h +++ b/src/ipa/libipa/lsc_table.h @@ -50,9 +50,9 @@ public: } lsc::ComponentsMap - sampleForCrop([[maybe_unused]] const Rectangle &cropRectangle, - [[maybe_unused]] std::vector xPos, - [[maybe_unused]] std::vector yPos) override + resampleLscData([[maybe_unused]] const Rectangle &cropRectangle, + [[maybe_unused]] std::vector xPos, + [[maybe_unused]] std::vector yPos) override { LOG(LscTable, Warning) << "Tabular LSC data doesn't support resampling";