From patchwork Wed Jul 8 09:25:15 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 27294 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7B4F8C333B for ; Wed, 8 Jul 2026 09:25:42 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1E8E5660E8; Wed, 8 Jul 2026 11:25:42 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="fCdZA9/T"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id ADA4B660AB for ; Wed, 8 Jul 2026 11:25:13 +0200 (CEST) Received: from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it [93.46.82.201]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 078053FC2; Wed, 8 Jul 2026 11:24:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1783502664; bh=l3IWqtX/3k/0xTkpngmJmTTxrkKv+Uf3ZsubdNM+OxY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=fCdZA9/T18Pauuiuw+bDp6QlL4C/XvTmgbCOwHGhJeD9w8ArPdVFXj9Mnyyo/y7yf 2hpnSrqtV1nbMPr56BZGWDUw9SoKVueHKE52VL7oVVx57ZZ2KRzqoN8CP16O/w6Epu g/k8OX/VUr6empVouYS8SDWrekOtmYF1INmSM4MM= From: Jacopo Mondi Date: Wed, 08 Jul 2026 11:25:15 +0200 Subject: [PATCH v4 28/35] ipa: libipa: lsc: Document LscDescriptor::sensorSize usage MIME-Version: 1.0 Message-Id: <20260708-libipa-algorithms-v4-28-f0e99f035294@ideasonboard.com> References: <20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com> In-Reply-To: <20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, Stefan Klug Cc: Jacopo Mondi X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=966; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=l3IWqtX/3k/0xTkpngmJmTTxrkKv+Uf3ZsubdNM+OxY=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqThdvOi/6kYD2C4jdWCco9TXczXBCO4FDDcXWt ZvqZHgfLNeJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak4XbwAKCRByNAaPFqFW PJtBD/4gk+FRscxrMjYfNJY57wLjyLZ8uU82SBsRtiz8kt7llbf891TKWT0nMoG15H6Z6EJjl31 1ttVzQJCTGu1lFxBHoYVF76oCphQrrd+N0Yr72QA8yhN4ER9AyKUq5Jf/lTZhKgeo2qitQZAYiA l5RlQmZ7Hq95W0YuDU3iJWeDNSelqgyD7cDj/Ihvfrzy/8cofKhRJxNvTkmkWDoj775hW/oiK// DbD0N7yKOJBxa6wkeMjeTzh5DHX5+kTaIi6HbN4R7ZTXTqkeZGX9BwtJ0gm7mF8I3D2ja+EM1pl voGnmDAeiN/6cicINQM7uX7WEmpGQQmjWqvUlU9aFp5IXyDErfX9HJMiIYWJ9XXFv4PR9gc08nu NdLTqs4/JuUNxOvlym9lgkx1+NFmnvdFx3mPNGtMqzdHlGi2363z47tzvRJYNi0RYA1+VBeUI7M 6LiC9sa/MHodzktJNa2drL4AV0j/ImitahDpKJ0uryS3lrQFRwDQrnzjMQ5nmVdXhBxm8UeP69c DqtNnsRJN/wXu00eMn9DpRT4kwk+LzQZ8pBDGInKV74uJi5qv0PWY16tGDUTqcYBQdGS7svUxL1 r+l/R7J+5g/2mUGaUMuMiwK0L9vjOyWCelmVnzcR24LfmX+fKYYkprOKRadiboSjNwJNbU02RoV dk0KzgkoY/Yp1ww== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Now that sensorSize_ has been removed from LscPolynomial and is passed to the Lsc algorithm through LscDescriptor document its intended purpose. Signed-off-by: Jacopo Mondi --- src/ipa/libipa/lsc.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp index 1d2f8eb1b41b..13b1b738106b 100644 --- a/src/ipa/libipa/lsc.cpp +++ b/src/ipa/libipa/lsc.cpp @@ -179,6 +179,10 @@ namespace lsc { * k4: 0.0 * \endcode * + * The LSC tables or the polynomial definition are generated at tuning time + * using an image of known resolution which needs to be specified in + * LscDescriptor::sensorSize. + * * At LscAlgorithm::configure() time the LSC tables are re-sampled on the * sensor's crop rectangle in use to adapt them to the configuration in use for * a streaming session. Polynomial LSC tables support re-sampling and can be