From patchwork Wed Jul 8 09:25:05 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 27283 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DB0AEC3332 for ; Wed, 8 Jul 2026 09:25:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 57D8A660B8; Wed, 8 Jul 2026 11:25:29 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="dGW1yM+z"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C94EE6607C for ; Wed, 8 Jul 2026 11:25:10 +0200 (CEST) Received: from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it [93.46.82.201]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2C2AB3FAF; Wed, 8 Jul 2026 11:24:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1783502661; bh=ZQB2/8/lfwl0b3X1amVOEn3MSG9P/pJyN8UbLOUxTSE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=dGW1yM+z5kSEMTgWwXORnGww72Vlxw35BV9WssEYDFNtD8h1rbH9ymIoO9hG9b4Tl 7UwfVxY8KwUgvIklJ5T8XQwpvjwud5K+pYEIUJjRhp1/0KwftwPH11OQLeVKTyuDjg xBuSZxRIiYrcFpWaJxIeo+9T1o72m70vi1J0Loug= From: Jacopo Mondi Date: Wed, 08 Jul 2026 11:25:05 +0200 Subject: [PATCH v4 18/35] ipa: libipa: lsc_base: Add sampleForCrop documentation MIME-Version: 1.0 Message-Id: <20260708-libipa-algorithms-v4-18-f0e99f035294@ideasonboard.com> References: <20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com> In-Reply-To: <20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, Stefan Klug Cc: Jacopo Mondi X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1459; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=ZQB2/8/lfwl0b3X1amVOEn3MSG9P/pJyN8UbLOUxTSE=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqThdu1GCg42iOFvniekYWlEumB09cx7jdDVhX2 PpR8BTEzmuJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak4XbgAKCRByNAaPFqFW POAaD/9i0MV8LUMT20wKkqlyTUP3GnwukvWNG/dSWQ60ATB6OCau5jaFE8zdf06Eqwa4QAk8j7F 1VnCz0nG8CZlghQE17R759sd+PXbzI2XsQYEzWvZGJ796zz8vSWmEnh9waNXIGtNxWdn55lQUWc hXE7qYr24CuaYiMafqdBVNlm9VBcQAMNnZ8Il7p2Bv6eD8TbdPnU2yudpKlwLThDFmgFPzZ2dB6 JjqnLIFVFYXTgAMVi7YivGBapXq61diW+S0J3UN0qbwyLeqMVO5K3+f9jm3M6obC3IsJ31Oqhmf LC2J12jm4aw07FXcmI16Tf1qRVd97xTh6NgXY5wWrnUWyjHUUiXttKfqfHX/9uu4aEcDUwtnjdP +fthJgpEt9LUXc0o/AsfpSM5xHEZfGH0f5efuw2vdeKJ+BK+uHhiW149FXYuYsVATsmqObnpCnb 7bXIDcDnte4JaALj2PIqsirxR+aS0LR/HCxXxJiyVfef+Io8MwKoS4jGA4Kxf7wgXiKH42dToCn GVYZtQf7rIMEOd2RnoDYxSlOaGE0esjAld1s8HyZNAnpmqKPjnXAMAhJCJoNW8sl4rcthZ2exAV +UPRrkRAl0iMXXxTgcP7Urfe+BQFAfhiDRX00CVaB6hLtUmul7OBbhijPBlTN8CSn/NWnppW9HS gcmlLIzlo2ZGZPA== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Now that we have two in-tree implementations of LscImplementation detail how the two perform lsc gain re-sampling. Signed-off-by: Jacopo Mondi --- src/ipa/libipa/lsc_base.cpp | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp index 945020794b57..678ba8a9a808 100644 --- a/src/ipa/libipa/lsc_base.cpp +++ b/src/ipa/libipa/lsc_base.cpp @@ -103,6 +103,21 @@ void Interpolator:: * each segment of size 0.0625 and the list of nodes position will be * [0, 0.0625, 0.125, 0.1875, ... , 1]. It is expected that the first position * is 0 and the last position is 1. + * + * LSC tables are expressed in two formats: + * - A list of gain values (LscTable) + * - A radial polynomial (LscPolynomial) + * + * Table-based LSC tables are generated using an image at a fixed resolution and + * can't at the moment be re-sampled when a different resolution is used for a + * streaming session. Re-sampling a grid LSC table will return the same table + * as loaded from the tuning file. + * + * \todo: Implement grid based re-sampling + * + * Polynomial configurations are more flexible and can be re-sampled for a given + * sensor frame resolution using a list of horizontal and vertical nodes that + * define the LSC grid on which the polynomial is re-sampled on. */ } /* namespace ipa */