From patchwork Mon Jul 6 08:01:52 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 27232 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EFF66C331D for ; Mon, 6 Jul 2026 08:02:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9E58B66054; Mon, 6 Jul 2026 10:02:39 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SODxA9nN"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A7476603B for ; Mon, 6 Jul 2026 10:02:19 +0200 (CEST) Received: from [192.168.125.177] (mob-109-113-60-81.net.vodafone.it [109.113.60.81]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C03F23DCB; Mon, 6 Jul 2026 10:01:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1783324891; bh=dOfbZ8LZPhwdvMfBunOfkCUHa7YYqHotTtInI7cV5ow=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=SODxA9nNwaaTzKDtc8HYP3wAG7/NhF04E/b69dfnC3i2lMWlsUNywSjA90IFz9dXw 5hA+2zLE4GaFBYkHyvTYtHJ+RzzTT8DLd9r0pUPGyPJInhBnjF2ahJ9TG7pbMhY59y KPv7hi11JnQ+7lyPy1KI76hwOCxMTusOhGe/j4hA= From: Jacopo Mondi Date: Mon, 06 Jul 2026 10:01:52 +0200 Subject: [PATCH v3 32/35] ipa: libipa: lsc: Rename sampleForCrop to resampleLscData MIME-Version: 1.0 Message-Id: <20260706-libipa-algorithms-v3-32-968757b038bb@ideasonboard.com> References: <20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com> In-Reply-To: <20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, Stefan Klug Cc: Jacopo Mondi X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4426; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=dOfbZ8LZPhwdvMfBunOfkCUHa7YYqHotTtInI7cV5ow=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqS2DzUHPQ6dAjqDRKSsPiDXv7skAw4xtLQ4nEV W+G2RMM0qqJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaktg8wAKCRByNAaPFqFW PA8vD/9db0jp7gg1FhMHp2r7sW6WtDPR6SpUTRk/HXOZUnBBjDxx6h92PJ2ut3cxcXCn/4iMOHF Pm18OjWclhYwFdc4QzAQ3i454BDggWn444Ij60WgiJH1ggtfbPbCNE1X2sJ8hKoneRdMVjQWpVq gC2j6O0IxJnsTLNbeEj4Pd2AFYO/E7wQnVAiLMxQLyIkoSniLXXbcOYiQDu/Dir4wZM0fUQtC4u Xfy/FJwB9llrGk2TXrPfU8jF2HDKCGyqWfqBZghm3ACcLfyDpMLjht5YY8Wskuuff4VuImkwpQg Ue1gmx28z+7HyQ4TSNo85Fkt2+syDhAglEQoaAB05xhoTmtzWk+k9A8PDbHEzz4BL6sS2rD30BK 5RDWtfcbF3vBVWbCpjsvNqg2fwXGqVQd9G431+AwQmuUBTW8TzTrXqMlPaofJ2xIBFi8iEPoYso 2FfMKP9lpYQcDBZjLJXkfPYMyXI5HxRFv6WkJcoiqSIcMl/4636KsPpbMA0u2PdRCGZ5dWzB87W UWmjcTSLzsVdenIpqGEZO1FoaM9JLq8wRYGTRDgym95U51HinT9XMTau9NIofO/OoKvgIub7IwP rrzgZxVkNMBP0s5Vsi9jk+nuJZD4IhTnEYc1MwUSbVoqN2GVePA6vjmkqAXMZ4KnXNERoa2RT8N /cP4a8MhB/+ziQg== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Rename the function to a more precise name. Signed-off-by: Jacopo Mondi --- src/ipa/libipa/lsc.cpp | 2 +- src/ipa/libipa/lsc.h | 2 +- src/ipa/libipa/lsc_base.cpp | 2 +- src/ipa/libipa/lsc_base.h | 4 ++-- src/ipa/libipa/lsc_polynomial.cpp | 2 +- src/ipa/libipa/lsc_polynomial.h | 4 ++-- src/ipa/libipa/lsc_table.h | 6 +++--- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp index 621c04d354a8..d1dc2524fcaa 100644 --- a/src/ipa/libipa/lsc.cpp +++ b/src/ipa/libipa/lsc.cpp @@ -269,7 +269,7 @@ void LscAlgorithmBase::process(lsc::FrameContext &context, ControlList &metadata * analogCrop on a grid specified by \a xPos and \a yPos. Re-sampling of * lsc data is currently supported by polynomial-based lsc tables. * - * \sa LscImplementation::sampleForCrop + * \sa LscImplementation::resampleLscData * * \return 0 on success, a negative error code otherwise */ diff --git a/src/ipa/libipa/lsc.h b/src/ipa/libipa/lsc.h index 6dc76b6572b3..1f46555f9bf0 100644 --- a/src/ipa/libipa/lsc.h +++ b/src/ipa/libipa/lsc.h @@ -98,7 +98,7 @@ public: { LOG(Lsc, Debug) << "Sample Lsc data for " << analogCrop; lsc::ComponentsMap lscData = - impl_->sampleForCrop(analogCrop, xPos, yPos); + impl_->resampleLscData(analogCrop, xPos, yPos); /* * Retain a copy of the components table. diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp index ff5d47e85c01..f47c9619669e 100644 --- a/src/ipa/libipa/lsc_base.cpp +++ b/src/ipa/libipa/lsc_base.cpp @@ -127,7 +127,7 @@ void Interpolator>:: */ /** - * \fn LscImplementation::sampleForCrop + * \fn LscImplementation::resampleLscData * \brief Re-sample the lsc components for \a cropRectangle * \param[in] cropRectangle The sensor analogue crop rectangle * \param[in] xPos List of horizontal positions of the lsc grid nodes diff --git a/src/ipa/libipa/lsc_base.h b/src/ipa/libipa/lsc_base.h index 4edcb2637d1b..a25d951e8ddb 100644 --- a/src/ipa/libipa/lsc_base.h +++ b/src/ipa/libipa/lsc_base.h @@ -74,8 +74,8 @@ public: const LscDescriptor &descriptor) = 0; virtual lsc::ComponentsMap - sampleForCrop(const Rectangle &cropRectangle, - std::vector xPos, std::vector yPos); + resampleLscData(const Rectangle &cropRectangle, + std::vector xPos, std::vector yPos) = 0; }; } /* namespace ipa */ diff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp index 2b743ed53be7..7b3c13cb144f 100644 --- a/src/ipa/libipa/lsc_polynomial.cpp +++ b/src/ipa/libipa/lsc_polynomial.cpp @@ -190,7 +190,7 @@ int LscPolynomialBase::parseLscData(const ValueNode &sets, */ /** - * \fn LscPolynomial::sampleForCrop() + * \fn LscPolynomial::resampleLscData() * \brief Re-sample the lsc components for \a cropRectangle * \param[in] cropRectangle The sensor analogue crop rectangle * \param[in] xPos List of horizontal positions of the lsc grid nodes diff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h index a84a736734e1..00bbd068d537 100644 --- a/src/ipa/libipa/lsc_polynomial.h +++ b/src/ipa/libipa/lsc_polynomial.h @@ -78,8 +78,8 @@ public: } lsc::ComponentsMap - sampleForCrop(const Rectangle &cropRectangle, - std::vector xPos, std::vector yPos) override + resampleLscData(const Rectangle &cropRectangle, + std::vector xPos, std::vector yPos) override { lsc::ComponentsMap components; diff --git a/src/ipa/libipa/lsc_table.h b/src/ipa/libipa/lsc_table.h index fe4e133060a6..c3d6c6b95dcd 100644 --- a/src/ipa/libipa/lsc_table.h +++ b/src/ipa/libipa/lsc_table.h @@ -50,9 +50,9 @@ public: } lsc::ComponentsMap - sampleForCrop([[maybe_unused]] const Rectangle &cropRectangle, - [[maybe_unused]] std::vector xPos, - [[maybe_unused]] std::vector yPos) override + resampleLscData([[maybe_unused]] const Rectangle &cropRectangle, + [[maybe_unused]] std::vector xPos, + [[maybe_unused]] std::vector yPos) override { LOG(LscTable, Warning) << "Tabular LSC data doesn't support resampling";