From patchwork Fri Jul 3 12:25:10 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 27163 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C782CC328C for ; Fri, 3 Jul 2026 12:26:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5F45865FCA; Fri, 3 Jul 2026 14:26:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="IEhX6w7J"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DA2165FBF for ; Fri, 3 Jul 2026 14:26:14 +0200 (CEST) Received: from neptunite.hamster-moth.ts.net (unknown [IPv6:2404:7a81:160:2100:a2cc:2f45:3bd7:2589]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F3A81121; Fri, 3 Jul 2026 14:25:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1783081528; bh=3jYltKqKcr57DNBqTq9A69GfhmEMX5qb+oyxYAgvAvk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IEhX6w7JvqQTP5JrUucyxGH7yo6ZjeNn68L7xubVGsxKzK5u8qaawvGJBT7/UmFaO o7wUCXdDDsU/y9eyRKblaIKt6LcmtfLVMAm0ZpOjAYH281Jons+Ja4HIOS/DjvJXjB Gih885aWUJTGCRTkSR/GLTDNGoFD1Kk2w5PxIcMs= From: Paul Elder To: laurent.pinchart@ideasonboard.com Cc: Paul Elder , michael.riesch@collabora.com, xuhf@rock-chips.com, stefan.klug@ideasonboard.com, kieran.bingham@ideasonboard.com, dan.scally@ideasonboard.com, jacopo.mondi@ideasonboard.com, nicolas.dufresne@collabora.com, libcamera-devel@lists.libcamera.org Subject: [RFC PATCH 04/19] include: ipa: rkisp2: Add rkisp2 ipa interface Date: Fri, 3 Jul 2026 21:25:10 +0900 Message-ID: <20260703122543.1991189-5-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20260703122543.1991189-1-paul.elder@ideasonboard.com> References: <20260703122543.1991189-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add the IPA interface for the rkisp2. It is based on and is nearly identical to the rkisp1 IPA interface. Signed-off-by: Paul Elder --- This is also split into a separate patch to make the other patches smaller and easier to review. --- include/libcamera/ipa/meson.build | 1 + include/libcamera/ipa/rkisp2.mojom | 47 ++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+) create mode 100644 include/libcamera/ipa/rkisp2.mojom diff --git a/include/libcamera/ipa/meson.build b/include/libcamera/ipa/meson.build index 3ee3ada303c0..22c603165fa2 100644 --- a/include/libcamera/ipa/meson.build +++ b/include/libcamera/ipa/meson.build @@ -66,6 +66,7 @@ pipeline_ipa_mojom_mapping = { 'ipu3': 'ipu3.mojom', 'mali-c55': 'mali-c55.mojom', 'rkisp1': 'rkisp1.mojom', + 'rkisp2': 'rkisp2.mojom', 'rpi/pisp': 'raspberrypi.mojom', 'rpi/vc4': 'raspberrypi.mojom', 'simple': 'soft.mojom', diff --git a/include/libcamera/ipa/rkisp2.mojom b/include/libcamera/ipa/rkisp2.mojom new file mode 100644 index 000000000000..52284a29cd24 --- /dev/null +++ b/include/libcamera/ipa/rkisp2.mojom @@ -0,0 +1,47 @@ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ + +/* + * \todo Document the interface and remove the related EXCLUDE_PATTERNS entry. + */ + +module ipa.rkisp2; + +import "include/libcamera/ipa/core.mojom"; + +/* + * colorSpaceEncoding comes from libcamera::ColorSpace::YcbcrEncoding; -1 for invalid + * colorSpaceRange comes from libcamera::ColorSpace::Range; -1 for invalid + */ +struct IPAConfigInfo { + libcamera.IPACameraSensorInfo sensorInfo; + libcamera.ControlInfoMap sensorControls; + int32 colorSpaceEncoding; + int32 colorSpaceRange; +}; + +interface IPARkISP2Interface { + init(libcamera.IPASettings settings, + libcamera.IPACameraSensorInfo sensorInfo, + libcamera.ControlInfoMap sensorControls) + => (int32 ret, libcamera.ControlInfoMap ipaControls); + start() => (int32 ret); + stop(); + + configure(IPAConfigInfo configInfo) + => (int32 ret, libcamera.ControlInfoMap ipaControls); + + mapBuffers(array buffers); + unmapBuffers(array ids); + + [async] queueRequest(uint32 frame, libcamera.ControlList reqControls); + [async] computeParams(uint32 frame, uint32 bufferId); + [async] processStats(uint32 frame, uint32 bufferId, + libcamera.ControlList sensorControls); +}; + +interface IPARkISP2EventInterface { + paramsComputed(uint32 frame, uint32 bufferId, uint32 bytesused); + setSensorControls(uint32 frame, libcamera.ControlList sensorControls); + metadataReady(libcamera.ControlList metadata); +}; +