From patchwork Mon Jun 29 16:30:03 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 27120 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 943C7C3261 for ; Mon, 29 Jun 2026 16:31:33 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4049165FBC; Mon, 29 Jun 2026 18:31:33 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="kKR63sam"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BA3A65F64 for ; Mon, 29 Jun 2026 18:30:30 +0200 (CEST) Received: from pb-laptop.local (185.221.140.128.nat.pool.zt.hu [185.221.140.128]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E98A41044 for ; Mon, 29 Jun 2026 18:29:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782750587; bh=rNdZNN7v1xAahbXGvApcE11d2/muHTpm2AxB3CgCdis=; h=From:To:Subject:Date:In-Reply-To:References:From; b=kKR63samUeUtpGv1xhaZil0lnT4Aql6bzUC/mh+8wqXUOyEnO5MQUfMYV+1kI8QpO haZN3+TTqTtqDxl6iPO3hR4Ky9LLq2Nv6bbo7w39WEEx0UjVAuB3UzTF13nyrTK+53 EN6Fn6IhDRLrJKI2bIqVWzShWLYe5g1egV6FrIHo= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 40/54] apps: cam: Use camera buffer pool Date: Mon, 29 Jun 2026 18:30:03 +0200 Message-ID: <20260629163017.863145-41-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> References: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Convert the `cam` application to use the new buffer pool interface of cameras. Signed-off-by: Barnabás Pőcze --- src/apps/cam/camera_session.cpp | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp index f90800caf8..fc91bb312a 100644 --- a/src/apps/cam/camera_session.cpp +++ b/src/apps/cam/camera_session.cpp @@ -388,12 +388,7 @@ int CameraSession::startCapture() allocator_->buffers(stream); const std::unique_ptr &buffer = buffers[i]; - ret = request->addBuffer(stream, buffer.get()); - if (ret < 0) { - std::cerr << "Can't set buffer for request" - << std::endl; - return ret; - } + request->enableStream(stream, true); if (sink_) sink_->mapBuffer(buffer.get()); @@ -418,6 +413,15 @@ int CameraSession::startCapture() return ret; } + for (const StreamConfiguration &cfg : *config_) { + Stream *stream = cfg.stream(); + const std::vector> &buffers = + allocator_->buffers(stream); + + for (const auto &buffer : buffers) + camera_->addBuffer(stream, buffer.get()); + } + for (std::unique_ptr &request : requests_) { ret = queueRequest(request.get()); if (ret < 0) { @@ -548,6 +552,13 @@ void CameraSession::processRequest(Request *request) void CameraSession::requeueRequest(Request *request) { - request->reuse(Request::ReuseBuffers); + for (const auto &[stream, buffer] : request->buffers()) + camera_->addBuffer(stream, buffer); + + request->reuse(); + + for (const auto &cfg : *config_) + request->enableStream(cfg.stream(), true); + queueRequest(request); }