From patchwork Mon Jun 29 16:30:02 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 27118 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5693FC3261 for ; Mon, 29 Jun 2026 16:31:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EFB7665FD0; Mon, 29 Jun 2026 18:31:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="sNjD2Iwp"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E0D9265F38 for ; Mon, 29 Jun 2026 18:30:29 +0200 (CEST) Received: from pb-laptop.local (185.221.140.128.nat.pool.zt.hu [185.221.140.128]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C94EE91 for ; Mon, 29 Jun 2026 18:29:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782750586; bh=odxPTq4XczUbF5oAC9jgieq8AP5Bba8TWoPc3FRjISk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=sNjD2IwpfMnHpFm/9ETgLyuuxqCMhkzL2v9VWyTGA3sH3l+T9jdUpi8zZWzFE2ERu nmyPSnBcUK5fJq75NjQF9igbEUqfqjCzKxa4k6hqxegqHaFDcyBjk6b8w5LGQVd+ws vyknoiaNqGj9ohCKmgCPr4XTLke7rOLJ7+nW2Dxs= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 39/54] libcamera: camera: queueBuffer(): Reject if it has buffers Date: Mon, 29 Jun 2026 18:30:02 +0200 Message-ID: <20260629163017.863145-40-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> References: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" If a request has buffers, it means it was not `reuse()`d properly, so reject those requests. Signed-off-by: Barnabás Pőcze --- src/libcamera/camera.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp index a9e6708fbf..a1f90a35c0 100644 --- a/src/libcamera/camera.cpp +++ b/src/libcamera/camera.cpp @@ -1459,6 +1459,11 @@ int Camera::queueRequest(Request *request) LOG(Camera, Error) << "Invalid request"; return -EINVAL; } + + if (buffer) { + LOG(Camera, Error) << "Request contains buffers"; + return -EINVAL; + } } /* Pre-process AeEnable. */