From patchwork Mon Jun 29 16:29:57 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 27112 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 03C7BC3303 for ; Mon, 29 Jun 2026 16:31:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 86A9365F7C; Mon, 29 Jun 2026 18:31:23 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ZJ0WJZLu"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 89B8065F42 for ; Mon, 29 Jun 2026 18:30:28 +0200 (CEST) Received: from pb-laptop.local (185.221.140.128.nat.pool.zt.hu [185.221.140.128]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 622998D4 for ; Mon, 29 Jun 2026 18:29:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782750585; bh=+vK2SpvNzAluJ1zJKqGtjiQTF+2eigRZ0Q+xrML6KJE=; h=From:To:Subject:Date:In-Reply-To:References:From; b=ZJ0WJZLuGazRqfwuKFNVURvqwCqAOCpFWo68DLBqiC3NtuNQRS8SFD2z+kmWwrlOA Y2DAnvWZ+v4oG2iCYmM+YxziGbTf9LDAKHrrQkSoE1Up7Kv+VYanpNmdqgiosDvBfI zUA/XA7HogghxX69TcJ+RroQKNhTrkqnz+1i7/Us= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 34/54] libcamera: pipeline_handler: completeRequest(): Return request count Date: Mon, 29 Jun 2026 18:29:57 +0200 Message-ID: <20260629163017.863145-35-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> References: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Return the number of requests that were consumed from the head of the `queuedRequests_` queue. This can be used by pipeline handlers using the `queuedRequests_` queue for their bookeeing. Reviewed-by: Barnabás Pőcze --- include/libcamera/internal/pipeline_handler.h | 2 +- src/libcamera/pipeline_handler.cpp | 9 ++++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h index d5b8fdb730..5aced40cea 100644 --- a/include/libcamera/internal/pipeline_handler.h +++ b/include/libcamera/internal/pipeline_handler.h @@ -70,7 +70,7 @@ public: return request->_d()->completeBuffer(buffer); } - void completeRequest(Request *request); + size_t completeRequest(Request *request); void cancelRequest(Request *request); void addBuffer(Camera *camera, diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index ad1174d043..755c78b308 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -636,14 +636,18 @@ void PipelineHandler::doQueueRequests(Camera *camera) * without any ordering constraint. * * \context This function shall be called from the CameraManager thread. + * + * \return The number of requests that were removed from the head of the queued + * requests queue. */ -void PipelineHandler::completeRequest(Request *request) +size_t PipelineHandler::completeRequest(Request *request) { Camera *camera = request->_d()->camera(); request->_d()->complete(); Camera::Private *data = camera->_d(); + size_t consumed = 0; while (!data->queuedRequests_.empty()) { Request *req = data->queuedRequests_.front(); @@ -653,10 +657,13 @@ void PipelineHandler::completeRequest(Request *request) ASSERT(!req->hasPendingBuffers()); data->queuedRequests_.pop_front(); camera->requestComplete(req); + consumed += 1; } /* Allow any waiting requests to be queued to the pipeline. */ doQueueRequests(camera); + + return consumed; } /**