From patchwork Mon Jan 20 12:55:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 2709 X-Patchwork-Delegate: kieran.bingham@ideasonboard.com Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BFD6360804 for ; Mon, 20 Jan 2020 13:55:48 +0100 (CET) Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 57D0910D6; Mon, 20 Jan 2020 13:55:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1579524948; bh=zurCK2/8QqqZHV2dg76g26XT0x/0Pfn52tplk5NyCnc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZIsm69nzM8tiQ3OW5tNXFgUBZs/g2ugIX/F4g0VCmMG0vLX66Ti1yVCrRfEWcAUQ6 kvZ0tpY/PopMm4kjok4jxqkKWUSu8+xUIrcYKRI0LexyjsE+n8Qd7CUp/a3O9vRw3D ezX6Mfia76FsXXiLqS/SuLQMoHwARaWs7264C8TY= From: Kieran Bingham To: LibCamera Devel Date: Mon, 20 Jan 2020 12:55:42 +0000 Message-Id: <20200120125544.12562-2-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200120125544.12562-1-kieran.bingham@ideasonboard.com> References: <20200120125544.12562-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/3] pipeline_handler: Include system header for dev_t X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jan 2020 12:55:49 -0000 Compiling with gcc 9.2.0-r5 identifies the following compile time failure: FAILED: src/libcamera/4ab8042@@camera@sha/camera.cpp.o c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++14 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o' -c ../src/libcamera/camera.cpp In file included from ../src/libcamera/camera.cpp:17: ../src/libcamera/include/pipeline_handler.h:91:42: error: 'dev_t' has not been declared 91 | std::unique_ptr data, dev_t devnum = 0); | ^~~~~ Provide the required header to define the dev_t type. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/libcamera/include/pipeline_handler.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h index a6c1e1fbae38..5fa0db51c625 100644 --- a/src/libcamera/include/pipeline_handler.h +++ b/src/libcamera/include/pipeline_handler.h @@ -13,6 +13,7 @@ #include #include #include +#include #include #include