From patchwork Mon Jun 29 16:29:31 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 27087 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 51B08C3261 for ; Mon, 29 Jun 2026 16:30:50 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3C7FD65F39; Mon, 29 Jun 2026 18:30:36 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="TFtEW4wi"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C8EB65F2E for ; Mon, 29 Jun 2026 18:30:22 +0200 (CEST) Received: from pb-laptop.local (185.221.140.128.nat.pool.zt.hu [185.221.140.128]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 655381044; Mon, 29 Jun 2026 18:29:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782750579; bh=rqqzN5Jhikx2SOBPz/annoESvH/M7mkdiSpqXo8Z40Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TFtEW4wirhpCl4h6ENsOOEEU5+93oYX5Ys7TaORqrRiiygYRF6e9Frq5jeWXVt/0S oGcO3ziSU87obPuF4lTvMpDNjWX23Ufr2lLmJQ/kvgfVqYyVJavfUctvLj12wCO96S Kr7psxTH+RBEjtIHLfG7D6kDbF4d8HZ1botcyJzI= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , Laurent Pinchart , Paul Elder Subject: [RFC PATCH v1 08/54] v4l2: v4l2_camera: Avoid a level of indirection Date: Mon, 29 Jun 2026 18:29:31 +0200 Message-ID: <20260629163017.863145-9-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> References: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Convert the `completedBuffers_` container to store the items directly and not via an `std::unique_ptr`. Signed-off-by: Barnabás Pőcze Acked-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Reviewed-by: Paul Elder --- src/v4l2/v4l2_camera.cpp | 11 ++++------- src/v4l2/v4l2_camera.h | 2 +- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp index 412ab4ea67..648578c22b 100644 --- a/src/v4l2/v4l2_camera.cpp +++ b/src/v4l2/v4l2_camera.cpp @@ -70,11 +70,10 @@ void V4L2Camera::unbind() std::vector V4L2Camera::completedBuffers() { - std::vector v; - MutexLocker lock(bufferLock_); - for (std::unique_ptr &metadata : completedBuffers_) - v.push_back(*metadata.get()); + std::vector v(std::move_iterator(completedBuffers_.begin()), + std::move_iterator(completedBuffers_.end())); + completedBuffers_.clear(); return v; @@ -88,9 +87,7 @@ void V4L2Camera::requestComplete(Request *request) /* We only have one stream at the moment. */ bufferLock_.lock(); FrameBuffer *buffer = request->buffers().begin()->second; - std::unique_ptr metadata = - std::make_unique(request->cookie(), buffer->metadata()); - completedBuffers_.push_back(std::move(metadata)); + completedBuffers_.emplace_back(request->cookie(), buffer->metadata()); bufferLock_.unlock(); uint64_t data = 1; diff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h index 3d09ae7d60..1528f9aad8 100644 --- a/src/v4l2/v4l2_camera.h +++ b/src/v4l2/v4l2_camera.h @@ -85,7 +85,7 @@ private: std::vector> requestPool_; std::deque pendingRequests_; - std::deque> completedBuffers_ + std::deque completedBuffers_ LIBCAMERA_TSA_GUARDED_BY(bufferLock_); int efd_;