From patchwork Thu Jun 18 12:38:26 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 26973 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9538FC3304 for ; Thu, 18 Jun 2026 12:39:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 45B5262C6E; Thu, 18 Jun 2026 14:39:06 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="B/Khb1/g"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 33BDB62C71 for ; Thu, 18 Jun 2026 14:38:50 +0200 (CEST) Received: from pb-laptop.local (185.182.214.63.nat.pool.zt.hu [185.182.214.63]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F3842F8 for ; Thu, 18 Jun 2026 14:38:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1781786295; bh=VQWdVx/eE22959ha/DrBlHrz40UMBHdLJiA9tE+UnuQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=B/Khb1/gmt10W6X949kyEFk6XWa/E+f8b6O1elrw2aQtFT7CJfRqswrz47qpVt7jM EV7n71tIY5Dxo8m0cgQBKFXCTw3OCAlGvGvnBdEhhhYgC2i/+gLnUzp6sE+AEhi2nY 40Ar5cZH7nw+c+gHFpjfIZHU3JB+KrcCb0ttCO7k= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 09/27] libcamera: pipeline: ipu3: Remove `setRequest()` calls Date: Thu, 18 Jun 2026 14:38:26 +0200 Message-ID: <20260618123844.656396-10-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260618123844.656396-1-barnabas.pocze@ideasonboard.com> References: <20260618123844.656396-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" No component queries the associated request of any buffer, so setting it is unnecessary. Signed-off-by: Barnabás Pőcze --- src/libcamera/pipeline/ipu3/cio2.cpp | 3 +-- src/libcamera/pipeline/ipu3/cio2.h | 3 +-- src/libcamera/pipeline/ipu3/frames.cpp | 3 --- src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- 4 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp index b6fe84fe70..7481b2686d 100644 --- a/src/libcamera/pipeline/ipu3/cio2.cpp +++ b/src/libcamera/pipeline/ipu3/cio2.cpp @@ -378,7 +378,7 @@ int CIO2Device::stop() return ret; } -FrameBuffer *CIO2Device::queueBuffer(Request *request, FrameBuffer *rawBuffer) +FrameBuffer *CIO2Device::queueBuffer(FrameBuffer *rawBuffer) { FrameBuffer *buffer = rawBuffer; @@ -391,7 +391,6 @@ FrameBuffer *CIO2Device::queueBuffer(Request *request, FrameBuffer *rawBuffer) buffer = availableBuffers_.front(); availableBuffers_.pop(); - buffer->_d()->setRequest(request); } int ret = output_->queueBuffer(buffer); diff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h index d844cb7ae8..91651a1640 100644 --- a/src/libcamera/pipeline/ipu3/cio2.h +++ b/src/libcamera/pipeline/ipu3/cio2.h @@ -22,7 +22,6 @@ class CameraSensor; class FrameBuffer; class MediaDevice; class PixelFormat; -class Request; class Size; class SizeRange; struct StreamConfiguration; @@ -56,7 +55,7 @@ public: CameraSensor *sensor() { return sensor_.get(); } const CameraSensor *sensor() const { return sensor_.get(); } - FrameBuffer *queueBuffer(Request *request, FrameBuffer *rawBuffer); + FrameBuffer *queueBuffer(FrameBuffer *rawBuffer); void tryReturnBuffer(FrameBuffer *buffer); Signal &bufferReady() { return output_->bufferReady; } Signal &frameStart() { return csi2_->frameStart; } diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp index 4232e976a9..67ec922e49 100644 --- a/src/libcamera/pipeline/ipu3/frames.cpp +++ b/src/libcamera/pipeline/ipu3/frames.cpp @@ -58,9 +58,6 @@ IPU3Frames::Info *IPU3Frames::create(Request *request) FrameBuffer *paramBuffer = availableParamBuffers_.front(); FrameBuffer *statBuffer = availableStatBuffers_.front(); - paramBuffer->_d()->setRequest(request); - statBuffer->_d()->setRequest(request); - availableParamBuffers_.pop(); availableStatBuffers_.pop(); diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index 560fccd8c0..af1b79d708 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -810,7 +810,7 @@ void IPU3CameraData::queuePendingRequests() * otherwise. */ FrameBuffer *reqRawBuffer = request->findBuffer(&rawStream_); - FrameBuffer *rawBuffer = cio2_.queueBuffer(request, reqRawBuffer); + FrameBuffer *rawBuffer = cio2_.queueBuffer(reqRawBuffer); /* * \todo If queueBuffer fails in queuing a buffer to the device, * report the request as error by cancelling the request and