From patchwork Thu Jun 18 12:38:19 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 26966 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4CF25BF415 for ; Thu, 18 Jun 2026 12:39:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7B2DA656E4; Thu, 18 Jun 2026 14:38:54 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="NvczzRdC"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DE265629E0 for ; Thu, 18 Jun 2026 14:38:48 +0200 (CEST) Received: from pb-laptop.local (185.182.214.63.nat.pool.zt.hu [185.182.214.63]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E7F841894 for ; Thu, 18 Jun 2026 14:38:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1781786294; bh=G9E3MiS16ADVtBPpBAXgn6HC2Ogh1myfLFKuYuDtyxE=; h=From:To:Subject:Date:In-Reply-To:References:From; b=NvczzRdCp4EZZyE6jAvcTythzZSV7wbcJ+FeNCtYSCH6jdx7zX7+DwUb9cZyze/uO PxKzSsH7mvl55ViCtj+Cl2DZIwLaKMSoFJi9LXqe8MsUxGqtX5trrpfMkzI8Xmlxox fug5CIqsAPaCMXaN1pXuiWpkagLHvHG5C1qmS2+4= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 02/27] libcamera: request: Inline `Private::hasPendingRequests()` Date: Thu, 18 Jun 2026 14:38:19 +0200 Message-ID: <20260618123844.656396-3-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260618123844.656396-1-barnabas.pocze@ideasonboard.com> References: <20260618123844.656396-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" It is a trivial function, inline it. Signed-off-by: Barnabás Pőcze --- include/libcamera/internal/request.h | 2 +- src/libcamera/request.cpp | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h index 693097ee9a..382ed28bca 100644 --- a/include/libcamera/internal/request.h +++ b/include/libcamera/internal/request.h @@ -34,7 +34,7 @@ public: ~Private(); Camera *camera() const { return camera_; } - bool hasPendingBuffers() const; + bool hasPendingBuffers() const { return !pending_.empty(); } ControlList &metadata() { return metadata_; } diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp index b50a642052..e31c9c006a 100644 --- a/src/libcamera/request.cpp +++ b/src/libcamera/request.cpp @@ -74,15 +74,12 @@ Request::Private::~Private() */ /** + * \fn Request::Private::hasPendingBuffers() * \brief Check if a request has buffers yet to be completed * * \return True if the request has buffers pending for completion, false * otherwise */ -bool Request::Private::hasPendingBuffers() const -{ - return !pending_.empty(); -} /** * \fn Request::Private::metadata()