From patchwork Thu Jun 18 12:22:30 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 26950 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CF5BFC3310 for ; Thu, 18 Jun 2026 12:23:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5FCF262E9D; Thu, 18 Jun 2026 14:23:29 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="afzoI4Ez"; dkim-atps=neutral Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 56D0362C6D for ; Thu, 18 Jun 2026 14:23:11 +0200 (CEST) Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-45ef189aa1cso661000f8f.0 for ; Thu, 18 Jun 2026 05:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781785391; x=1782390191; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CfDeIMUwfSa5hEgn9yj8YVav8Kysxh3e9PDp4yN9qns=; b=afzoI4EzNHBdsDG24+FQzAKDI+ws0gUawVLkK/Yjz0kMgqg1SrEiGNwuGudUavr2eT wCqjAsB7vDJhvlFh5JYE/HNuKfhhTlMUx0AmX9xMD1i53MLEUY97udDHATejl9EMB/ov jFwNwW2E/tPO0XKAvlLZL5hzP9chy3/L6l266O3/j4oxJIjKozRi20FnbQmhb5tZSy6a rIQYP9mCvK598+pb8hvy84FBgpNXEhLg/Z+dz12WqMlTR7kPOExym8aMy7v5EB9vvN1l AIahiGnwV66MvZQHgFw7aB/P5Mzvb8O/IDHY/binGcC24OzcJ291FTJqQBZeRiC01q8y xFhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781785391; x=1782390191; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CfDeIMUwfSa5hEgn9yj8YVav8Kysxh3e9PDp4yN9qns=; b=IWOeKVj929Qw3qCohbG29qGFB/sajZpQW1zvPmb8bIZNOGm8/AG1HNftyhZbMRr7k1 5w1dzTIN5G+dI4AjXEo/CiJZWaPzo9gq1uJ540R3u9j8lEZkWp0Rpalb8JdkAH/Ol9fk Vj8h4sHLBycwHuyR8iwqLLs3CvBALQEkKM6vpag5QccAVURzQmGKUNBTP4mWGtoAUQyd SyvT5cRrVDET9qHag1cWeLLz48xWQz2WyaBccb4E5qhu24pY0uz72T1ZkvCPaxNqs3/4 WO6+VLukR9zcd4y/4isqgwXQv2RBHpTZEMifh3y0ev/sOujlf4AWJQtSG8cX744vF2yh 06Fw== X-Gm-Message-State: AOJu0Yy9o9ayTdPJumGuX+CvVQFMj5gsu4VkmmYY23XitXb+Wju/9ICP UwS3WkkGL2Ix8yMHXwoYnoWAJXNSxzWU6s+Q3GgZKcE2KC+x+PKX+twToeiKjhRvWKKtM+DyitG zW8uJAL8= X-Gm-Gg: AfdE7cnE2GPRDbc1oOWoL2v1lx1SBtNXN+0iUf4tfDEn1KUq9vIjydCHoq+R4dcadL3 SqBEFJgUBvzlX2m7ikqDEVgmbYQR/bCRBAUb/WAEEoFodl0Z9ywe4j1ZQmaf5x1N+N1tldYIJLp MdnCJ0uO6XKhsXyOpmFM6ha2zlQaK6FydoNh3tMjAI3xFExxjZxcYKvqhwc65jeD0/g5YiZMLeg dfh+4ze+wLS2ncGVdqd/mXVZQiEsLVz5bScDpwWIJZZOM0CdUKQ8TL10OC72lTaV55mEw3C83s2 MyZhtAKdk6JewgwH3ru43aGi+jSoq3r5KX4EOQqwJRyeLT1GYRJHNoYWKY3FfI3xTw8/2t2iuBZ VfS0uNvi8nin+97+LI5tWqnIuaddH4ZZcUUsLBQbbGuWvaIcklhRaZAwrUj/6DurXF0kg/nK5Og 9UfRICFnL0jk/HLWSuJpa7SZeRfYJN X-Received: by 2002:a05:600c:4ed4:b0:490:da12:f1fa with SMTP id 5b1f17b1804b1-492333ecc2bmr143344365e9.31.1781785390776; Thu, 18 Jun 2026 05:23:10 -0700 (PDT) Received: from inspiron14p-linux ([109.76.144.236]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4922fa3a4easm275198015e9.3.2026.06.18.05.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2026 05:23:10 -0700 (PDT) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: bryan.odonoghue@linaro.org, pavel@ucw.cz Subject: [PATCH 17/30] libcamera: software_isp: egl: Rename createTexture2D to createInputTexture2D Date: Thu, 18 Jun 2026 13:22:30 +0100 Message-ID: <20260618122245.946138-18-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260618122245.946138-1-bryan.odonoghue@linaro.org> References: <20260618122245.946138-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Right now this routine makes a texture from a supplied data-buffer. It should have a more descriptive and accurate name. Signed-off-by: Bryan O'Donoghue --- include/libcamera/internal/egl.h | 2 +- src/libcamera/egl.cpp | 2 +- src/libcamera/software_isp/software_isp_pipeline_gpu.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h index 3956c6669..182a4dc55 100644 --- a/include/libcamera/internal/egl.h +++ b/include/libcamera/internal/egl.h @@ -106,7 +106,7 @@ public: int createInputDMABufTexture2D(eGLImage &eglImage, int fd); int createOutputDMABufTexture2D(eGLImage &eglImage, int fd); - void createTexture2D(eGLImage &eglImage, void *data); + void createInputTexture2D(eGLImage &eglImage, void *data); int attachTextureToFBO(eGLImage &eglImage); diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp index a5e59c09c..ffaa6bc49 100644 --- a/src/libcamera/egl.cpp +++ b/src/libcamera/egl.cpp @@ -262,7 +262,7 @@ int eGL::createOutputDMABufTexture2D(eGLImage &eglImage, int fd) * is useful for uploading static data like lookup tables or uniform color * matrices to the GPU. */ -void eGL::createTexture2D(eGLImage &eglImage, void *data) +void eGL::createInputTexture2D(eGLImage &eglImage, void *data) { GLenum format; GLenum type = GL_UNSIGNED_BYTE; diff --git a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp index 7de77319d..8bafd70f8 100644 --- a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp +++ b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp @@ -247,7 +247,7 @@ int SoftwareIspPipelineGpu::processGPU(FrameBuffer *input, FrameBuffer *output, LOG(Debayer, Error) << "mmap-ing buffer(s) failed"; return -ENODEV; } - egl_.createTexture2D(*eglImageBayerIn_, inMapped->value().planes()[0].data()); + egl_.createInputTexture2D(*eglImageBayerIn_, inMapped->value().planes()[0].data()); } /* Generate the output render framebuffer as render to texture */