From patchwork Thu Jun 18 12:22:15 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 26934 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AE650C328C for ; Thu, 18 Jun 2026 12:23:03 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 35A5C629DE; Thu, 18 Jun 2026 14:23:01 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="dAs88bqi"; dkim-atps=neutral Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1254D629B6 for ; Thu, 18 Jun 2026 14:22:59 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-490aebf33e9so3915585e9.3 for ; Thu, 18 Jun 2026 05:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781785379; x=1782390179; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FqNWrQwNLFM731dd+9mymOcD0H2BPBsCagCZYSKCaps=; b=dAs88bqiter0TL8WEk0fbXtK3mDNz+WvOqdMGrs/R4O4Sl25wUr3cOWzv9A2HxAcrE 7mvF3HB5LyM4Ti89NlHbriPVj+veezETpRf+T8/658ExDt2bFlheVpFay2hWvWtSzB4s XPZQ+Q9spUwiTgkRmkH7OkQknxDPJKJ6KmageBwBWq7OGFGOSx0LyPvJDOXquwvhggbU hE1Y+8lD/3ViDguCTWGafPtRNgf/JCHTqK15TVM9SI0n57V+62kLFZsvMpsEBgmhxlTx +1wNcwfH+lDycjAEum5zmP934VgojZXe6yya3hmtCfE5KNbhQJCBzcLOkkV94OT5uUDZ +KSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781785379; x=1782390179; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FqNWrQwNLFM731dd+9mymOcD0H2BPBsCagCZYSKCaps=; b=CElM4zLVOlKifJjbXL+EOy8OCmBw10YBAM5u21UJceSDux0FEDI4+nPhSTKtv3ne5y qac/GwI3UOIDan8xeI2ra5zebTAD8PbyeHDDQyz1P55RnTpxF37iKGMaS9mEEqIqBnaJ ScsuJFX+yS+U9OJz+OIUgBeHjnA1/eWFgjZJLREL7c1ICfaat5G7xmGIdiS9aWGgyws6 NrygrbDlq94OlkAgnLHoEYIG3GYyrTOU6QTUVtiSkvrLgyP7lNhJ+GpTGUvGBW0S7eDD sIXpHYFC5zjyI54gaIvXww5reoqQgp2CzsaqUBQPgJ0T/o7radI/k+iih+nRiivf+Lxq t3zg== X-Gm-Message-State: AOJu0YzUnQ9zH3/V20hRNNzMKjYSSqjDwiu6bXBML4mV5q+mal9DaVBN 98m4DAXb9LuBE7eEAsB9NIW4VtzQoOmukO/16MUE7yYnwb2AxSH8xxiDt/If3AMsvY/lGezrCHS tQI2ZZH4= X-Gm-Gg: AfdE7cnchjGOORSmf2wpWZJG5QCkfWBEqQZqhT+gv83faDNCSdIawoi4lgzDg5INinX JVJ+FjbD/QgTtCaH8KksUowQXhNPPv8IjFW+UNU5vDrAXXu9uARyVvjMkZwh63C9npszqZMAwir h7VDzY6wQlNc9jCzUjvrN3zuFGHsjY0PhxN0V3Q9aB2ywM3RyJPaoP1+gJb1nwVxO4Wk4SlxlOv qUueSyuEbjorSnYbq+z9NXPE11SfE4Lb3LWH1N7Oek80lyvFjdVitmtmY+FO2ucZ4OEZv/fjEQn hsWIwSWPpgMPBI4Gp6kmXmyadsxl8OHq4Zx+wpVENZXsDGvXIxNkmDo93/65PTBRNwWDVP/XwnI 0BXhQNkM2JPWeZuPKOMs6v5IESEpiduuNAB4p9sbqrobZFc77NtUtxpcraHqyVvMCLwSPtLMJR+ 2D2vPMju6VKWv/DKuEcuUTp9IdeQD7 X-Received: by 2002:a05:600c:1c25:b0:488:ac01:72de with SMTP id 5b1f17b1804b1-492333e8f29mr129461395e9.5.1781785378539; Thu, 18 Jun 2026 05:22:58 -0700 (PDT) Received: from inspiron14p-linux ([109.76.144.236]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4922fa3a4easm275198015e9.3.2026.06.18.05.22.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2026 05:22:58 -0700 (PDT) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: bryan.odonoghue@linaro.org, pavel@ucw.cz Subject: [PATCH 02/30] libcamera: software_isp: gpu: Change the name of eglImageBayerOut_ to eglImageRGBAOut_ Date: Thu, 18 Jun 2026 13:22:15 +0100 Message-ID: <20260618122245.946138-3-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260618122245.946138-1-bryan.odonoghue@linaro.org> References: <20260618122245.946138-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In our mutli-pass shader design we will use textures to pass the output of one compute or fragment shader to the next. Each phase will have its own distinct name and output. A better more accurate name for the thing which we render into is eglImageRGBAOut_ which has a very obvious meaning - its our RGBA output. We aren't outputting Bayer data here, we are outputting RGBA data so denote it as such by way of its name. Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/software_isp_pipeline_gpu.cpp | 6 +++--- src/libcamera/software_isp/software_isp_pipeline_gpu.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp index 53bb5e61f..c68a04fff 100644 --- a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp +++ b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp @@ -538,7 +538,7 @@ int SoftwareIspPipelineGpu::debayerGPU(FrameBuffer *input, FrameBuffer *output, } /* Generate the output render framebuffer as render to texture */ - egl_.createOutputDMABufTexture2D(*eglImageBayerOut_, output->planes()[0].fd.get()); + egl_.createOutputDMABufTexture2D(*eglImageRGBAOut_, output->planes()[0].fd.get()); setShaderVariableValues(params); glViewport(0, 0, width_, height_); @@ -626,14 +626,14 @@ int SoftwareIspPipelineGpu::start() eglImageBayerIn_ = std::make_unique(glFormat_, inputConfig_.stride / bytesPerPixel_, height_, inputConfig_.stride, GL_TEXTURE0, 0); /* Texture we will render to */ - eglImageBayerOut_ = std::make_unique(GL_RGBA, outputSize_.width, outputSize_.height, outputConfig_.stride, GL_TEXTURE1, 1); + eglImageRGBAOut_ = std::make_unique(GL_RGBA, outputSize_.width, outputSize_.height, outputConfig_.stride, GL_TEXTURE1, 1); return 0; } void SoftwareIspPipelineGpu::stop() { - eglImageBayerOut_.reset(); + eglImageRGBAOut_.reset(); eglImageBayerIn_.reset(); if (programId_) diff --git a/src/libcamera/software_isp/software_isp_pipeline_gpu.h b/src/libcamera/software_isp/software_isp_pipeline_gpu.h index eb365d198..6f161e063 100644 --- a/src/libcamera/software_isp/software_isp_pipeline_gpu.h +++ b/src/libcamera/software_isp/software_isp_pipeline_gpu.h @@ -74,7 +74,7 @@ private: /* Pointer to object representing input texture */ std::unique_ptr eglImageBayerIn_; - std::unique_ptr eglImageBayerOut_; + std::unique_ptr eglImageRGBAOut_; /* Shader parameters */ float firstRed_x_;