From patchwork Thu Jun 18 11:48:39 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jai Luthra X-Patchwork-Id: 26931 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E1BCEBF415 for ; Thu, 18 Jun 2026 11:49:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9360B62989; Thu, 18 Jun 2026 13:49:07 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CJ3a5RW4"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E836B62980 for ; Thu, 18 Jun 2026 13:49:05 +0200 (CEST) Received: from mail.ideasonboard.com (unknown [IPv6:2401:4900:1c68:bcf2:9325:a9bd:32b:e71]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8BD36741; Thu, 18 Jun 2026 13:48:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1781783311; bh=+OJPTxdZZwtGskSbXYiNP7yUrKDXhcJC9vq1u8odxD8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=CJ3a5RW4RGCZh9mbE4yQ9awjDiW7VFHdmUeCu9Q1Noq4D5n/Z9waF5VBkbHW9pv4v lvDCI+MEZt3xyJd4N4rq2Q9rNmvpIpnnu7/r+zDDvo+Hr/z4Op3m0lreJAHSpkvkeT qxWtlzWFdj6SmVSG89LGzKyhh8/EkzEcBEhAWTK8= From: Jai Luthra Date: Thu, 18 Jun 2026 17:18:39 +0530 Subject: [PATCH 1/2] libcamera: libipa: camera_sensor: Add Sony IMX678 properties MIME-Version: 1.0 Message-Id: <20260618-imx678-v1-1-646e09a63692@ideasonboard.com> References: <20260618-imx678-v1-0-646e09a63692@ideasonboard.com> In-Reply-To: <20260618-imx678-v1-0-646e09a63692@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Kieran Bingham , Jai Luthra X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1931; i=jai.luthra@ideasonboard.com; h=from:subject:message-id; bh=+OJPTxdZZwtGskSbXYiNP7yUrKDXhcJC9vq1u8odxD8=; b=owEBbQKS/ZANAwAKAUPekfkkmnFFAcsmYgBqM9sklbXe4vQJ7XNt75owZ9XX8JJuyC/+AhQCj XddJTnqlqCJAjMEAAEKAB0WIQRN4NgY5dV16NRar8VD3pH5JJpxRQUCajPbJAAKCRBD3pH5JJpx RTsrD/9VMDUUOgFSVS/M6ASGj6EKUqkMgWklgQtfCjSV5RUZVFZmRs+2Iu1Qig/+azBMgwV6+FT Ay6IKVcKPn+x/Mu4AI57wHq7pcqk7s6hC9BzgkzqqH7KrJwY+qiA/P7L6V6VdTjwr+7YzVoCI8a vuu193PDVtvSosmXmWgYaJiVPA4gzqmjNHY8heljA0jnQ+uDpMiOTQUFIHhrYjkOmKeLYBryJUr 5s8FEnk3imXsAwUi+AT5itVbkVrv6E98v/rgIFFvNYj81PGj2gi91K62gZ/DQO51OoPn4I/39wH urZjHFtR9IBG3ubfohEJ0eUbwwOLE4FRQAZj/A/89klxYTLox4+J5+V66RkoK0cZ9sY1tF4TJQ3 cYEZR69OcuEFIIDNV//DPip2qSOsnAb0yzAJ48frVTC3obtJX20M5D2bOiu5px6TrUkr5togv91 7R4rohKQ7pbI4hRyrFwuzA4gq1pneDCxTtHwmADzIAks856OgT8lpHTddTLR7lWrSqDDJ8ItyI2 sM3F4MfMNhhN7TB5E3/FcYRWvHPgveXyxtqM1uxUvzUy7Ap3NnQ6QQ5jZOCu8d0GcuTAnHZelEs JCgmwLY9AjNTmc/mTMsk8TxoQRW/dPCjF6SnytvmzkpocExMqNrJnxThXJxSwoUQW/6Q0bzGqN0 q0R2IvYOy+kt7NQ== X-Developer-Key: i=jai.luthra@ideasonboard.com; a=openpgp; fpr=4DE0D818E5D575E8D45AAFC543DE91F9249A7145 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add Sony IMX678 properties, along with the black level and gain model through a libipa camera sensor helper. The test patterns are intentionally left empty, as they are similar to IMX335/IMX283 and don't map very well to libcamera's enum values. Signed-off-by: Jai Luthra Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++ src/libcamera/sensor/camera_sensor_properties.cpp | 10 ++++++++++ 2 files changed, 22 insertions(+) diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 3028197e1..9ab7a52f2 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -642,6 +642,18 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("imx477", CameraSensorHelperImx477) +class CameraSensorHelperImx678 : public CameraSensorHelper +{ +public: + CameraSensorHelperImx678() + { + /* From datasheet: 0x32 at 10bits. */ + blackLevel_ = 3200; + gain_ = AnalogueGainExp{ 1.0, expGainDb(0.3) }; + } +}; +REGISTER_CAMERA_SENSOR_HELPER("imx678", CameraSensorHelperImx678) + class CameraSensorHelperImx708 : public CameraSensorHelper { public: diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp index b217363d8..28043150e 100644 --- a/src/libcamera/sensor/camera_sensor_properties.cpp +++ b/src/libcamera/sensor/camera_sensor_properties.cpp @@ -309,6 +309,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen .hblankDelay = 3 }, } }, + { "imx678", { + .unitCellSize = { 2000, 2000 }, + .testPatternModes = {}, + .sensorDelays = { + .exposureDelay = 2, + .gainDelay = 2, + .vblankDelay = 2, + .hblankDelay = 2 + }, + } }, { "imx708", { .unitCellSize = { 1400, 1400 }, .testPatternModes = {