From patchwork Tue Jun 9 15:50:43 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 26862 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 36942C324C for ; Tue, 9 Jun 2026 15:50:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5845861EF0; Tue, 9 Jun 2026 17:50:47 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="jFND20Cb"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 954DB61E61 for ; Tue, 9 Jun 2026 17:50:45 +0200 (CEST) Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D6A5F244 for ; Tue, 9 Jun 2026 17:50:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1781020217; bh=QV/y2AX7QEIgvRcN2o1t+g+NruyaxjvPuBK+VKtfFXw=; h=From:To:Subject:Date:From; b=jFND20CbaaT73N2Phou8GlCSdBcis2fH1pkjOxp3OFpNkl1rBNJYhbJFPBJ/hI6H8 LbJylp3hpCNc0XF6XphvihZGa2KJyP1w1/eDpy+LxW56ZTG6aL57/LyPULyUUYX7Fv 9u4gAn543qi2PBAzDLUwpex9nRTGTpNFsWJonVT0= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH] libcamera: matrix: Improve comment related to C++20 Date: Tue, 9 Jun 2026 18:50:43 +0300 Message-ID: <20260609155043.1121340-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" It was envisioned that the Matrix::data_ initializer could be dropped once moving to C++20. Unfortunately older compilers don't agree. Update the comment accordingly. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- include/libcamera/internal/matrix.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) base-commit: 5701eb5f47cf3649e2746a2082c7bb3e0a0577e8 diff --git a/include/libcamera/internal/matrix.h b/include/libcamera/internal/matrix.h index 0f72263f2536..4900dcc0a419 100644 --- a/include/libcamera/internal/matrix.h +++ b/include/libcamera/internal/matrix.h @@ -117,9 +117,11 @@ public: private: /* - * \todo The initializer is only necessary for the constructor to be - * constexpr in C++17. Remove the initializer as soon as we are on - * C++20. + * \todo The initializer should be only necessary for the constructor to + * be constexpr in C++17. However, older gcc versions (at least 9 and + * 12, but apparently not 10), as well as clang versions (at least 14 + * and 19), throw compilation errors, even with C++20. Remove the + * initializer once we can drop support of those old compiler versions. */ std::array data_ = {}; };