From patchwork Mon Jun 8 15:03:32 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 26846 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 79C26C328C for ; Mon, 8 Jun 2026 15:04:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 298FF61EEF; Mon, 8 Jun 2026 17:04:12 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="WPTXrhMZ"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4570D61EF3 for ; Mon, 8 Jun 2026 17:04:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780931047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k9NvvxEehqT51Hh8ug4frNDBv4XbQcdkjJmClu3+nfA=; b=WPTXrhMZV3E179iNz/1GeSYlalIg2dq2gbwp/Xpesbtj4PG3SyxBsQi6NyFbfoXwu+hRsC gJhtsRNJ0+1PHTFN4mCpTv6kgAKZd+YngeTCwszZ1X4SmK8U+N6a3hHl7W7G0UrP3EO3kc TKnwZ1csGJqcawUixQhXQQZ+qdKOW0E= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-xge5s6A9NSW2XwNl5lxtKA-1; Mon, 08 Jun 2026 11:04:05 -0400 X-MC-Unique: xge5s6A9NSW2XwNl5lxtKA-1 X-Mimecast-MFC-AGG-ID: xge5s6A9NSW2XwNl5lxtKA_1780931044 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 44E90195609F; Mon, 8 Jun 2026 15:04:04 +0000 (UTC) Received: from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.48.51]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 339801800351; Mon, 8 Jun 2026 15:04:02 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Kieran Bingham , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , johannes.goede@oss.qualcomm.com Subject: [RFC PATCH v4 03/17] libcamera: software_isp: Queue the input buffer per each output Date: Mon, 8 Jun 2026 17:03:32 +0200 Message-ID: <20260608150349.134371-4-mzamazal@redhat.com> In-Reply-To: <20260608150349.134371-1-mzamazal@redhat.com> References: <20260608150349.134371-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lBiNApSFk2MKLxdEWucg6isZd3qNWXt2xbgTubZXYU0_1780931044 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Multiple outputs are not supported, but if they were, the input buffer should be queued for each of them because each output buffer processing emits inputBufferReady. Currently, with a single output, it doesn't change anything. Reviewed-by: Kieran Bingham Signed-off-by: Milan Zamazal --- src/libcamera/software_isp/software_isp.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index f5b44f4e5..f17f1ca1f 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -342,9 +342,8 @@ int SoftwareIsp::queueBuffers(uint32_t frame, FrameBuffer *input, return -EINVAL; } - queuedInputBuffers_.push_back(input); - for (const auto &[stream, buffer] : outputs) { + queuedInputBuffers_.push_back(input); queuedOutputBuffers_.push_back(buffer); process(frame, input, buffer); }