From patchwork Thu Jun 4 09:51:03 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 26841 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7A6E2C328C for ; Thu, 4 Jun 2026 09:52:10 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 32CC963753; Thu, 4 Jun 2026 11:52:10 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="d4lqvweU"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0674B63748 for ; Thu, 4 Jun 2026 11:52:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780566727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PUQ3rffI/BqzXYrzqqZr/7ddTTGPMDReNYc7sL2Z3O0=; b=d4lqvweUN7pmDs22Ko6Tvb+IsVLdIJeOsHuSFvF3VrEbkLHDy4l+64lG4tsW/Iy1e93hsF BxXVSGMBioywU5MRMjUvkpFtmAlFLqCBJEZh57PWVEda0sfvLUjleaFv4aPJnkOUu3/33o Prj/eJ9tfnilLjrKx6xpZbPP1/wBRT8= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-yoXpOossPjSd_HRvjn_Row-1; Thu, 04 Jun 2026 05:52:03 -0400 X-MC-Unique: yoXpOossPjSd_HRvjn_Row-1 X-Mimecast-MFC-AGG-ID: yoXpOossPjSd_HRvjn_Row_1780566722 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7F70E1800473; Thu, 4 Jun 2026 09:52:02 +0000 (UTC) Received: from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.156]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CF04230001A1; Thu, 4 Jun 2026 09:52:00 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , =?utf-8?b?QmFybmFiw6FzIFDFkWN6?= =?utf-8?q?e?= , johannes.goede@oss.qualcomm.com Subject: [RFC PATCH v3 17/17] libcamera: software_isp: Remove stats-sharing TODO item Date: Thu, 4 Jun 2026 11:51:03 +0200 Message-ID: <20260604095105.68798-22-mzamazal@redhat.com> In-Reply-To: <20260604095105.68798-1-mzamazal@redhat.com> References: <20260604095105.68798-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: e657CyJQiX53mlVZ6gZFxcNDHc24xn64rPx4sFnbN6A_1780566722 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Shared per-frame statistics buffers are implemented, we can remove TODO #2. Signed-off-by: Milan Zamazal --- src/libcamera/software_isp/TODO.md | 27 --------------------------- 1 file changed, 27 deletions(-) diff --git a/src/libcamera/software_isp/TODO.md b/src/libcamera/software_isp/TODO.md index f4e5190e0..dcdfd109f 100644 --- a/src/libcamera/software_isp/TODO.md +++ b/src/libcamera/software_isp/TODO.md @@ -10,33 +10,6 @@ The TODO items in this section gather comments from patch review that were not deemed to require being addressed right away. The text in block quotes is copied directly from e-mail review. -### Reconsider stats sharing - -``` ->>> +void SwStatsCpu::finishFrame(void) ->>> +{ ->>> + *sharedStats_ = stats_; ->> ->> Is it more efficient to copy the stats instead of operating directly on ->> the shared memory ? -> -> I inherited doing things this way from Andrey. I kept this because -> we don't really have any synchronization with the IPA reading this. -> -> So the idea is to only touch this when the next set of statistics -> is ready since we don't know when the IPA is done with accessing -> the previous set of statistics ... -> -> This is both something which seems mostly a theoretic problem, -> yet also definitely something which I think we need to fix. -> -> Maybe use a ringbuffer of stats buffers and pass the index into -> the ringbuffer to the emit signal ? - -That would match how we deal with hardware ISPs, and I think that's a -good idea. It will help decoupling the processing side from the IPA. -``` - ### Remove statsReady signal ```