From patchwork Thu Jun 4 09:50:58 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 26837 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9C9F8C328C for ; Thu, 4 Jun 2026 09:51:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 52EE563748; Thu, 4 Jun 2026 11:51:59 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="RSdiRCs2"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 868AE6373C for ; Thu, 4 Jun 2026 11:51:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780566714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rCKk1ldTDS+4T43X5M3WrUPIYIV1fc+fXNa+4lZ0FXI=; b=RSdiRCs2hAwqir0bfeQLsBYWx55R/CFZFE/TlOaUeM+xHwgTjElRkLu5/vlsDkNpabv3wf vbzQJGFKiX5wzHU8hel/BZBiTmRFO3JDoQILZbK35GDlPmvIlWsLYeYGw+KzxobWldhzkV 6Kzolu1WkMQXyTI5ItobOOEzZAncBYs= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-125-1angchQUOcOQ3Ej0UzF71A-1; Thu, 04 Jun 2026 05:51:52 -0400 X-MC-Unique: 1angchQUOcOQ3Ej0UzF71A-1 X-Mimecast-MFC-AGG-ID: 1angchQUOcOQ3Ej0UzF71A_1780566712 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ECB121956095; Thu, 4 Jun 2026 09:51:51 +0000 (UTC) Received: from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.156]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 30FB930001A1; Thu, 4 Jun 2026 09:51:49 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , =?utf-8?b?QmFybmFiw6FzIFDFkWN6?= =?utf-8?q?e?= , johannes.goede@oss.qualcomm.com Subject: [RFC PATCH v3 12/17] libcamera: software_isp: Remove per-frame params buffers TODO item Date: Thu, 4 Jun 2026 11:50:58 +0200 Message-ID: <20260604095105.68798-17-mzamazal@redhat.com> In-Reply-To: <20260604095105.68798-1-mzamazal@redhat.com> References: <20260604095105.68798-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7oilGfin0ei8Q8_MXJkv1Z8vnvF6NzxB7mJf3uYICE8_1780566712 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Parameters are stored in per-frame buffers and shared properly now. Signed-off-by: Milan Zamazal --- src/libcamera/software_isp/TODO.md | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/src/libcamera/software_isp/TODO.md b/src/libcamera/software_isp/TODO.md index 0f27da2d2..f4e5190e0 100644 --- a/src/libcamera/software_isp/TODO.md +++ b/src/libcamera/software_isp/TODO.md @@ -65,24 +65,6 @@ addressed now, I think it would be part of a larger refactoring stats in hardware, such as the i.MX7), but please keep it on your radar. ``` -### Store ISP parameters in per-frame buffers - -``` -> /** -> * \fn void Debayer::process(FrameBuffer *input, FrameBuffer *output, DebayerParams params) -> * \brief Process the bayer data into the requested format. -> * \param[in] input The input buffer. -> * \param[in] output The output buffer. -> * \param[in] params The parameters to be used in debayering. -> * -> * \note DebayerParams is passed by value deliberately so that a copy is passed -> * when this is run in another thread by invokeMethod(). -> */ - -Possibly something to address later, by storing ISP parameters in -per-frame buffers like we do for hardware ISPs. -``` - ### DebayerCpu cleanups ```