From patchwork Wed May 27 08:15:32 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 26808 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 56556C32A9 for ; Wed, 27 May 2026 08:16:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 41F2563021; Wed, 27 May 2026 10:16:19 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="DBKzBBdq"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A99D363021 for ; Wed, 27 May 2026 10:16:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1779869766; cv=none; d=zohomail.com; s=zohoarc; b=RQI90qS993DBzetFE8czL8VMlOTxBv+tNEy0Ptn8k09UYw+9Rsb9qBQ4V/a1wjgqu58qWI6sNdqlK/M+B2q95GITv1rszmZ+AUs3cF+hphcsY4oVJdU0D8vzKvAseRjj/Uez6NszIXlDfp+2jVaUSBnck00QbdgcYB2Nr2w0tJs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779869766; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=XPeAw77/VqBYWO1QKVLeFzkm8QTD+ZIhsTwTCcqUn64=; b=DyVp9aIfPf9cTjLs/b9JJTpeLc4xJS0yhzv8+Gy4yFQSJs7Z6vO2igh+zPJhpzXxN0IjnqzU1yT9BHB1zhxRs5WWkO0ilWLnGkDiIDb2Jku3ZsLtUxOW5IbWb2z/wA/1LchT+mNvcPb1tR7n5EoZ8PvWcTQXeHhvTKwJ7KYZZqQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779869766; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=XPeAw77/VqBYWO1QKVLeFzkm8QTD+ZIhsTwTCcqUn64=; b=DBKzBBdqIYnwDGoFzHJt4J3xhtCJb+ZUWa7CJsg1y7DBClWSaSU/nD6TRp+//Guf 2dsOXZbedTyF7OepMiMTyjm03vczUv9tARk0Dw3xKYf4uNL9AYNcENdVCbIdDdH/Bk1 FFnKRLA2wTfu8c3+sp2IZElMRQirNbNrgyDPzzI0= Received: by mx.zohomail.com with SMTPS id 1779869764635638.4647018928291; Wed, 27 May 2026 01:16:04 -0700 (PDT) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader , Bryan O'Donoghue Subject: [PATCH v5 3/5] egl: eGLImage: Add flag to remember dmabuf import fails Date: Wed, 27 May 2026 10:15:32 +0200 Message-ID: <20260527081534.20245-4-robert.mader@collabora.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260527081534.20245-1-robert.mader@collabora.com> References: <20260527081534.20245-1-robert.mader@collabora.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In preparation of a following commit where we will start trying dmabuf import for input buffers. Also turn down error log in order to avoid flodding logs going forward. Signed-off-by: Robert Mader Reviewed-by: Bryan O'Donoghue --- include/libcamera/internal/egl.h | 1 + src/libcamera/egl.cpp | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h index bcf09b475..57f90d93f 100644 --- a/include/libcamera/internal/egl.h +++ b/include/libcamera/internal/egl.h @@ -90,6 +90,7 @@ public: GLenum texture_unit_; /**< Texture unit associated with this image eg (GL_TEXTURE0) */ GLuint texture_; /**< OpenGL texture object ID */ GLuint fbo_; /**< OpenGL frame buffer object ID */ + bool dmabuf_import_failed_ = false; /**< Previous image import failed */ private: LIBCAMERA_DISABLE_COPY_AND_MOVE(eGLImage) diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp index 267d22c8b..c185bb7ad 100644 --- a/src/libcamera/egl.cpp +++ b/src/libcamera/egl.cpp @@ -165,7 +165,8 @@ int eGL::createDMABufTexture2D(eGLImage &eglImage, int fd, bool output) NULL, image_attrs); if (image == EGL_NO_IMAGE_KHR) { - LOG(eGL, Error) << "eglCreateImageKHR fail"; + LOG(eGL, Debug) << "eglCreateImageKHR fail"; + eglImage.dmabuf_import_failed_ = true; return -ENODEV; }