From patchwork Wed May 6 23:06:41 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: devve X-Patchwork-Id: 26653 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 10D0AC32F7 for ; Wed, 6 May 2026 23:06:57 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 546AB6302D; Thu, 7 May 2026 01:06:57 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="CsnUkxWx"; dkim-atps=neutral Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 090A36301E for ; Thu, 7 May 2026 01:06:51 +0200 (CEST) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-48d102471a4so1771885e9.2 for ; Wed, 06 May 2026 16:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778108811; x=1778713611; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=vpT2omGvrrBC/UWz9mRqAkO01quAcHHbvl8N34ZIhJU=; b=CsnUkxWxTOKysjUu84w1+oJ5RWQRZambNaeSw7vogpsyoke0dzLYbwSOhX0yRQZy7Z CaiXeii6CiUbVivYjqua1M58ZDnIZnrpzrhiGL4ZglzlFv4HaRXu1rHGPyqinL/VqbKz 6PAt93QvYfzizOb5YpgGTHNI4gtRtJBb0d+S1TfrQCyvR9nm6Z9JtvIR0DOfvEkS4MeU /bedNH3V34QnmyCRXErDah4YnzKQmGCbhvwY+UHj2hw0Zb3gUnLmqCu6xfq3czIE7+KP Azs6mP0YamkfuqnQamWoz45Yh7lkCOBbfyv7z+m5ufryxRtMGo6OfsMzXkOdEtPDPrnl ggCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778108811; x=1778713611; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vpT2omGvrrBC/UWz9mRqAkO01quAcHHbvl8N34ZIhJU=; b=OF/Z2yP6rIZPFulxhRoMxNUxiimfATifqRlI9PS5vqp+ncNlBCX12iSAbEa15D1REf wUNn7TE7g78hCgA/CZDvCOuO56F6zyEGFGrRHBKixUIpWUKM9OXympVrd8mHIpG7BFJM 1oaZib+A0tKwDKDBl604Kfjy9mcP4VRlxD+vweb5T9n6hQWYR+Wo5q1ovXV0+74GF8Qz 9EzRnG+7Hjky0mhOpm7K4M/3DIVoS1pAWFr0iVVDQHB1iwW9drBFoZEFPxKVATc9o8R6 D8+7F8PyVZLgWwZlafrS28dS/SQhBY5vSfwzGSrT3hIF2uECJlXZrI7BvDVmL3uKphV9 Y0fQ== X-Gm-Message-State: AOJu0YzGwr0PYawcyY6Mh9arFL1OP8vc/15Thhb8izARdX2oFP8x3xoP u9l42wLCFgGFKJgMFryBi3D8ryh+r2axroY/Ry+xJDZPRNykeS+BwJvWqRo1LQ== X-Gm-Gg: AeBDieuKqVn5UTgPNyAw0W8HYITSZsad0elYRmfgIiw1HTFrE00aDq7AfKqHdhDTrRR gfpWlsZeiQpbtjBS4A08uT17FMA68UxUBQ1qqAGore4+9wClT0NaO4ZxPNa8ZD091mfMlSnHvKG dp2Djr32okxU4L6V8iMnsgZhgGsZLL3MYE7wy4GqpasO2vQgy7jPKQbE0HotDsVAkROdfx0LmRW j4apAM2I9zSV4+6DcdANSv58QJi2M6yVUUTajqfC5uAzbBk3KAbpyQQoENzkjEcF8/iYuJPSq7I WXEHbod3RmjywqXLuW7+XMoE6M6soxXUqYN7xJVf5Zka3tRwZgqq37hZsyKOpjAHc2aAwMTYssf huenGcc7uGaXzY6fEc6OQmf8OxXP2S9Vm51no3Pa5MIlHZbZumWSwRVrxyWaueQEyPZQ8SD/m/R JsWo8zahfE78O/WkYFc/JpikNo+AyrMPvdpTKVquAougna3z/dr+ibKS9wQZb+mAwj1CsOqU0o3 HjL7tDsS/zRNErkSRy9YWboGbB6Ie2x X-Received: by 2002:a05:600c:c094:b0:48a:592c:e63d with SMTP id 5b1f17b1804b1-48e51f3fab1mr64868415e9.14.1778108810930; Wed, 06 May 2026 16:06:50 -0700 (PDT) Received: from dexps.speedport.ip (p200300eda74453cf3cf3f7929e513b94.dip0.t-ipconnect.de. [2003:ed:a744:53cf:3cf3:f792:9e51:3b94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e538a547bsm85951935e9.5.2026.05.06.16.06.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 16:06:50 -0700 (PDT) From: d3vv3 To: libcamera-devel@lists.libcamera.org Subject: [PATCH v2 02/10] ipa: simple: awb: Add temporal smoothing and per-channel gain limits Date: Thu, 7 May 2026 01:06:41 +0200 Message-ID: <20260506230649.1040794-3-devve.3@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260506230649.1040794-1-devve.3@gmail.com> References: <20260506230649.1040794-1-devve.3@gmail.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add configurable YAML parameters maxGainR, maxGainB, and speed to AWB. Replace the single hardcoded max gain (4.0x) with per-channel limits, and apply exponential moving average smoothing to reduce colour temperature oscillation between frames. Signed-off-by: d3vv3 --- src/ipa/simple/algorithms/awb.cpp | 34 ++++++++++++++++++++++++++----- src/ipa/simple/algorithms/awb.h | 6 ++++++ 2 files changed, 35 insertions(+), 5 deletions(-) diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp index f5c88ea6..937aabc8 100644 --- a/src/ipa/simple/algorithms/awb.cpp +++ b/src/ipa/simple/algorithms/awb.cpp @@ -14,6 +14,8 @@ #include +#include "libcamera/internal/yaml_parser.h" + #include "libipa/colours.h" #include "simple/ipa_context.h" @@ -23,6 +25,21 @@ LOG_DEFINE_CATEGORY(IPASoftAwb) namespace ipa::soft::algorithms { +int Awb::init([[maybe_unused]] IPAContext &context, + const ValueNode &tuningData) +{ + maxGainR_ = tuningData["maxGainR"].get().value_or(4.0f); + maxGainB_ = tuningData["maxGainB"].get().value_or(4.0f); + speed_ = tuningData["speed"].get().value_or(1.0f); + + LOG(IPASoftAwb, Debug) + << "AWB: maxGainR " << maxGainR_ + << ", maxGainB " << maxGainB_ + << ", speed " << speed_; + + return 0; +} + int Awb::configure(IPAContext &context, [[maybe_unused]] const IPAConfigInfo &configInfo) { @@ -84,14 +101,21 @@ void Awb::process(IPAContext &context, const RGB sum = stats->sum_.max(offset + minValid) - offset; /* - * Calculate red and blue gains for AWB. - * Clamp max gain at 4.0, this also avoids 0 division. + * Calculate red and blue gains for AWB. Clamp max gain to avoid + * division by zero and extreme color casts. */ auto &gains = context.activeState.awb.gains; + float rawRGain = sum.r() <= sum.g() / maxGainR_ ? maxGainR_ : + static_cast(sum.g()) / sum.r(); + float rawBGain = sum.b() <= sum.g() / maxGainB_ ? maxGainB_ : + static_cast(sum.g()) / sum.b(); + + /* Apply temporal smoothing to avoid rapid white balance changes. */ + float alpha = std::clamp(speed_, 0.01f, 1.0f); gains = { { - sum.r() <= sum.g() / 4 ? 4.0f : static_cast(sum.g()) / sum.r(), - 1.0, - sum.b() <= sum.g() / 4 ? 4.0f : static_cast(sum.g()) / sum.b(), + gains.r() * (1.0f - alpha) + rawRGain * alpha, + 1.0f, + gains.b() * (1.0f - alpha) + rawBGain * alpha, } }; RGB rgbGains{ { 1 / gains.r(), 1 / gains.g(), 1 / gains.b() } }; diff --git a/src/ipa/simple/algorithms/awb.h b/src/ipa/simple/algorithms/awb.h index ad993f39..0aedc1d1 100644 --- a/src/ipa/simple/algorithms/awb.h +++ b/src/ipa/simple/algorithms/awb.h @@ -19,6 +19,7 @@ public: Awb() = default; ~Awb() = default; + int init(IPAContext &context, const ValueNode &tuningData) override; int configure(IPAContext &context, const IPAConfigInfo &configInfo) override; void prepare(IPAContext &context, const uint32_t frame, @@ -29,6 +30,11 @@ public: IPAFrameContext &frameContext, const SwIspStats *stats, ControlList &metadata) override; + +private: + float maxGainR_; + float maxGainB_; + float speed_; }; } /* namespace ipa::soft::algorithms */