From patchwork Wed Apr 8 11:56:29 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 26509 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EBB63BDCBD for ; Wed, 8 Apr 2026 11:56:40 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AD32662E11; Wed, 8 Apr 2026 13:56:40 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="ga+odE8H"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Uo+VBgsG"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C4E4C62E0D for ; Wed, 8 Apr 2026 13:56:38 +0200 (CEST) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 638Aii0r249550 for ; Wed, 8 Apr 2026 11:56:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=VGDyW/FEB0G bROb7MhWm4EA0EZyx0U/3giZ87KYrgO0=; b=ga+odE8HhiDFgCXdFfPtfhTgDXL 4bKPYKqQ+FYv2ZvkxME0vL270/J2uhqt3Wuh4lDj3BORXB3ZbcTcpGfDtSqu7ubm 4ZJYQQ1yrPKBx8EHoSF7bjNfRNtMoQX/Iddo4GkYzm+VY/Hk8ZtfzOzIhFNvEblq dDfwcN8BAZGXiPVqlCav8oGEi5S04zv+Fm4MxIGU0Y1P6ykZoPo+krAu/JaHuXJt Hn+S2XFNw7ag+ccI/qDTtnPYZWZ2oGACloUb8ennTUDjKuDrhJ3JIdDZV0GchGBn ut4qwqLnMRCATL/MMpZEFAl/MDUDvaIPB9HbLVS36JtbHdDWy/3aCW2SaRA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dd8x9ayhy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Apr 2026 11:56:37 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50d5d1c2289so147135151cf.2 for ; Wed, 08 Apr 2026 04:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775649395; x=1776254195; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VGDyW/FEB0GbROb7MhWm4EA0EZyx0U/3giZ87KYrgO0=; b=Uo+VBgsGqEvdPItDTKi6oHVLbwRTlv7pwUjXH889fznVNtc9Gta93sknLvBXBoP5Cd nlT1n179JKM2cl/ahNhXuV11CP7f91LQo7aCaFLPfaamzWyZFyzBtdGWk4FMRnVbQaVg bREA8jJ3jqBLFp0tgdAXt5rNFl9PFPZqmAIScPnX6xAp1JYPbZT+PjuyzhMtFbl+h91C LLJPdsXz6qR2s3GXDTCS5kOHbwlHvqEF6R6n0VwV3DNbnuuSh1FsLqpqjXwFUsFHGCyS 07IudMJRWT7wE2BCSE+cJmWAn5HGQ6oWjBAKJLIh/6FtFMmGmf6hJQPY3+yKSKAXqobI 5g6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775649395; x=1776254195; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VGDyW/FEB0GbROb7MhWm4EA0EZyx0U/3giZ87KYrgO0=; b=Zmwga7a/pXLJHEBTI73NXUXrFKFp6KzjpadQFBIT336EWV71OMTAou1Rg0Thb6H0Rf C+kDCXl2Nwu05vqSmsLaKFfeKdVr1xY0fmPOKetqO/TAEYnGFVzfmMDMr0BHzanjxA1r qFAfyU6q5Dd6dkx3eONXT79zL8UkA/oC0P/DazWOM+Zk1TygFwfaaE15ayt9eyPiSdtL NnmSAxZZCnw7LpTMZEJRVEMko+7K+kM3NSPCeSjK8lnXzKiDxpKJeaWPwYnMbqZLdaWO ZimB5hYrDijLpq7JfFDX6O7+MC0oQ4hT+5brwhbY19X6NxZ0LXzPBT1o8VvJq50QceWL 1nnA== X-Gm-Message-State: AOJu0YwVrIeg1dafBuA56L+4ZOU5wxX9uc9Vy+F1BHPDe4w39tgqb8ff 9ywzxpj5Ox2ujUrA2vob5LFqzkDE4D5KQ+rkn+rBIzE8rVEc9OlexWT4TzrZcvO+OPqEohLKQsM zAu0KSzoTMIrTRBMpyQet4j6/sakJWt0sUXYu9u7VhBj/7g7ae9oU5wZVzb6Aq06VW0kVT+sLl0 5Ic4TPTwTL X-Gm-Gg: AeBDievvgOR7hOVxup2phm2OMQXB3T3VeSjTlScR01M0xbm7mG5ldrcmxA33QXuJzBn Rh113D6btwa1VJfbtFqMh0txEw5ExZQjkSLPbrJWuib8XxgbyAjv7ETrTCRE/qesGBZYgaoN50V JBi83ONvM99t27VxyD1w2FnOX9kYOfhXzvIDFCSu09pa5DPZWlrhBwoj6Xy1o4mK0UYX1vAy8HZ zkS3bWzulmDRxzopXvG5d4qNCMwDsVnfgtlsLQBGi8ekAhonMRsCteZLNA5G1dNgtPZ3jFCA2TP 7NNC8X/L9gv58AOaDPoTZWDGYphU2RYOYWXDi902ANgkAe8DaO13Z6JWApoFP1Dd1/pb7We/k4X 3mL8VjOqDnPimLQApa2KERDuQwFBpY3hhWJlUByh1jTrPGIUKdIZLULmHfA+6uAE2UGytry8L/P mGLbFHegZw8V3DXgpZaUGFWJ6mg/JL+GDJ X-Received: by 2002:a05:622a:aa0b:10b0:509:2677:68f7 with SMTP id d75a77b69052e-50d6260b06dmr244381621cf.5.1775649395568; Wed, 08 Apr 2026 04:56:35 -0700 (PDT) X-Received: by 2002:a05:622a:aa0b:10b0:509:2677:68f7 with SMTP id d75a77b69052e-50d6260b06dmr244381381cf.5.1775649395117; Wed, 08 Apr 2026 04:56:35 -0700 (PDT) Received: from t14s (2001-1c00-0c32-7800-07d4-cca3-ec08-7ac7.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:7d4:cca3:ec08:7ac7]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3c97219dsm632410766b.5.2026.04.08.04.56.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 04:56:34 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Loic Poulain , Hans de Goede Subject: [PATCH 2/3] libcamera: media_object: Add MediaEntity::disableLinks() Date: Wed, 8 Apr 2026 13:56:29 +0200 Message-ID: <20260408115630.12456-3-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408115630.12456-1-johannes.goede@oss.qualcomm.com> References: <20260408115630.12456-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Authority-Analysis: v=2.4 cv=Rr716imK c=1 sm=1 tr=0 ts=69d64275 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=jrADUgksUtfPzxcU8k8A:9 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA4MDExMCBTYWx0ZWRfXyiBV9gi7gj39 4vFnsq2kbEW6R3faCoHQGu7h+sDeKpV2EforoztUySn1WdFNmwFJPs4/a4R1YsR7Qld7yjzHIRp mucvQHi+Vh7//NGx8DHexvMHKQPF423GoaNC+6EKx8J2QMhd/n01N4KtqhUmyHXXisvUphDJ5Zv MwGmCIrppSLOm9gZgS9lSB/WN3lG94NsnSa06PmRvtdtJ0G5Yp5PhKQKsXDGdesb95ModnqS1PY brfx9rn0ugKlpHrSAso8Pg3RbpH7zB38jqUbWNr7LQZLkxDePdlUDrDuzdkFutHmGiQ2zlXz+m4 aUGVhWyZz4ZVhkvR5hkFwHefuQjc56X2dgMzoBhd+zp1aq8lIV6vkByfF0YD/TDOIaryshMAmuW r6Ey6b+MmDQjZoF9VlyokKj7wRmXneYO1pT45zh9FH+fPms3mwxqxGAK5OZJXAFb85IP+MKxPcT N1Xn9LdnzHhHHtSzskQ== X-Proofpoint-ORIG-GUID: V_7hWNY1pGtLxZwPjX7wKYZmECX1Wa2I X-Proofpoint-GUID: V_7hWNY1pGtLxZwPjX7wKYZmECX1Wa2I X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.51, FMLib:17.12.100.49 definitions=2026-04-08_03,2026-04-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 clxscore=1015 bulkscore=0 phishscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604080110 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Some pipeline-handlers may want finer-grained control over disabling links then MediaDevice::disableLinks() which simply disables all links on a media-device. Add a new MediaEntity::disableLinks() method which disables the links on a single MediaEntity and use that in MediaDevice::disableLinks() to avoid code duplication. Signed-off-by: Hans de Goede --- include/libcamera/internal/media_object.h | 1 + src/libcamera/media_device.cpp | 16 +++----------- src/libcamera/media_object.cpp | 27 +++++++++++++++++++++++ 3 files changed, 31 insertions(+), 13 deletions(-) diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h index 54e2e5cef..121e80bac 100644 --- a/include/libcamera/internal/media_object.h +++ b/include/libcamera/internal/media_object.h @@ -118,6 +118,7 @@ public: const MediaPad *getPadById(unsigned int id) const; int setDeviceNode(const std::string &deviceNode); + int disableLinks() const; private: LIBCAMERA_DISABLE_COPY_AND_MOVE(MediaEntity) diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp index 3f974eaab..4833d4bba 100644 --- a/src/libcamera/media_device.cpp +++ b/src/libcamera/media_device.cpp @@ -463,19 +463,9 @@ MediaLink *MediaDevice::link(const MediaPad *source, const MediaPad *sink) int MediaDevice::disableLinks() { for (MediaEntity *entity : entities_) { - for (MediaPad *pad : entity->pads()) { - if (!(pad->flags() & MEDIA_PAD_FL_SOURCE)) - continue; - - for (MediaLink *link : pad->links()) { - if (link->flags() & MEDIA_LNK_FL_IMMUTABLE) - continue; - - int ret = link->setEnabled(false); - if (ret) - return ret; - } - } + int ret = entity->disableLinks(); + if (ret) + return ret; } return 0; diff --git a/src/libcamera/media_object.cpp b/src/libcamera/media_object.cpp index 3e3772a62..82ba5f4b2 100644 --- a/src/libcamera/media_object.cpp +++ b/src/libcamera/media_object.cpp @@ -428,6 +428,33 @@ int MediaEntity::setDeviceNode(const std::string &deviceNode) return 0; } +/** + * \brief Disable all links on the media entity + * + * Disable all the media entity links, clearing the MEDIA_LNK_FL_ENABLED flag + * on links which are not flagged as IMMUTABLE. + * + * \return 0 on success or a negative error code otherwise + */ +int MediaEntity::disableLinks() const +{ + for (MediaPad *pad : pads_) { + if (!(pad->flags() & MEDIA_PAD_FL_SOURCE)) + continue; + + for (MediaLink *link : pad->links()) { + if (link->flags() & MEDIA_LNK_FL_IMMUTABLE) + continue; + + int ret = link->setEnabled(false); + if (ret) + return ret; + } + } + + return 0; +} + /** * \brief Construct a MediaEntity * \param[in] dev The media device this entity belongs to