From patchwork Wed Apr 8 11:56:06 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 26506 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1AD66C32BB for ; Wed, 8 Apr 2026 11:56:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C53AA62E05; Wed, 8 Apr 2026 13:56:21 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="k3+0qlPa"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DcI6zeF8"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1109062DDA for ; Wed, 8 Apr 2026 13:56:17 +0200 (CEST) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6387EfVX2860432 for ; Wed, 8 Apr 2026 11:56:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=OwoxZxfVEBI rQvfWfiK8iI5loWWhQzz5t7067V/Ma+A=; b=k3+0qlPaVfPKLisO9qK6PucWkeg 3guEu0YZ0PjgXRYJXwhxWVGRznnwJQEXOGBfCAT5Vqjt2lUuDj2Lg0WY7lmwW5W7 hT5dT97zIOotfsjik8MxT0JydLVYSsL189Z2qGZwES6YLh+ZM1FVg/BKCdvf6+UG Zr0SLxHIEsk6MeUdAVyTZRQ5I8ofNv3ZcN4fPVWI93cmCGPZ8zhr2YSJXhXt5tE2 q//mI7pwEB5lttvlBzlwQpktwf5Ajhx+OictmHOaco9nhmj4auJovpNC89QZor3/ rqFHXP/yXNY5SxkVO9dMKV0aLXfjBSPNZXzN67g5NWy9MtVURBeHnMmDuLA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ddad8tqfh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Apr 2026 11:56:16 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50d8ed08aa4so101232961cf.3 for ; Wed, 08 Apr 2026 04:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775649376; x=1776254176; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OwoxZxfVEBIrQvfWfiK8iI5loWWhQzz5t7067V/Ma+A=; b=DcI6zeF8s0D0yrio+PH9J/XWPToD/jo7LFLVLr8PKIjWAjQJODCAycxigSkG0VBR9w WCmLCK4WfhwtF1oHm2XZfJMvWXVXydinDZYzGbkJE7JA/uTc8necjuupKsqHYmwhPB96 GGgn6eUfm7kOk4hHUO2unI/Ef6RJD/aUvxA183jCv0GghxLziyRuRKC/ORB5rBrDYl6d 3uL8b5P6hGznyg/9gp6ymdMaRYH5Fht6Mp/jCTJm+Nv0/tO7AsHogLp5+D5yBpgWdcVE qdBUwIHC142Dq5IDptHdjmsF9e/kXYWuTWV4AwNjyx6v/j1osT8Li9+Xs9dpogDh5Q99 OBOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775649376; x=1776254176; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OwoxZxfVEBIrQvfWfiK8iI5loWWhQzz5t7067V/Ma+A=; b=sMtpkS4wA4K52sOQqz+ogqSMLDGL9Cf0iPfC+InTkErAK0heDZ8zET5I/zUa35aNan ZmBw2Ne6Dtp08qWKYmJQDAM2r1OwzDxVCp49zM4uhlG/u0QB5Pq2sfwdpaptyievOtfU jQM28FeY+LjgkkqPQsN9zonUsrISiqMwIZph1Okvxxgbqxn01SZ10NjTNI50LkiHKrGO PhwgFRtCCGVeWayMtlpnp8IOkSVaF2w0K2ADB0yQBvVrxzpSeFNLZeP4m3BSVPaibjuL efD/G0xuKpB8oNyBiDbnskOICSMAybLf/tx7xV1KaZD2amc9ytEb1YPkIr/nVf3TfCg6 NFpQ== X-Gm-Message-State: AOJu0YwgDvmxI3K7MI43EDOClrgyzmh+bjpWT0qZRqxeXDXcCpFXWiN/ VXWgQZMSIKz1YL78cqXS0z39UGifDObyltnJnLel7QkFZ+iMMGF3A0TpBWH0kWHRHof8eVsFY3s fMwuInV7sKqQriN9VICxGYIn/uxnIdgUA0x1KP6ssMD8muysbkTIdc+sBPBJ+lgKH8XHrxMQFpV fAb5ECbPYi X-Gm-Gg: AeBDievJA5Ulb4Q0wim4TmSwasFVpj066RqL86vFILrJAYrzpAemeX3Zra5qM83u06J zii7eFtZTgwhq6e782USvHVj878deZ6Gmwc9Cn5hKj36jpBnJYQlL8ycBR65YrJItR7x4zXu0AW YAw3rjOnZHEmWYeLMxvCkaT/tKGmo1gkgsK7Fo5unelvor+X1phTRp8U38m18MkuTPv99vV5Ev8 MnhydKRAZfqf3n3EQItSXqlyxpVea/N1XjgQrVRngjVUiXd5bqTDzoC81Knf/btvmBLVc4rPSLL 1/8Qgd8vXSnkCG/Nqqse6o/xbISwqd5UTGV2iRuWP3gUnFA6UARHT/SPuPxgITtGOt7uDENLRlS O48G8KtR5X/y5HsuYKH1cxU4ZHMo2Of/PrSv7ysH6ThSlZ60ElcMgqCafI9ZEXVyxXjxy2IyS0x mbQPpRt1tnq9mfpNE+2roZD1C3x96ZvH0I X-Received: by 2002:ac8:5f8e:0:b0:509:456e:a179 with SMTP id d75a77b69052e-50d62b07434mr287345511cf.64.1775649375867; Wed, 08 Apr 2026 04:56:15 -0700 (PDT) X-Received: by 2002:ac8:5f8e:0:b0:509:456e:a179 with SMTP id d75a77b69052e-50d62b07434mr287345271cf.64.1775649375514; Wed, 08 Apr 2026 04:56:15 -0700 (PDT) Received: from t14s (2001-1c00-0c32-7800-07d4-cca3-ec08-7ac7.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:7d4:cca3:ec08:7ac7]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3cec6c1csm639102066b.39.2026.04.08.04.56.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 04:56:14 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Loic Poulain , Hans de Goede Subject: [PATCH v4 4/4] libcamera: software_isp: Explicitly load "simple" IPA Date: Wed, 8 Apr 2026 13:56:06 +0200 Message-ID: <20260408115606.12417-5-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408115606.12417-1-johannes.goede@oss.qualcomm.com> References: <20260408115606.12417-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: xJq56W7uN6UqlCfKdyduuEICs6oJx9qt X-Proofpoint-GUID: xJq56W7uN6UqlCfKdyduuEICs6oJx9qt X-Authority-Analysis: v=2.4 cv=EoDiaycA c=1 sm=1 tr=0 ts=69d64260 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=_AsD4-4jnHjeG7-VbxEA:9 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA4MDExMCBTYWx0ZWRfX7Z/fdf5FKuKt S6VpEt31Wej9KmgFtLDQ729SUQ+McZIhPE/IWQVVNA6EcHQcibg+CP7Cfbqgb5xYIiivVjP4UI5 L1dMy/nUvNIYytwytmeyP8fBIwyKuvrk/oMFkNk1neCE/Cbbb77yUh1EMtza9u7X1XTPJIdcK5G nJeUdzU8/HWp+RD8dIfRcZ+cNFlpvoC+6Xo0yjDpVnPMNx9r6Db3GI+/MJzVOJMfcL7Qv3niGvG 2BaADLKvhq8iwI9TxxvuYt+i8knXsBIEX42mvCJXJaA7kek6fsB4SIxbwaQjMwM3T2UY0ajaCDu BEJ1Qv9GlRZ587sdQv/P/uJi04NucS9JvLVKIFGGzR5BjDsntZzgc/k+O0J7CZoXYwyGh4+ZCEc zBbNItKWpbHb1pt4/2uPTVU63Edd4AYnMXz0+uq26d9HYtEUq7HyWyQZlK2j87kmupn6sDXmPB6 5pSLot/u1/bGPyXIKww== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.51, FMLib:17.12.100.49 definitions=2026-04-08_03,2026-04-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 spamscore=0 clxscore=1015 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604080110 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Explicitly specify the "simple" IPA name when loading the IPA so that the softISP can be used with other pipeline-handlers too. Signed-off-by: Hans de Goede --- src/libcamera/software_isp/software_isp.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index 60228369f..99e4635b3 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -127,7 +127,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor, debayer_->inputBufferReady.connect(this, &SoftwareIsp::inputReady); debayer_->outputBufferReady.connect(this, &SoftwareIsp::outputReady); - ipa_ = IPAManager::createIPA(pipe, 0, 0); + ipa_ = IPAManager::createIPA(pipe, "simple", 0, 0); if (!ipa_) { LOG(SoftwareIsp, Error) << "Creating IPA for software ISP failed";