From patchwork Tue Apr 7 15:33:46 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 26441 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 527ECBDCBD for ; Tue, 7 Apr 2026 15:34:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3FF0062DAC; Tue, 7 Apr 2026 17:34:33 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="TaPyhsoi"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1066F62D95 for ; Tue, 7 Apr 2026 17:34:30 +0200 (CEST) Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 77E326A6 for ; Tue, 7 Apr 2026 17:33:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1775575982; bh=9FbfwYofHyzwmmR3Qjf9uUfZyR1GSto0PS3FDU59jvs=; h=From:To:Subject:Date:In-Reply-To:References:From; b=TaPyhsoixfc3mLfDLzpv8oo6X/u9jYVi67WZCGD+JomfXsARElLGs0Ym5kdMbESXH 8Pfcxjwpe49NJUdwM5GxlW8aSJ8IcIoKbcocc8HHnS64amPUVbaZmGx/IYU4FoPzv2 lyzo9m6m3n7M7tHU8Kbnwv4NGCp+27q5Udpt8CLQ= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH v2 01/42] libcamera: Drop unneeded usage of this pointer Date: Tue, 7 Apr 2026 18:33:46 +0300 Message-ID: <20260407153427.1825999-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260407153427.1825999-1-laurent.pinchart@ideasonboard.com> References: <20260407153427.1825999-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A few unneeded usages of the this pointer to qualify access to class members have been introduced over time. Drop them. Signed-off-by: Laurent Pinchart Reviewed-by: Barnabás Pőcze --- Changes since v1: - Fix typo in commit message --- include/libcamera/internal/shared_mem_object.h | 4 ++-- src/libcamera/camera_manager.cpp | 2 +- src/libcamera/shared_mem_object.cpp | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h index e9f1dacd731d..21e025513fdf 100644 --- a/include/libcamera/internal/shared_mem_object.h +++ b/include/libcamera/internal/shared_mem_object.h @@ -79,7 +79,7 @@ public: SharedMemObject(SharedMemObject &&rhs) : SharedMem(std::move(rhs)) { - this->obj_ = rhs.obj_; + obj_ = rhs.obj_; rhs.obj_ = nullptr; } @@ -92,7 +92,7 @@ public: SharedMemObject &operator=(SharedMemObject &&rhs) { SharedMem::operator=(std::move(rhs)); - this->obj_ = rhs.obj_; + obj_ = rhs.obj_; rhs.obj_ = nullptr; return *this; } diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp index 23185467ba02..fc6e490bc476 100644 --- a/src/libcamera/camera_manager.cpp +++ b/src/libcamera/camera_manager.cpp @@ -41,7 +41,7 @@ LOG_DEFINE_CATEGORY(Camera) CameraManager::Private::Private() : Thread("CameraManager"), initialized_(false) { - ipaManager_ = std::make_unique(this->configuration()); + ipaManager_ = std::make_unique(configuration()); } int CameraManager::Private::start() diff --git a/src/libcamera/shared_mem_object.cpp b/src/libcamera/shared_mem_object.cpp index d9b61d37dd43..6edab045d47e 100644 --- a/src/libcamera/shared_mem_object.cpp +++ b/src/libcamera/shared_mem_object.cpp @@ -80,8 +80,8 @@ SharedMem::SharedMem(const std::string &name, std::size_t size) */ SharedMem::SharedMem(SharedMem &&rhs) { - this->fd_ = std::move(rhs.fd_); - this->mem_ = rhs.mem_; + fd_ = std::move(rhs.fd_); + mem_ = rhs.mem_; rhs.mem_ = {}; } @@ -109,8 +109,8 @@ SharedMem::~SharedMem() */ SharedMem &SharedMem::operator=(SharedMem &&rhs) { - this->fd_ = std::move(rhs.fd_); - this->mem_ = rhs.mem_; + fd_ = std::move(rhs.fd_); + mem_ = rhs.mem_; rhs.mem_ = {}; return *this; }