From patchwork Wed Apr 1 16:25:57 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 26414 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5C776C32F9 for ; Wed, 1 Apr 2026 16:26:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C5A0662D76; Wed, 1 Apr 2026 18:26:10 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="nJhH43Qo"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4765E62D66 for ; Wed, 1 Apr 2026 18:26:03 +0200 (CEST) Received: from [100.93.44.16] (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 194CFF04; Wed, 1 Apr 2026 18:24:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1775060680; bh=KqKprtini/35wm23jEEMQd4FCaoFI/KUjFpUo2GXVn4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=nJhH43Qo3NqTq7N5PDslZk5/YlB2j2YlQT0NAg3uCwXmchhRYo//WdiFtYSC4NBib 84brX33wAxtoQAp3mEzh9z6WZ+KDI8O4aDsNojoxnEwAYF1FFeQQo3JFg5e8BIu3J1 JSq1S02GcLKFpqT1pfS4xgFuY32YKh+xfZGBh3BU= From: Jacopo Mondi Date: Wed, 01 Apr 2026 18:25:57 +0200 Subject: [PATCH v8 8/8] libcamera: mali-c55: Fix sensor size computation MIME-Version: 1.0 Message-Id: <20260401-mali-cru-v8-8-44c48f990e28@ideasonboard.com> References: <20260401-mali-cru-v8-0-44c48f990e28@ideasonboard.com> In-Reply-To: <20260401-mali-cru-v8-0-44c48f990e28@ideasonboard.com> To: Daniel Scally , libcamera-devel@lists.libcamera.org Cc: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , Jacopo Mondi X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1117; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=KqKprtini/35wm23jEEMQd4FCaoFI/KUjFpUo2GXVn4=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpzUcXPJAJ0NEj9SgacQmm+ZaNpoj4UtECTiG2I if7QUddKHKJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCac1HFwAKCRByNAaPFqFW PL9rD/9N+tHRSt96G4godhc8ycAFi5rIpj7VVjs1Hdg1IFpgcyVu/BbchL6RvZ/fXIMjCGW8vAH DswBbgo2/WdTOHyIwgsmLUCW+NkGRSJA8sN6p9OFBwXCa/LHY35kmhIb/Xq9Tw4Jxe/F7ESPS6x DEpUMLKyo1JiIIl428a+I+TuHf/AFZJNILVrDrPlZSMSq/pa0PVJla6jdGpb8hln5g+FhW2BQf6 uk1sUiuiKZyD2SQaqObDemV6cHBGs39srr1K+eC7Tj1D4nz+pP6ZsrsRlM7Wr6pYoYo/LE2fToe Yq+I3jlbnlHpjGq6tgEaSF4taTNXgpiLtJFSQLfPaKIvJJD8QXIEjGRLOg2IfXX79oZp46XiCnJ tDI6iCuw6SlvsuhJ9iFU+9LrXPN7b72Bwij7tlpt3kd+YMcVqZyXvTQxwiX/iVYL2pMbTAQPSQi tBU4M15IA9FVhHg+Ed0Hdzr9HL+gBeQQG0v30ooicf7xYkyIL8ixdZXoz5UldDcmxw1XOrpJ/Rm Gb1/wdX6mn8n5RZ9ffDV/Dh33ANNmuTWeP2wZ+9VfY/pDnndLgYiGAEH8NhWuMSHOpXyMuVkwyy GoYWgIEY8cu96JFzcggXLYK6CfkQDdcqJD9J1Aiu93Icy2TigDKv80WfI18G2b1cCR4GyKff0ki tDWPvjdhdON9dPA== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The last size in the list is always selected unconditionally because the current best distance is not updated properly during the search. Fix the size computation procedure which has an inverted assignment. Signed-off-by: Jacopo Mondi Reviewed-by: Daniel Scally Tested-by: Daniel Scally Reviewed-by: Barnabás Pőcze --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index a78ffc21c808..0aa4d5e1780b 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -662,7 +662,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate() std::abs(static_cast(minSensorSize.height) - static_cast(size.height)); if (dist < distance) { - dist = distance; + distance = dist; bestSize = size; } }