From patchwork Tue Mar 31 16:36:36 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 26398 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 17531C32F8 for ; Tue, 31 Mar 2026 16:37:01 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0C4D762D45; Tue, 31 Mar 2026 18:37:00 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="uPc3k8BP"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BCE862D28 for ; Tue, 31 Mar 2026 18:36:52 +0200 (CEST) Received: from [100.93.44.16] (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F0C2B20FF; Tue, 31 Mar 2026 18:35:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774974930; bh=KJL2CcIY5VX/RCnpQMI88gQPmVI3D0wCVe1eWSxWWGU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=uPc3k8BP9C7g8J3Xav5ZyKzn2LT981wSkdkbuH/ibOMqMyqcsNTBcxQgOXaikkAWm mvk333fT//giMXnv7HHjHJgRd9Hvr2Z+r4sETKnL2uQFCSBd4LOEG+ziaMdPzn6M12 JT1sLehhrIzuRoo2nqe7ZbPeuPaeqaYF6BBML3hk= From: Jacopo Mondi Date: Tue, 31 Mar 2026 18:36:36 +0200 Subject: [PATCH v7 8/8] libcamera: mali-c55: Fix sensor size computation MIME-Version: 1.0 Message-Id: <20260331-mali-cru-v7-8-4caedc898a0e@ideasonboard.com> References: <20260331-mali-cru-v7-0-4caedc898a0e@ideasonboard.com> In-Reply-To: <20260331-mali-cru-v7-0-4caedc898a0e@ideasonboard.com> To: Daniel Scally , libcamera-devel@lists.libcamera.org Cc: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , Jacopo Mondi X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1117; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=KJL2CcIY5VX/RCnpQMI88gQPmVI3D0wCVe1eWSxWWGU=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpy/ghF8ruG/QF+yIvRiZWI/Vca/YkENSuWl9pM L/y6U4XDrSJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCacv4IQAKCRByNAaPFqFW PKIWD/9EdF1XIH9Y8E1Lst0fSJI0ezYG6R15ppet5gjolFuhL2KHmC9V0DdCN/7Ax6pbmsiQegI qU7slqTvy8Pab88riWGUb28rg5GSfXjyHccQ7Xe40rfR6sdK/8FTK6pSGajzpNlr6Eid/CHq5ag ybAcdHBuuX7o7EQbzzHzcKAXZitPab+7mjMRYaatOyqKALqPxS8LFvbLv8dRRSJ7O+JTlVBxI9w 7JKK1JH9vdKON7Vkh7Mo05YbCqxiHLxxlDFA2gAchS3SHLggdRVIc3/oIlBPHd3lwaeqas5YixY tgIkcrU5Mh303CVD87YKexKdAJ+53WwdCNqcOXIIdJZTg4l7hNFRzJnbzOEojdYeHuLKovf7ATJ 1LQNxWp3aQ3H3pPEIc1gLXLalkc5l+7KC2Yged/TxawDrqyj/LgVosSPyjJQ3u7WVGsFsN5LQg8 MSG3EslQTCmzwdmmr95lM79Ad9yTOFQ6FJmSSArUqJXQevdD80FjFyVwn1y56PwkBqyM++wVDIS vqzDQpMlUb+eNz6x3wFSXW8EPkcRW18V1ukiY/K9bF/emywoeAJaxybj9EgAFvq+nG4GC+hekdy 4JAw43ZlYrre/tvl3nx3gbjijz/rQqfX4IYLoU/mA3JHLBOjtxuysGIHZMEGSuvKvuIE7L6Fl4C h5AQbjjVtlqtdwA== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The last size in the list is always selected unconditionally because the current best distance is not updated properly during the search. Fix the size computation procedure which has an inverted assignment. Signed-off-by: Jacopo Mondi Reviewed-by: Daniel Scally Tested-by: Daniel Scally Reviewed-by: Barnabás Pőcze --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index c3856f7c0a11..3d502855dede 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -662,7 +662,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate() std::abs(static_cast(minSensorSize.height) - static_cast(size.height)); if (dist < distance) { - dist = distance; + distance = dist; bestSize = size; } }