From patchwork Tue Mar 31 16:36:33 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 26395 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A3694BDCBD for ; Tue, 31 Mar 2026 16:36:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 25F6262D24; Tue, 31 Mar 2026 18:36:58 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="qV4nIkNT"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 66C0962D1B for ; Tue, 31 Mar 2026 18:36:51 +0200 (CEST) Received: from [100.93.44.16] (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F092531A9; Tue, 31 Mar 2026 18:35:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774974929; bh=TM7VmBjE8vfgc8t0dcQuhc3P87EZAMjVVw3CwS12mcg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=qV4nIkNT42fQqMx9h1GVd9SpfU8u9iS2tv2DkEQ7VCkuNAxQoEAfBKIwvroO0YEFe ayvaFx1zef3CmLiPbCCM/pvueR9oIFQc6W8/cPoZSdq5y5yRD1hj7nJtcp0Hg02Vpr u8vrG84LdpHds9Jx54wOJZ6HRZQbnEBmPWmnCvcU= From: Jacopo Mondi Date: Tue, 31 Mar 2026 18:36:33 +0200 Subject: [PATCH v7 5/8] libcamera: mali-c55: Configure camera in memory-to-memory MIME-Version: 1.0 Message-Id: <20260331-mali-cru-v7-5-4caedc898a0e@ideasonboard.com> References: <20260331-mali-cru-v7-0-4caedc898a0e@ideasonboard.com> In-Reply-To: <20260331-mali-cru-v7-0-4caedc898a0e@ideasonboard.com> To: Daniel Scally , libcamera-devel@lists.libcamera.org Cc: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , Jacopo Mondi X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1848; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=TM7VmBjE8vfgc8t0dcQuhc3P87EZAMjVVw3CwS12mcg=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpy/ggn3zRzq+6TnbudW0ifgAJGRTrEeaQWoo1p L2uj54TU+KJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCacv4IAAKCRByNAaPFqFW PFzSD/0cLGX1NZB9YSvpRrBLWD7zy4s2nkT9ZWvVv+5DAUHrjHtz1mKbjSpnCniLxJ4hZeO4/JN MdK9m/rVEfbp+1GqWpp5GTfIr2lQLWkztiqaEga7sEWbyyuI5tOLBePyh+BphP8LVQ74y/Lzv0w Cs8aAzlRqoTMuwSJ7VYYB1yB/z5K6bC0vX2duunqX0+Uq6wo7nmDn653PNoD4CcemziYj9BZQN6 P8KlgAxgF9HdNdvC35xMKAsEYOS6fDXzqDhw9/YwLyEgb2np7lGUOCB/Chf9J4qCocX2PxmCTEJ gu/5lUq3jAkReMeVTMvdoua+ljum/xeY1U508EiYFKpXM3fTQD+Ou0HtCfdB4tIlf2H6xtK0Ex3 Bv9kUjNpnoNSIQTEjsTn7GjvQXKS6jhV+ltZ7LHSe+dT2kr5lpNsJ3cjv+S9RuV16UQ2O6Y1YuP BjpbVuMgurLCORAD3E7nuRqySEP2FxXc9S1BpMskNvZnbDjW+mLscyhogg13bm8Mp2SYx6DCEhI PhKlhUxfljhYnzUtju1BKrL1RzCWJakj4voVEo7hfJyVV6oYoJBiOSPDvyxRS+N+Lh9p3EItcTj 7oJPvw1lVcUsq0jYk74NeVcZoaIkIzYuKQpmkyHnJT5ALTLNo7G5uCVX7cNk0yAtAjsuLhOvC07 Rq5/xP3u2g67PiQ== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add support for memory-to-memory Camera to the PipelineHandlerMaliC55::configure() function. Start by enabling the IVC links, then configure the CRU and propagate the format to the IVC. Signed-off-by: Jacopo Mondi Reviewed-by: Barnabás Pőcze --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index d17b026db119..566fa0549675 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -1013,8 +1013,9 @@ int PipelineHandlerMaliC55::configure(Camera *camera, const MediaEntity *csi2Entity = in.csi2_->entity(); return csi2Entity->getPadByIndex(1)->links()[0]->setEnabled(true); }, - [](MaliC55CameraData::Memory &) { - return 0; + [&](MaliC55CameraData::Memory &) { + const MediaEntity *ivcEntity = ivcSd_->entity(); + return ivcEntity->getPadByIndex(1)->links()[0]->setEnabled(true); }, }, data->input_); if (ret) @@ -1041,8 +1042,23 @@ int PipelineHandlerMaliC55::configure(Camera *camera, return in.csi2_->getFormat(1, &subdevFormat); }, - [](MaliC55CameraData::Memory &) { - return 0; + [&](MaliC55CameraData::Memory &mem) { + V4L2DeviceFormat inputFormat; + + int r = mem.cru_->configure(&subdevFormat, &inputFormat); + if (r) + return r; + + /* Propagate the CRU format to the IVC input. */ + r = ivcSd_->setFormat(0, &subdevFormat); + if (r) + return r; + + r = ivcSd_->getFormat(1, &subdevFormat); + if (r) + return r; + + return ivc_->setFormat(&inputFormat); }, }, data->input_); if (ret)