From patchwork Wed Mar 25 15:13:39 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 26349 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0B3D5C32F8 for ; Wed, 25 Mar 2026 15:15:03 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E898E62852; Wed, 25 Mar 2026 16:15:02 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="TgzmCRLS"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D9D8627D7 for ; Wed, 25 Mar 2026 16:15:01 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:b16a:5ed9:4ada:a95a]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 5A5F712BB; Wed, 25 Mar 2026 16:13:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774451623; bh=VOqC7Xke0kB/p9Ixwo8tICQdTYGuG+M0+xf5hv/yUqw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TgzmCRLSWInV3cFxyG+bmLWe2U7YcVC3KIisPhIs4xX+tiHO4Caz1OOItyJHNnU7z Dsv2VDNBcIwJQwkW/GvUr8eb0CilabihlkYWVvCU44bUqNkd+ACym2YvjD76bTEFeq AL+MaTmpEYgcNJ9X/PXupR+71nVXbYfKQR0VzX8A= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug , Paul Elder Subject: [PATCH v2 07/32] libipa: fc_queue: Rename template argument to FC Date: Wed, 25 Mar 2026 16:13:39 +0100 Message-ID: <20260325151416.2114564-8-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260325151416.2114564-1-stefan.klug@ideasonboard.com> References: <20260325151416.2114564-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The FCQueue has a template argument called FrameContext which is easily confused with the class FrameContext defined in the same file. Reduce that confusion by renaming the template argument to FC. Signed-off-by: Stefan Klug Reviewed-by: Paul Elder --- Changes in v2: - Collected tag --- src/ipa/libipa/fc_queue.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/ipa/libipa/fc_queue.h b/src/ipa/libipa/fc_queue.h index a1d136521107..1f4f84c27fbc 100644 --- a/src/ipa/libipa/fc_queue.h +++ b/src/ipa/libipa/fc_queue.h @@ -28,7 +28,7 @@ private: bool initialised = false; }; -template +template class FCQueue { public: @@ -39,15 +39,15 @@ public: void clear() { - for (FrameContext &ctx : contexts_) { + for (FC &ctx : contexts_) { ctx.initialised = false; ctx.frame = 0; } } - FrameContext &alloc(const uint32_t frame) + FC &alloc(const uint32_t frame) { - FrameContext &frameContext = contexts_[frame % contexts_.size()]; + FC &frameContext = contexts_[frame % contexts_.size()]; /* * Do not re-initialise if a get() call has already fetched this @@ -69,9 +69,9 @@ public: return frameContext; } - FrameContext &get(uint32_t frame) + FC &get(uint32_t frame) { - FrameContext &frameContext = contexts_[frame % contexts_.size()]; + FC &frameContext = contexts_[frame % contexts_.size()]; /* * If the IPA algorithms try to access a frame context slot which @@ -122,14 +122,14 @@ public: } private: - void init(FrameContext &frameContext, const uint32_t frame) + void init(FC &frameContext, const uint32_t frame) { frameContext = {}; frameContext.frame = frame; frameContext.initialised = true; } - std::vector contexts_; + std::vector contexts_; }; } /* namespace ipa */