From patchwork Wed Mar 25 14:44:14 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 26341 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D3C0EC32F9 for ; Wed, 25 Mar 2026 14:44:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 684F46283D; Wed, 25 Mar 2026 15:44:27 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JyPWibXy"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 13B606274D for ; Wed, 25 Mar 2026 15:44:21 +0100 (CET) Received: from [192.168.1.104] (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0A0071943; Wed, 25 Mar 2026 15:43:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774449783; bh=LATrMea+GPrXRekBlXe2H8bkzQeumpp9rKZdniQ4tDo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=JyPWibXyptsIg76YU346NCcHErRlKfKzbUWNBqyLqbK9iWFQtqjVDRaa/szOrZ9xs dqQk83eWgj7HytIP7vfSYEo73t/LCwoKkNcGE/v5bwfkxhaRqh46IaYNtIgSK2O8vX 7XGSu92Ml47uySKQKNp8jw+zQDBdD0vcz2ysHO5w= From: Jacopo Mondi Date: Wed, 25 Mar 2026 15:44:14 +0100 Subject: [PATCH v6 7/7] libcamera: mali-c55: Fix sensor size computation MIME-Version: 1.0 Message-Id: <20260325-mali-cru-v6-7-b16b0c49819a@ideasonboard.com> References: <20260325-mali-cru-v6-0-b16b0c49819a@ideasonboard.com> In-Reply-To: <20260325-mali-cru-v6-0-b16b0c49819a@ideasonboard.com> To: Daniel Scally , libcamera-devel@lists.libcamera.org Cc: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , Jacopo Mondi X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1117; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=LATrMea+GPrXRekBlXe2H8bkzQeumpp9rKZdniQ4tDo=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpw/TCqNkulhKYAxGira/OXUZWmhy0laqZUlUoD /lvo4odNuiJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCacP0wgAKCRByNAaPFqFW PDl2D/9s4IbZnonhJ4WOei8PpsDewT0uUESLdGz3wv7gyfkUPcWLswzGwVtGkufzph0N0oTCCoQ corKaqLHBUnJjmtPoizKZkDkKNfgCzwRCu7jAkhehlC6SRhbusGtvnWTKDoEF4mWOqm4IGTi/1/ hr9mlOu7Kbm4Yr8frEKwsKGvC55PlNz2FNYkZlYGuvUQ0mRzGDqapYDuYT0zt8Mtg8gR0YXv3EI 9k4FCXNL34S+FYwZPXUeAm516OSEI121pRnYnuCWWQeYq3ACnn+aDnxhtwA4g1hf5u9Q8pNvEXv nDkh/8IfV5j/F0chAm9uCKgt6mCiW/CGyzfuuraFoDPnHAe5BywY5QLIehBrwGGUt/cP8RJaFMj 2WNm7J9fb/s1ff30eaTNA7YHoBrsvCclcmzje6ugRrDau3edogEE3Tud6kvAP4vshBI/uL7PIPU 99hhbH9/L+IUGmal58QEak1CoK7jK+YMTE5YWOR9tWMQSr2V8mH7/sV1B6g7Mt2iIdqeIEwGs66 Q9FL7mtAkNp4pIdPKwOBxJB3sezDoFhvnEnVXU9bnpPIxg7Dc8Tn4gGBxcTwpyANHFsrusrI0GY rBFzsliwsyIEYuL96mQyqYFV5KK0fL8D0EXGnhXq/RtD47k+trS/48tVN5CRGrbrZeiPGU/Oq1y CEQptqZPWqhue2Q== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The last size in the list is always selected unconditionally because the current best distance is not updated properly during the search. Fix the size computation procedure which has an inverted assignment. Signed-off-by: Jacopo Mondi Reviewed-by: Daniel Scally Tested-by: Daniel Scally Reviewed-by: Barnabás Pőcze --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index 10848c412849..2ba403fb348e 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -660,7 +660,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate() std::abs(static_cast(minSensorSize.height) - static_cast(size.height)); if (dist < distance) { - dist = distance; + distance = dist; bestSize = size; } }