From patchwork Wed Mar 25 09:26:57 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 26329 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 73DBDC32DE for ; Wed, 25 Mar 2026 09:27:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AE77262791; Wed, 25 Mar 2026 10:27:06 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="uZ6pAgSu"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C1E362788 for ; Wed, 25 Mar 2026 10:27:03 +0100 (CET) Received: from pb-laptop.local (185.221.143.129.nat.pool.zt.hu [185.221.143.129]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 699CB10BE for ; Wed, 25 Mar 2026 10:25:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774430745; bh=+v+puT3yK+q+iwpXjtvEIhVH03OfgrhUDcLY/pIOADE=; h=From:To:Subject:Date:In-Reply-To:References:From; b=uZ6pAgSuzWoEMfOFPBzcGU6XsuUxVz8Y/FScR4/l+X3vn8J1n4e6QrD1OG7Wx55IZ B259NH0GXnL2O8hxrt4ud8nk2Va5Fp1U6+KfCci1c+OjSE+FU+qL8P9babfnxHokdN kC54WfYUXC/TIywt2ceTq3r6mzH6HDG1s2cRptLU= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v1 2/4] libcamera: v4l2_device: Map `BITMASK` type to `Unsigned32` Date: Wed, 25 Mar 2026 10:26:57 +0100 Message-ID: <20260325092659.79453-2-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260325092659.79453-1-barnabas.pocze@ideasonboard.com> References: <20260325092659.79453-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A bitmask is conceptually an unsigned integer, as implied by the documentation: The maximum value is interpreted as a __u32, allowing the use of bit 31 in the bitmask. so map it to a 32-bit unsigned integer. Adjust the rkisp1 pipeline handler accordingly. Signed-off-by: Barnabás Pőcze Reviewed-by: Jacopo Mondi --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 +--- src/libcamera/v4l2_device.cpp | 3 ++- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 320a4dc5a..c14b57322 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -1479,9 +1479,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor) if (controls.find(RKISP1_CID_SUPPORTED_PARAMS_BLOCKS) != controls.end()) { auto list = param_->getControls({ { RKISP1_CID_SUPPORTED_PARAMS_BLOCKS } }); if (!list.empty()) - supportedBlocks = static_cast( - list.get(RKISP1_CID_SUPPORTED_PARAMS_BLOCKS) - .get()); + supportedBlocks = list.get(RKISP1_CID_SUPPORTED_PARAMS_BLOCKS).get(); } else { LOG(RkISP1, Error) << "Failed to query supported params blocks. Falling back to defaults."; diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp index e0099cb7a..db1eb70e4 100644 --- a/src/libcamera/v4l2_device.cpp +++ b/src/libcamera/v4l2_device.cpp @@ -572,6 +572,7 @@ ControlType V4L2Device::v4l2CtrlType(uint32_t ctrlType) return ControlTypeUnsigned16; case V4L2_CTRL_TYPE_U32: + case V4L2_CTRL_TYPE_BITMASK: return ControlTypeUnsigned32; case V4L2_CTRL_TYPE_INTEGER: @@ -582,7 +583,6 @@ ControlType V4L2Device::v4l2CtrlType(uint32_t ctrlType) case V4L2_CTRL_TYPE_MENU: case V4L2_CTRL_TYPE_BUTTON: - case V4L2_CTRL_TYPE_BITMASK: case V4L2_CTRL_TYPE_INTEGER_MENU: /* * More precise types may be needed, for now use a 32-bit @@ -636,6 +636,7 @@ std::optional V4L2Device::v4l2ControlInfo(const v4l2_query_ext_ctrl static_cast(ctrl.default_value)); case V4L2_CTRL_TYPE_U32: + case V4L2_CTRL_TYPE_BITMASK: return ControlInfo(static_cast(ctrl.minimum), static_cast(ctrl.maximum), static_cast(ctrl.default_value));