From patchwork Fri Mar 13 16:14:41 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 26298 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C7517BE086 for ; Fri, 13 Mar 2026 16:14:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7917F626EE; Fri, 13 Mar 2026 17:14:59 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DXO+xN24"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F25F626BE for ; Fri, 13 Mar 2026 17:14:57 +0100 (CET) Received: from [192.168.224.131] (unknown [37.159.122.93]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 58DEF103D; Fri, 13 Mar 2026 17:13:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1773418428; bh=deapVA1Shx6XLGOt2/xUg2Rv4+jLetI/mAuFJF4dFRw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=DXO+xN24+oeVOj5lI2w0iF1e7eVJdJXY6x12M5qujvpXIPdMeYGO1gl4Nhb6a+KD1 w8F7OF24FjSQRFIeYtD47OWYGze8TdCvt31oQbV7vp+/72lQT/U1BC3YUWAi9DeyiC Q3pNqaQvvz3toBInJiBq8fkNO+OuYfSDiiVogmCc= From: Jacopo Mondi Date: Fri, 13 Mar 2026 17:14:41 +0100 Subject: [PATCH v5 7/7] libcamera: mali-c55: Fix sensor size computation MIME-Version: 1.0 Message-Id: <20260313-mali-cru-v5-7-48f93e431294@ideasonboard.com> References: <20260313-mali-cru-v5-0-48f93e431294@ideasonboard.com> In-Reply-To: <20260313-mali-cru-v5-0-48f93e431294@ideasonboard.com> To: Daniel Scally , libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , =?utf-8?b?QmFybmFiw6Fz?= =?utf-8?q?_P=C5=91cze?= X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1117; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=deapVA1Shx6XLGOt2/xUg2Rv4+jLetI/mAuFJF4dFRw=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBptDfzhgBv1razLzojfnR6Gbt04ATDTm87Gl/wy IQOsS1aOIqJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCabQ38wAKCRByNAaPFqFW PDHtD/9j7CjbV8bOjiK1hr3dfK36LG3zpahgLmtvpVnr1hIXM40P+Sk2eUpv2R1k68NwG3IVdEi l4Q5tnmuOSpnCMlXjcsQsekWaCdcvxPVWN3jc4vU3qnTFcseBDqo9jOkxCoTS6ctE9TzYVbN5ID Fe34EWjxJHNH+eQdIIZYL0m1HEFL39olXTvPcS95xxp7OTWvwwLfpDrmMqsZi+ipeM06ZduWr5u oOKZ2Bp3Bl1YUSaN+CjtcbMtsBpMbjW284fDqIxp7y0+Y2uwJsRLx27d7D8sR8Cf5aDU92GBlaa 7Bzi4dpWwjg0MgIVm38LrnXdaW6RP+1Sk9Gjd76PhylbYZ1iFIwndoeI9oCBzIVYr5hMAtB8x1F vt57y2ByA2nFsFDWfqXEI781WnrJKjDPFDgWLe8wN+rWMI3mL3CiHA5YESSFIO76ba1m30mI7z0 2DEhyespQjlBxuUyFW0WQw4p5PjjU44e8kqBmomng9W9M9H7SiE/mwuj+jWZczAaJvRjOmSxEEO E0WGCDKns59qy4xy00d1OzGrDbLTSkEevZI8FFv1uQgwUaIF7NSRbh8Jjhy7Gbs+YMelniiD8bd ijQlGbienFDi9l19frtNjdTj+pYdPZILYNw42H02xI7+Z1yAEXvebKyTqlaHrr30svrvDYot9ok eQDA4CgPCfb+SIg== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The last size in the list is always selected unconditionally because the current best distance is not updated properly during the search. Fix the size computation procedure which has an inverted assignment. Signed-off-by: Jacopo Mondi Reviewed-by: Daniel Scally Tested-by: Daniel Scally Reviewed-by: Barnabás Pőcze --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index 84c2a030b470..33c69342cd49 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -695,7 +695,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate() std::abs(static_cast(minSensorSize.height) - static_cast(size.height)); if (dist < distance) { - dist = distance; + distance = dist; bestSize = size; } }