From patchwork Fri Mar 13 16:14:39 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 26296 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 88F39C32B5 for ; Fri, 13 Mar 2026 16:14:54 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 379506271D; Fri, 13 Mar 2026 17:14:54 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="p5p0UKhz"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D72056271D for ; Fri, 13 Mar 2026 17:14:51 +0100 (CET) Received: from [192.168.224.131] (unknown [37.159.122.93]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8CBAB1D98; Fri, 13 Mar 2026 17:13:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1773418422; bh=AsomUuJdFnFq0ZzK2S3TIpdAp6bgAC4XuKCZHuC6+HE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=p5p0UKhzIsDk7rsGGTzjN87VRU74q7usoizsZ3jWvKKies0gnBvXKAjvSYGXw4n8Y dONuI/Jg7d4LXACt9TzM08dXleZJaIEcmuMgq9bYchh4CM3jQ8OT1NJwYSQ0LSDGu1 MHfKu3zucVPNZq2CYWClrlh2MoPWiCPwHtBIoSLs= From: Jacopo Mondi Date: Fri, 13 Mar 2026 17:14:39 +0100 Subject: [PATCH v5 5/7] libcamera: mali-c55: Configure camera in memory-to-memory MIME-Version: 1.0 Message-Id: <20260313-mali-cru-v5-5-48f93e431294@ideasonboard.com> References: <20260313-mali-cru-v5-0-48f93e431294@ideasonboard.com> In-Reply-To: <20260313-mali-cru-v5-0-48f93e431294@ideasonboard.com> To: Daniel Scally , libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1799; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=AsomUuJdFnFq0ZzK2S3TIpdAp6bgAC4XuKCZHuC6+HE=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBptDfzTXbzskx/VLtLyd4AGfMT2l4vM7NUHAchh Aa9+/v10hyJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCabQ38wAKCRByNAaPFqFW PGNiD/wOXIvzaj1+u+TMEXhKvfhGGqKd7Huu3WWanMMk99zXKJIFvLiVoqTrNs9/4izEZiAhFVb tVuP8q3nCb0WBrROGqGx9e2OW+XWqmmbkpds8Pm66QQZk2c68N1BdaMruwRTX708UCSGLEWL/Fa zURdx3cO5jWB9kNcTJLaHZ/SzJ2+7+Hs+tj2z2GvYDLLOCn0vP4BSOOX+RQgIXzpiZJrhE6oOk7 IDRrX6uzgP4XqKhsTTroXPKQ7Dqsaut7CLzP/DM1Hj+IqAsc9CUAznUfsAZYrpmGCAmyncmwueQ N8wohkZBGEic8nojmqjjY+DA34MNwk7YP+U+FdpeGZdupBgcVczvve/XzWDH6s/gTkQcr/tZG2B ojmZpV/KXX6eyYaLgZuq1zo6DnTFEITGmt7gQKCOrHFqS1rgnV/N11L3BUTaCofNoIT3IbLIqdK 0yTaOPfM8eAdppJN0gZnNfpnNsYcWf0TALS3B5MmyUxP+7/pcFCoIULtfWdNhqUTQUNl1C9PPbJ efhHfTZ/IAoevGG+P17irn1XgD8k+RIic8zyRg/nP8AVmuZ5DjIb1jjE+zZoZBqpKW7AwZFEHqr KyxT6rRogMcf/jAQPq8HZb9uuwJseKrmzCeup1UjoGHtf+LpFoQoahx7VVAberD+KZUe+fZwQAq KcIcE5oMCxkLQTg== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add support for memory-to-memory Camera to the PipelineHandlerMaliC55::configure() function. Start by enabling the IVC links, then configure the CRU and propagate the format to the IVC. Signed-off-by: Jacopo Mondi --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index 5e93d66b01cd..9b83927d8441 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -1048,8 +1048,9 @@ int PipelineHandlerMaliC55::configure(Camera *camera, const MediaEntity *csi2Entity = in.csi2_->entity(); return csi2Entity->getPadByIndex(1)->links()[0]->setEnabled(true); }, - [](MaliC55CameraData::Memory &) { - return 0; + [&](MaliC55CameraData::Memory &) { + const MediaEntity *ivcEntity = ivcSd_->entity(); + return ivcEntity->getPadByIndex(1)->links()[0]->setEnabled(true); } }, data->input_); if (ret) @@ -1076,8 +1077,23 @@ int PipelineHandlerMaliC55::configure(Camera *camera, return data->csi2()->getFormat(1, &subdevFormat); }, - [](MaliC55CameraData::Memory &) { - return 0; + [&](MaliC55CameraData::Memory &) { + V4L2DeviceFormat inputFormat; + + ret = data->cru()->configure(&subdevFormat, &inputFormat); + if (ret) + return ret; + + /* Propagate the CRU format to the IVC input. */ + ret = ivcSd_->setFormat(0, &subdevFormat); + if (ret) + return ret; + + ret = ivcSd_->getFormat(1, &subdevFormat); + if (ret) + return ret; + + return ivc_->setFormat(&inputFormat); } }, data->input_); if (ret)