From patchwork Fri Mar 13 11:33:48 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 26290 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9F7ADC32B5 for ; Fri, 13 Mar 2026 11:34:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 587A562714; Fri, 13 Mar 2026 12:34:34 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="X/nHvBf5"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 88AB16267F for ; Fri, 13 Mar 2026 12:34:32 +0100 (CET) Received: from [192.168.224.131] (unknown [37.159.92.229]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EE9C01783; Fri, 13 Mar 2026 12:33:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1773401603; bh=RODaCUPDemFMAoR1fwRD2HIo2c+Jvu0vwlMja1pXbkQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=X/nHvBf5b8L35y4N9siLe1i/GkJGewI5AxgBShrp2XY1bEHPQlwQmMsaAn5eCESkx kJiJHdpH4y06lB1go6ILOb27+PEFjKuzyiO/nHgwscfnxD46Bx2fHAhEb1fi7NrztX /N/70f+VgNbOnOipKddPR4eRpUppkQXV4fZegMn0= From: Jacopo Mondi Date: Fri, 13 Mar 2026 12:33:48 +0100 Subject: [PATCH v4 7/7] libcamera: mali-c55: Fix sensor size computation MIME-Version: 1.0 Message-Id: <20260313-mali-cru-v4-7-c0d9bc8cd8fa@ideasonboard.com> References: <20260313-mali-cru-v4-0-c0d9bc8cd8fa@ideasonboard.com> In-Reply-To: <20260313-mali-cru-v4-0-c0d9bc8cd8fa@ideasonboard.com> To: Daniel Scally , libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , =?utf-8?b?QmFybmFiw6Fz?= =?utf-8?q?_P=C5=91cze?= X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1117; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=RODaCUPDemFMAoR1fwRD2HIo2c+Jvu0vwlMja1pXbkQ=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBps/Y1t3gBkcWJ+5x/OVZdwStVpeeQTrrLdZtCG oT6iLs8m76JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCabP2NQAKCRByNAaPFqFW PMgIEACORgRZYa67DVYJpZbWbq3KucAaPgxOJkNCMRV1/VZ9E/kf5/maYhKFczLX0QhAK3248ui uq91orfZ/JLteo6mileTwJqDwxdZRh0IffXNheuY0xUm47U4Qrcn8Ei5z+vhaQegw5W+ShuhE9+ WVgnQbrlF1TrSk0P9KB/O+zOVSapMwwmdLuWoqj4tvSuI460aSvSidXj1+Cm5Gj9qUtTNANSjkf /sMB8cX1mJaIsgCFm+BeqdcXtqgk7i/30RrFgn7SwHOWGrTS9PcyEtOwwg+nhL0qfkR/1QXSLKV PqxS0NLOqTLnWnXvWja4xDm9F3AmaCbv4GxiXvvJQ3daIOx3XqoAcpX9vrtwy/irngurqvYfJo6 njdIuu59QRVAEQLj9nCEGDGTchX0D7S4XUnVvfLXoi7bwqDJO7cyLExMvY4z+cl53HreRSX1d+Y h/mmbNckTz+Z9eNNwO7uWmnApEXJFzuo3KEkel8y6MdPrweDubjXiJlpZo4KvkTvFE2dfIIggbv oSGTRCeQBRj7y/Pfj1JMOYhVcOodaRPcFsKOx9llPRtyKpRQ3C7cZ+JJtkWvj1QuL6dpBuBVJtJ N6fTzkhcyZb9rmggdw6wVE7WOnF3dq7ihNplOVsbpiV0DylDFw63hWIJu10gwL0ELP/UvR8k4pr QwXMMa4DYMAR24A== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The last size in the list is always selected unconditionally because the current best distance is not updated properly during the search. Fix the size computation procedure which has an inverted assignment. Signed-off-by: Jacopo Mondi Reviewed-by: Daniel Scally Tested-by: Daniel Scally Reviewed-by: Barnabás Pőcze --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index a2f8f4b8e881..71bd249a00e9 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -695,7 +695,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate() std::abs(static_cast(minSensorSize.height) - static_cast(size.height)); if (dist < distance) { - dist = distance; + distance = dist; bestSize = size; } }