From patchwork Fri Mar 13 11:33:46 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 26288 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 508F7C32B5 for ; Fri, 13 Mar 2026 11:34:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0DD45626E8; Fri, 13 Mar 2026 12:34:31 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="m0WrLKrv"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BC1F36268F for ; Fri, 13 Mar 2026 12:34:29 +0100 (CET) Received: from [192.168.224.131] (unknown [37.159.92.229]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1FF531356; Fri, 13 Mar 2026 12:33:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1773401600; bh=8ul1n4i5T6cYcm/npmTY7Y82IwwGSy83YUy+ayD6KtU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=m0WrLKrvOFeS7TlvSBCFx34XdqzwSiWrQo3B3sYHRPhbpfCb4EASq056itZTTn84v u7gzD/AqJCwVe7wQsYpuNmv5cl+vbjJ6P7Vjnkn9EPr+X5RZlx+8+7Ak/IXJo9epUP YDgbXPh8/lP9f2Sk9aBWew6c+EchjLnRq1qY3w18= From: Jacopo Mondi Date: Fri, 13 Mar 2026 12:33:46 +0100 Subject: [PATCH v4 5/7] libcamera: mali-c55: Configure camera in memory-to-memory MIME-Version: 1.0 Message-Id: <20260313-mali-cru-v4-5-c0d9bc8cd8fa@ideasonboard.com> References: <20260313-mali-cru-v4-0-c0d9bc8cd8fa@ideasonboard.com> In-Reply-To: <20260313-mali-cru-v4-0-c0d9bc8cd8fa@ideasonboard.com> To: Daniel Scally , libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2412; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=8ul1n4i5T6cYcm/npmTY7Y82IwwGSy83YUy+ayD6KtU=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBps/Y1Nq5xHluLiAcnOzGo8TIY8pZx8w0aWwxY/ 9OkgryGQEuJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCabP2NQAKCRByNAaPFqFW PLmDD/4gUrsvl6nCwQcPinOXiJN6OVELclzx7F4gkAyO4N6DPv1+Ycz8+GfFdXDUPhPuP1Wy8Yr 9XdZKHp/jAU5CnAZqoFqUeN5rVoGazZ1/cxWFa7zttYu+BuS+FEudr16hk3HuRd3Cs5dHaBge7p 88VMe+zFGmJoHWIRQP4QNmInzbBUdotntZUFvzic2eU2az9nnsQQVNh9DkmjrdjPi5L1TIXLo// eFg1Q0M1IMXpyQ2uIC1OlQGlltpV5JlgcEkx+CPhglq02m/GRI2yytp4NwaQUH1b+B8C2dKDhlm Sj6hR/X7BYt0WG2fzqQ1BObReBawwg1x04y72d0sqQ5iM9uDqXnmB6+bU04xQKwk6aVuoCBuAJ1 7ovzyYSwl7vxhr+t9oeL7u47sYPwWDnunlF7DsZtSoZCXcmqrHKsAuNC3PPrDNW7Kv9oaNJNu51 P/WtE4Cr5+c3SQAKAWkdkfyNx/gMbUZDNJmSBt8sEKLHr06ADKL3ExdrLwySE6tKXVKsPTYYZUk KpmvrM1/9L7eLJKQEDFsEWuLKzVmFoy4pNR3uib3U9hper4Q7gHS+DbuRrbcW8dFthdu34/HKHb khO5nhLP/8czCR0FOGcU4G8aaf5ru4zTyrqVAlvZadc1axHg3iS7qFH0jGM9SLdXupW4vkuHAVi SV8ORXqb/dnMZuQ== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add support for memory-to-memory Camera to the PipelineHandlerMaliC55::configure() function. Start by enabling the IVC links, then configure the CRU and propagate the format to the IVC. Signed-off-by: Jacopo Mondi --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index 3c8848d28707..575c8451fc4f 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -1042,9 +1042,12 @@ int PipelineHandlerMaliC55::configure(Camera *camera, if (std::holds_alternative(data->input_)) { const MediaEntity *tpgEntity = data->subdev()->entity(); ret = tpgEntity->getPadByIndex(0)->links()[0]->setEnabled(true); - } else { + } else if (std::holds_alternative(data->input_)) { const MediaEntity *csi2Entity = data->csi2()->entity(); ret = csi2Entity->getPadByIndex(1)->links()[0]->setEnabled(true); + } else { + const MediaEntity *ivcEntity = ivcSd_->entity(); + ret = ivcEntity->getPadByIndex(1)->links()[0]->setEnabled(true); } if (ret) return ret; @@ -1056,7 +1059,7 @@ int PipelineHandlerMaliC55::configure(Camera *camera, /* Apply format to the origin of the pipeline and propagate it. */ if (std::holds_alternative(data->input_)) { ret = data->subdev()->setFormat(0, &subdevFormat); - } else { + } else if (std::holds_alternative(data->input_)) { ret = data->sensor()->setFormat(&subdevFormat, maliConfig->combinedTransform()); if (ret) @@ -1067,6 +1070,25 @@ int PipelineHandlerMaliC55::configure(Camera *camera, return ret; ret = data->csi2()->getFormat(1, &subdevFormat); + } else { + V4L2DeviceFormat inputFormat; + + ret = data->cru()->configure(&subdevFormat, &inputFormat); + if (ret) + return ret; + + /* Propagate the CRU format to the IVC input. */ + ret = ivcSd_->setFormat(0, &subdevFormat); + if (ret) + return ret; + + ret = ivcSd_->getFormat(1, &subdevFormat); + if (ret) + return ret; + + ret = ivc_->setFormat(&inputFormat); + if (ret) + return ret; } if (ret) return ret;