From patchwork Thu Mar 12 23:16:14 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Faizel K B X-Patchwork-Id: 26280 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 51676BDCC1 for ; Thu, 12 Mar 2026 23:17:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 011026265F; Fri, 13 Mar 2026 00:17:33 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Z95v1MAL"; dkim-atps=neutral Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 35A356261B for ; Fri, 13 Mar 2026 00:17:32 +0100 (CET) Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-35a1826cb69so103325a91.3 for ; Thu, 12 Mar 2026 16:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773357451; x=1773962251; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Crj5/i72nEqbooeaF7oZTjBVdiKVVLm5IQ4dcnP9qgM=; b=Z95v1MALJN1mh/QrovurbdWDv6q7sCJl0BANG8KjHF9BAij3dfftDapD8NZ7bZeH3f Z5Tv5s2XDbzSd/WHDy/qx3bY1Fy+HvLsAalekh4uDIlTfkDmebhs6xrP5cHO3MS+nXw1 MM5S1dpOvd1kZCL1DDGf3t8DZ7A36DO5t7WLkBqG86Ykse92Ik5LDS0UOhQpuzG3gOkx pW9HYpkwkV2NIlvBy5z24rsC2gNIkinMZrRbMiSnxtOU7nQLY12nQECGaUpeiMjzi9L3 HNuUQRB6I2mIkix7d2RlDO+biS3QR434B7XiUn6oKy9aYD0EW5Lhx7ZsjDyR/GLlkyUm Xd4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773357451; x=1773962251; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Crj5/i72nEqbooeaF7oZTjBVdiKVVLm5IQ4dcnP9qgM=; b=rIa739Zd/Go/vYr8667GX5C7eE0uSEJBuaqCWRKTBlNVlRYhMsLHk9siKQKL1Noeey 1UmofQ9w38+xmYIBPRhfaHOG5AxFQeknF3RdwspkP/yKRBOVBDZapiErCnlZRO5378CU 0nmBtJLov9iZjDc8kP4Qa8HHgX33De2VQJ2QQK2PTsc34UHAXrFAp6niqWCueogVPXGw bMhOngQI6P5iZgb40ghL2Si2kCZBkUaMeABPRKQewdVemaHS/wBms1b+mqmin1qAI38I /V5ZQEnqydPaRsCD6Uz8RtaCP+bbqwVScEH0lQSzpUOzwCFTt/P5NtMFRNxsYTKnAkd/ vMJQ== X-Forwarded-Encrypted: i=1; AJvYcCUqihqB5oaiT+x1n6YWtFrwHBtFnP8DLTkoHV0mUVrHRMwYKK9E8ho42kbqVycyaHqDKq53c4kUhTEYEQi3phk=@lists.libcamera.org X-Gm-Message-State: AOJu0YyGuuXHq00uorB9gawCLzhePHeVkErNxVyD0Pq8uRrNcfyqOr26 1dbCOsEY/3qsaGREMWZEjeG+vGdBpI9hMZSb+x8L/vFUM/Vp/21pEtwR X-Gm-Gg: ATEYQzx61vj5M8S1tiTreW6U38ECvEiWV4qKe+BjMP3tnNs/k6qrKlKqFGxWSGsAE1d 3SYB00vfXk6xzhV5L0inCzauVN2VqfRa6/+sLO+2JhUHqfpEyq7rpcac+w2Q5Ufj91MA4ThQkOb sC08NWqXKX3lIH7ovgwFA1X9SJOwQT7OALmitAIGj4XYdNkm8Op9qks0PE2hlciaaUFRVA7SSpx fEakNlNz8pHM/V7fud5W9FmduDWacDUtW+gwDXouaxKVhbxjZIkqOXn370fY+pnrEh5omp8dGai T8IAJYCLpDBavU7OHpp0Qf8OVkMgARxP3lReLVQTTpX2YBphewW60ipio4Ag+hbPmwKt6o/KL1m 2tlQELnYekk9iISG5A+4A7w/2M+EkKyVoy3AeaJE753xT9ewdvGtTGjMK0fpxxP68Zt7zRcqe6/ mpagxtqC7+TYY4suhQeFo3BTfdOvE+rdtbtipbiUTzK0VNC8pUO3eb8rw= X-Received: by 2002:a17:902:f546:b0:2ae:4f95:df56 with SMTP id d9443c01a7336-2aecaa3eb84mr7530795ad.3.1773357450767; Thu, 12 Mar 2026 16:17:30 -0700 (PDT) Received: from FAIZEL-KB.. ([2001:569:5b64:e100:3685:315:53bf:61fc]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2aece81cde8sm619395ad.70.2026.03.12.16.17.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 16:17:30 -0700 (PDT) From: Faizel K B To: Shuah Khan , Laurent Pinchart , Kieran Bingham , linux-media@vger.kernel.org Cc: Mauro Carvalho Chehab , libcamera-devel@lists.libcamera.org, Faizel K B Subject: [PATCH RESEND v3 1/3] media: vimc: sensor: Move vimc_sensor_device to common header Date: Thu, 12 Mar 2026 16:16:14 -0700 Message-ID: <20260312231616.3590215-2-faizel.kb@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260312231616.3590215-1-faizel.kb@gmail.com> References: <20260312231616.3590215-1-faizel.kb@gmail.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Move the vimc_sensor_device structure from vimc-sensor.c to vimc-common.h to make it accessible to the vimc-streamer component. Signed-off-by: Faizel K B --- drivers/media/test-drivers/vimc/vimc-common.h | 28 +++++++++++++++++++ drivers/media/test-drivers/vimc/vimc-sensor.c | 26 ----------------- 2 files changed, 28 insertions(+), 26 deletions(-) diff --git a/drivers/media/test-drivers/vimc/vimc-common.h b/drivers/media/test-drivers/vimc/vimc-common.h index 7a45a2117748..35789add6b4a 100644 --- a/drivers/media/test-drivers/vimc/vimc-common.h +++ b/drivers/media/test-drivers/vimc/vimc-common.h @@ -12,6 +12,8 @@ #include #include #include +#include +#include #define VIMC_PDEV_NAME "vimc" @@ -159,6 +161,32 @@ struct vimc_ent_config { const struct vimc_ent_type *type; }; +enum vimc_sensor_osd_mode { + VIMC_SENSOR_OSD_SHOW_ALL = 0, + VIMC_SENSOR_OSD_SHOW_COUNTERS = 1, + VIMC_SENSOR_OSD_SHOW_NONE = 2 +}; + +struct vimc_sensor_device { + struct vimc_ent_device ved; + struct v4l2_subdev sd; + struct tpg_data tpg; + struct v4l2_ctrl_handler hdl; + struct media_pad pad; + + u8 *frame; + + /* + * Virtual "hardware" configuration, filled when the stream starts or + * when controls are set. + */ + struct { + struct v4l2_area size; + enum vimc_sensor_osd_mode osd_value; + u64 start_stream_ts; + } hw; +}; + /** * vimc_is_source - returns true if the entity has only source pads * diff --git a/drivers/media/test-drivers/vimc/vimc-sensor.c b/drivers/media/test-drivers/vimc/vimc-sensor.c index 69e714d4f228..4c64cdab8cda 100644 --- a/drivers/media/test-drivers/vimc/vimc-sensor.c +++ b/drivers/media/test-drivers/vimc/vimc-sensor.c @@ -14,32 +14,6 @@ #include "vimc-common.h" -enum vimc_sensor_osd_mode { - VIMC_SENSOR_OSD_SHOW_ALL = 0, - VIMC_SENSOR_OSD_SHOW_COUNTERS = 1, - VIMC_SENSOR_OSD_SHOW_NONE = 2 -}; - -struct vimc_sensor_device { - struct vimc_ent_device ved; - struct v4l2_subdev sd; - struct tpg_data tpg; - struct v4l2_ctrl_handler hdl; - struct media_pad pad; - - u8 *frame; - - /* - * Virtual "hardware" configuration, filled when the stream starts or - * when controls are set. - */ - struct { - struct v4l2_area size; - enum vimc_sensor_osd_mode osd_value; - u64 start_stream_ts; - } hw; -}; - static const struct v4l2_mbus_framefmt fmt_default = { .width = 640, .height = 480,