From patchwork Tue Mar 10 12:01:06 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 26275 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A1692C32EF for ; Tue, 10 Mar 2026 12:01:25 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2AE3762663; Tue, 10 Mar 2026 13:01:25 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="G5SFmQ34"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cDJbSlId"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D203462643 for ; Tue, 10 Mar 2026 13:01:21 +0100 (CET) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62AAREWD4188504 for ; Tue, 10 Mar 2026 12:01:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=IfNCP/oNcWB sIg2Zu4ss/xnRftQ6vlXQs7T7fOA2KS8=; b=G5SFmQ34lFPu7TFETtjtIL4BB6S gaoSpL7bMYdrGYKs8epbaS2HdZqrE3blZGWLk2AswmhYseMIbglv9EMLw9RM0ziB LR79F1gYjL06TmvQBO7qFezBv7eHo4laAuLd+oadc6aJiPm++XhMuBOiBrCOBcYr AgKTD9TF5QeequBV566Eh5G6a8VF5uNfUDuc6tWxoQWYTSFy7rnF7xYjqTAIK+nx rH30orKOqbobbW5M18bwV4ZCE4HVYnNm/cBdmS8xaYyKkHtptBLefinLPBzJXPRg zv1SNiNzyF7MqgZcBvq+DFOUifT968c3DYqbZEqRkjefX1iPcmUObD0GIaw== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cthjf0c0s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 12:01:20 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-5ffe4912235so4762503137.3 for ; Tue, 10 Mar 2026 05:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773144079; x=1773748879; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IfNCP/oNcWBsIg2Zu4ss/xnRftQ6vlXQs7T7fOA2KS8=; b=cDJbSlIdGwIiKPElYoXnnfL/dC8x59hCtoiQf1VsHT6f/bnXRQB7w+shTMsROXL3cN M/hv+12q1uxsq5sAy9BsSb4tvWo0tUkn5oxI1RGweH+J4nmWAhgIanPhcgWNHWkKLFf3 rhy9ekoxwMlMgsESzNgtQS+d2zmjAVgpZB5QADvuDBNzQU/PtoQ9YlicCLUM/fFx/t4O yKlT7ZSaiubGN4Be7P1iy9HhFY1FU6qIe99HaYJ41ps1TDP/nUky9nKxIRoRKwyvh9ji BHrYMTuYgXtlr+7Wo8sMAXZGb7AqQDTKptyPI0jM+Km/5UzwXDzm0Y2296bWzMZ/MHDd CHow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773144079; x=1773748879; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IfNCP/oNcWBsIg2Zu4ss/xnRftQ6vlXQs7T7fOA2KS8=; b=X9bS3/2/IFx1b2Uzj1jkuQ50kprCOPNbRPKn3zcfnuzvBa3PsyeNa47I0kYBvIjAwh DJdxLXSS1Dr0HcbAXwY5ThjnkUkI46dSvlz8qM2lFe90pPHxo/WZx/N4QVE0p9t5Vd/r 1+g5pQhaYSv6+t4lP6jRhrXCHyWkXtJ4H+TX5q/8Ym1Qsanf7/MCG4BOa/eIeavXV+o1 xtlt7fLEr8QkocconzFtjLYyT6tzDF6g39F4QdbAXlDmy7gCldNr063LvHIzZXQl0WM+ StyczB8Mbx41x2lX+JJO/iUN1v3dwNwk8nhkevEw6zTk89PPFeHbX7mZziT07fBlGlYV chpQ== X-Gm-Message-State: AOJu0YwiSvWTicT7j8x0CB/9QWSo7Hg5iIWYtDvkR7VmDaRtQFItivK0 Eu3FeyTEtGc0FolsIZeCgoHl9Nt/4RbYyLxpvx4Js1GQTd66BN5QWvDzvswDQpxYq7nzPn0EHEb 0jBXobHY1tXHkFV0mm5VVYu72sNXcHBMY7tKKr8umpu9pxQ3Yli3goI9EP7VTdcRHq3z4a9AyL8 60ZYA+PEop X-Gm-Gg: ATEYQzwrwzx5LUgBD9LQlk9QmtAydtu1m1ocpZCCDzAO6Mat0nRUXTWQqvZ1HJOQk5u 0QqD3MuYuvsGOxTzFq6FE0f4KX8IuBYRoQbas/Ny4C81m6IKT0o0MBo0t50aM3AkO6AzVtq7M1/ U0gmGxvpGeD/TElewlSsC+MNUgEyhCk+WxcHiSUX7M/VZt6BGEtgj2TOQs6+V1C8zF03GwY4V7D Lqrvz3hectv4SA/HvC3wmmYFWoHuba9xsgG0rwaQSCl47eqnyTFCfeUH9MERZ+TWZ4ZJ/t8Owix NOnHm0lDTQ0NsRNUxeCBnn8zs/b8HPPrF2vVYAh5W0wl1K6c42C08iiKJPSwEjpU9D280kysbJY w3mmT61PLBcomraKouBPw6q5f/yQUo6UPKL7HaDZO/1IEExR/igzYC9WxukQA9Av+HN5c5JedDB iZyuTcyK4fhR+C17T5XfwNV0Jt+hF1ix+2zA== X-Received: by 2002:a05:6102:cc7:b0:5ff:f84d:eedd with SMTP id ada2fe7eead31-5fff84e5adbmr4679582137.32.1773144079125; Tue, 10 Mar 2026 05:01:19 -0700 (PDT) X-Received: by 2002:a05:6102:cc7:b0:5ff:f84d:eedd with SMTP id ada2fe7eead31-5fff84e5adbmr4679538137.32.1773144078585; Tue, 10 Mar 2026 05:01:18 -0700 (PDT) Received: from t14s (2001-1c00-0c32-7800-beb3-9058-f5fe-3f2e.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:beb3:9058:f5fe:3f2e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48541aa7aacsm87843405e9.13.2026.03.10.05.01.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 05:01:16 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Hans de Goede Subject: [PATCH v7 5/5] Documentation/runtime_configuration: Add missing software_isp.mode doc Date: Tue, 10 Mar 2026 13:01:06 +0100 Message-ID: <20260310120106.79922-6-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260310120106.79922-1-johannes.goede@oss.qualcomm.com> References: <20260310120106.79922-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Proofpoint-GUID: H3hXW3lPVqxq-b-ovKWagqw3xCOZEWRi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDEwNCBTYWx0ZWRfX/9q1q/Q/dZT7 8wxQ/ryx3KzkvQTDKzJdO65IYtgP1oStSdZRbeYA8WTzcQJKVD99PeqXYnFkcBawcQtvoMiQ5mT vhVf5Wm4rnTnNh3Zjk/2o1wVXZf1OVJ6Esit+1VksLOULA8VT1GIaGm+HRyn/Yy1STULGa51dNK DWsHGsPCu7l6IQzM6ufa0vBSIc2nWY7pMbjGtY4kO0gggtv/EPNcz5rq8m3+3glUaDxNd1tezAE XkdJHQEAe7VGkRV6EgeOtGHzzM1N20zITGchjCYKtj6ZPAOebDdHw3s/WMiwrKDf8AL32SRxlbC vJ8KJfDNITLyl0g7/0vD+yx8Gn9nInooZiSYmMWWk0CcIptBpmWf+kWcpqkJz1tLhWn3+dRrTIq TsYJB8mIkMhODdUSju+c+QBygn9Gf5zpgf4CtTAiphJ940KWtnBBN9z1bK9TkVF/hRRjBfapaVs 0bTnlGbWo8+7bJCx8+g== X-Authority-Analysis: v=2.4 cv=A71h/qWG c=1 sm=1 tr=0 ts=69b00810 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=vqn-7YPdvggCubZ9BQoA:9 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-ORIG-GUID: H3hXW3lPVqxq-b-ovKWagqw3xCOZEWRi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.51, FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1015 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100104 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The software_isp.mode setting was missing from the runtime_configuration documentation, add it. Reviewed-by: Milan Zamazal Signed-off-by: Hans de Goede Reviewed-by: Kieran Bingham --- Changes in v7: - Move back to being part of the series, sorry for the confusion Changes in v6: - Use "LIBCAMERA_SOFTISP_MODE, software_isp.mode" as item title - Add Milan's Reviewed-by - Send out as standalone patch, v5 of rest of series is ready as is Changes in v5: - New patch in v5 of this series --- Documentation/runtime_configuration.rst | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst index 651929a4d..a95de2f43 100644 --- a/Documentation/runtime_configuration.rst +++ b/Documentation/runtime_configuration.rst @@ -51,6 +51,7 @@ file structure: measure: skip: # non-negative integer, frames to skip initially number: # non-negative integer, frames to measure + mode: # cpu/gpu threads: # integer >= 1, number of render threads to use, default 2 Configuration file example @@ -85,6 +86,7 @@ Configuration file example measure: skip: 50 number: 30 + mode: gpu threads: 2 List of variables and configuration options @@ -141,6 +143,13 @@ LIBCAMERA__TUNING_FILE Example value: ``/usr/local/share/libcamera/ipa/rpi/vc4/custom_sensor.json`` +LIBCAMERA_SOFTISP_MODE, software_isp.mode + Select if the software ISP should use GPU or CPU image processsing, + one of ``cpu`` or ``gpu``. When set to ``gpu`` and EGL is not available + the software ISP will automatically fall back to the CPU. + + Example value: ``gpu`` + pipelines.simple.supported_devices.driver, pipelines.simple.supported_devices.software_isp Override whether software ISP is enabled for the given driver.