From patchwork Tue Mar 10 12:01:05 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 26274 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BE2E5C32B5 for ; Tue, 10 Mar 2026 12:01:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 724216266B; Tue, 10 Mar 2026 13:01:24 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="OBko4Tav"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RaHAvyMi"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 45A7462663 for ; Tue, 10 Mar 2026 13:01:20 +0100 (CET) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A8jpRB2460657 for ; Tue, 10 Mar 2026 12:01:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TmCwSNRDjMXD7FyELSBffXtyHj68sIz12Xk5gBuElFA=; b=OBko4Tavv52bT+tT N9PwwFNwre35pWL35EvgWQOJeJZioPtS6cBKWnXQuOJqfHVMLI+bMOg9gw6RQiiU 7f5OIS8sS2Zh3E0+gCrnVAE4JzYXxDH/BmTPouWTZh95CrAlFc/Uwvx25KxWdeRU BBtlyGAI/U33EOw1NQhPkAdNVw7ALCPeoQcPJlXBLluD+quvyUQ+CX1ByMkZjxuP o2lFY2U7eJghnKLq0INQWF/PbA77ZVg1hlsDgPTwR8awNaw132SQRNC0m5a0iJNf +FtjJojkEBHHffHRhacAVKdyxumsZz1ET6ylmcnT/5hLwVc86VeRFsAY9iMp1JR/ zxNGyw== Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csyv1c5ek-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 12:01:18 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-94e9c0edfcfso24791316241.0 for ; Tue, 10 Mar 2026 05:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773144077; x=1773748877; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TmCwSNRDjMXD7FyELSBffXtyHj68sIz12Xk5gBuElFA=; b=RaHAvyMi6jDQk6wRAjDLW1R0M5BHBs7q+ZbylXRZZyBmUAFsW663oDZAlCpQMmcEkM yFv2DvnPFNUoZlxhKdxremHoQwjbS2pQ8GVG57dxq5FjO1N779NSGYWxxWL+wQETaTWV 3tfwj32wS33zu6eMv+BoCRlUD+q61qcKChDSxBfNJHnYymdipGHR4MAANjojLReaCK9p 42VdGLpBykcReul5hecF1/ZIgTdg6o00o0e3VVFR+IZX/4fgVtrBLa5xAvjvTrYuuYGo PTIbVzMy058xo8WkYhIb8GHYo7525u3JO1o6vv4Kvp8U5tIU60+EgZkNmtIS2e0/vD+b Piew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773144077; x=1773748877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TmCwSNRDjMXD7FyELSBffXtyHj68sIz12Xk5gBuElFA=; b=DSTS+YvnaoZoLT005PCe0A6XaHwKWDOg93UTPhKQ7/OZqEA4lNgALpnwQp1CtvlYlk fgsUuBjR7lGOFXWsRLininRyyAlDh3CbpbBMT48rsVWKOO69/FhccaHfUWa7+Yxwqzhv RvlzlNUseuxjcny+QeJ80yfnaf7a+NTtThBfP55zk4y/cZWCgwheDB1YVGuI6GKuQKm2 viT2rjIL8aVBp+aUnd/cDr7O9PgJgn6kkMpQu+pA0rTp6ZeQlsinrytj+ikfJrPqPSHI yyMw86faMX3A7XU9t4wDfuxRM08z/UCnpeYwGdVv60IeGsMceKwLdxfcyGNF6eooz8f9 /7xg== X-Gm-Message-State: AOJu0YxZEHwfmTAcsGJSvP41bbkHAAfpGZG8+qzGfUZVtj3Fk13dFFLO Bx52C1FhmDltvhIwTuIfuAif3IBYCEXkFOQPxuGjXj9vk6fw+Hlwul7yvwRK0VkOQkL9tGs71VL BTemAHyPGRBh1okVmLb6BuoWWyKio0d5h6QyAawuXd6LEeEFfff6Yuykc2ZowENgZIYwPtkkc8y Tp0tOx5uGs X-Gm-Gg: ATEYQzy/9Ey2b7M+k4WmhuBnC2cdB/aqX5X5DGgB4hhC7EGTjkpLI1MXRYxUfCQqY6x RutVNho9Zw+q0JYnadZ0/Bn+1RTFfs9zUBfK2kvwS2WLpAPCPNHsY+aj2HARjrQfgjrAKaDbgx9 unJQ5tEk/CrXn61JSQM5LbIctBtauep7tgflZmXHrKFiGerksuAp+cLBAvjteVsfVp5pVdB8xZy 8uCkvEq41IBF+lk8SuW5fwZKxrKEQDAhaeREwzLst1WKhvKCDKa5ciZDg43ZC8CVxw0IXLN4A3R y+TSu4P7mdD034PWMvXOy2AyAqIhsc5tOisB3LVDQ/ZTlJu8Tu51IFd0GxmCVHu35beL/4aOUGY m3al8BH2sIo/S8eywUab/iwqTFTcl/5sV22uwAEHcjGU3bWGZg66Y9472jr+mIUPFZ/s10Lw3vr eTgSLk4fjxLnFVrlK2kGV9eEK93sS64vDAnA== X-Received: by 2002:a05:6102:a51:b0:5ff:d434:b507 with SMTP id ada2fe7eead31-5ffe5fcffc4mr5824044137.17.1773144076999; Tue, 10 Mar 2026 05:01:16 -0700 (PDT) X-Received: by 2002:a05:6102:a51:b0:5ff:d434:b507 with SMTP id ada2fe7eead31-5ffe5fcffc4mr5823993137.17.1773144076369; Tue, 10 Mar 2026 05:01:16 -0700 (PDT) Received: from t14s (2001-1c00-0c32-7800-beb3-9058-f5fe-3f2e.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:beb3:9058:f5fe:3f2e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48541aa7aacsm87843405e9.13.2026.03.10.05.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 05:01:15 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Hans de Goede , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Subject: [PATCH v7 4/5] software_isp: Log input config from configure() Date: Tue, 10 Mar 2026 13:01:05 +0100 Message-ID: <20260310120106.79922-5-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260310120106.79922-1-johannes.goede@oss.qualcomm.com> References: <20260310120106.79922-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Proofpoint-GUID: jEx6vGWOmmJtkGjIMqU_cKy4p9_KA2ar X-Proofpoint-ORIG-GUID: jEx6vGWOmmJtkGjIMqU_cKy4p9_KA2ar X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDEwNCBTYWx0ZWRfX9NepCGqlBNSA JuwZTD9iNeDnQxUjR0F56Yux78yAc63wyKTcCBjLinvTtxhlck4Y35IFw/jV8rHE7VGklwTWAUa sBXhbEg1AYpNDWU8kNzmkF2RnDgfbXFgmSZ/njRMJM4vG9MXMOBzrFDxse8TEy1mCgzZgPYPvEO BGR+MmSHVEVSu5F04hNVCuVFOp6tICEXjBibn8rRHsSYYlgwUBmbth90mpXyrLJTKCf2uuPMIr5 tvU84zTqJ5jZMlfZOy2j5fYO/YUZOhyCw5wSG+8AYUaieRh7Em2oPWIgk0iWjaijfn4NaYKU893 RSrYBQ/dF0pISbQQrswYgdCJKu3+oZ2aWdooMVHnKU4KlBGlwXXbM/CZqlEP/xTsjbL+zt+ePQk ldMozuK7Z6+rTfahGDCGECjrNhRCH/Ua8epKbZsXeJCF3b8d0GQ3AMDV/B9ojIoLz9R0bLxtVDj XnCVrFar7E6isFV948w== X-Authority-Analysis: v=2.4 cv=Cuays34D c=1 sm=1 tr=0 ts=69b0080e cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=20KFwNOVAAAA:8 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=mKg8M22OkPar6P-70WAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.51, FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 spamscore=0 adultscore=0 priorityscore=1501 phishscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100104 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" As shown by commit 94d32fdc55a3 ("pipeline: simple: Consider output sizes when choosing pipe config"), the extra pixel columns CPU debayering requires on the input side makes resolution selection non trivial. Add logging of the selected input config on a successful configure() so that the logs clearly show which sensor mode has been selected. Reviewed-by: Milan Zamazal Reviewed-by: Barnabás Pőcze Signed-off-by: Hans de Goede --- Changes in v2: - Move from DebayerCpu::configure() to SoftwareIsp::configure() so that the input fmt also gets logged when using the DebayerEgl class --- src/libcamera/software_isp/software_isp.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index 562cdba22..4cf5639d9 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -21,6 +21,7 @@ #include #include +#include "libcamera/internal/bayer_format.h" #include "libcamera/internal/framebuffer.h" #include "libcamera/internal/ipa_manager.h" #include "libcamera/internal/software_isp/debayer_params.h" @@ -270,7 +271,16 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg, if (ret < 0) return ret; - return debayer_->configure(inputCfg, outputCfgs, ccmEnabled_); + ret = debayer_->configure(inputCfg, outputCfgs, ccmEnabled_); + if (ret < 0) + return ret; + + LOG(SoftwareIsp, Info) + << "Input " << inputCfg.size + << "-" << BayerFormat::fromPixelFormat(inputCfg.pixelFormat) + << " stride " << inputCfg.stride; + + return 0; } /**