From patchwork Wed Mar 4 07:50:51 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 26251 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 83C9CC32EA for ; Wed, 4 Mar 2026 07:51:05 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 318DD623A5; Wed, 4 Mar 2026 08:51:05 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="YOZFi/Bo"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Zw4UHxQe"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 65B8562391 for ; Wed, 4 Mar 2026 08:51:02 +0100 (CET) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6245SXee3110522 for ; Wed, 4 Mar 2026 07:51:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=8Gvil8HmgAm ctZLXvrxDYw8ceQF1zFMUNkBVOjwGEfg=; b=YOZFi/Bofk/Ull9bZzx74gmaaeh qKF9HjoFTZMoeIE2RiuQSVaW67FPjD7X/eXF4bDtasCvnYc0zVmUdyoMR+IZYPKh IA2I9eRLj2d4+u5ahAfjs5RS6czTWShL98nl2JMml0nhLTmxHVaIshepAbFbyuWt K0piwc9I0GG0gekK7YkPUvxG82Eb8NpEvJB8b0fu4/G86yL/IR2xdI7/C6EFEC6F dZTnJG7XgMpNC0iGrhggplF9mifP/JhGKCRLs6GCoxKStf+fJYcMgF1KoOFJ/W6k y+PkgLVArOKsxKR82UmUg/JyOhawYXUzAlTkDENrxhCnAD2vOU5Cy+YPwMg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cp5h2a7t7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 07:51:00 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c711251ac5so4135334785a.1 for ; Tue, 03 Mar 2026 23:51:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772610659; x=1773215459; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8Gvil8HmgAmctZLXvrxDYw8ceQF1zFMUNkBVOjwGEfg=; b=Zw4UHxQeST4YWlpbjgZJtNQh+9h+Jvryo6h+U/dtEnyk/7z36o2DhTtM9cYqHpZ7Cc zJ8lh7qOpvS221yQ4vIb7Fv4FOhjMx6ay+rNaZH4Ahtq9uuy3Ywk8n+kRoUu3d4dtOFI j6VtRaw1/Ih6LHP+CEGS3ApAJkmu2bnmbH/VThroXypWWG6kq9fy8HRRYwDngRvvAcwe yEuonx/zoH3n7BLIA7H6NveB525OMLhF73rWNRn9pNz4kvVCtNpbapwr8DgWa3b4mFgz tSIcO2Xi0Zt2hlSXDdj3yrnzw22J4zkDTkqGVf2GStJ59/K+GHaOnlZ2YVvC9/3zE7xz DRCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772610659; x=1773215459; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8Gvil8HmgAmctZLXvrxDYw8ceQF1zFMUNkBVOjwGEfg=; b=j2BFEqaCeLYtYE6fEUD5wXc31znIRiSwNDJtLmr/8+Hoa+YyeFGxsdo7S1dHAKgoD6 FlEYnk1coDp0ooqwIAlJ6/aypHLqLZ612qRwpxArSmFN/E/UIC/KBOG8m8t1bPoTNZMj DUIZ+c0LmQl73lmprxQ2tcbcj69E8TwkgGgakYJe21FT7ZkN4ra7Bi8x4cyRr4yU4iZ7 4suOFbCTgp9zA7Qp6d+V1uvszuiMASM5qNgHG38r0pLiN0WrsAgkSAtlJgte0F9o04jd GA81X/wzXMEOpS7JvF0mEOTsAdHH8E8GDnfH4KH50UKD8UVdqcCnNMIwdtlZ25Yfzpg1 w3ag== X-Gm-Message-State: AOJu0YzZpSl7Olo8Cjwedwb4Xuy9SWk5qfLbLg7GEsnQaem4yv8FdYGR yoOEihs46nCNgJlKb34f1lhn4qOaAx6RBB70Ti3LPLdJxvcpoKlKasDlGHPgEK+hbQ/8s30Fbpa LcfsfGZFZ28jczI5yG3SfSPH4ES2bMKqkhYwQ9QWOTTuTjHaOT5mqJJaTu+jBJ744+hzwfRdNUR wv0UywBljp X-Gm-Gg: ATEYQzymA58Ga7ct0xpSnfIcgY6ouA5ve5PD8FU3KGujsFdV33Ab7DGhIMg7RdgK/uy Gchdweie5T6rSyvARMXHwijFj43GG8SvTjJRD/93GpscLJXFdSWWueMMunklDySEcLFTo0kcCw1 OvxHniRyKWxGxCD40p4kP8ifgeg9UFEFlnOTWN+/5b/1hpWS8n1UnL/pWOpLCsuzb+DOaF0/BO6 PS/vTT749AQ5grM0sk761aseN2icsWIipAJ2RTLUPTJPaqschjCzYhQH4f/tksQyf9U1tDiTVnz TjAI9ztQd0NflQSOmNpYRGPw3+ohx2mO9Jeb6j08S8DJSfgfVYukRDBNxWAECmkDgxWAvw0Jta+ Lp8l442PSQQwYVAUC0mzf9gEk8bZGSqohnYefqKwPi1D5zRRE4OyUyUmN8TtQapb8YB7Zd5v7iu P4DK1m/iqmlXUBYT+tUf6BL7Kb7/+LKdexOK4N X-Received: by 2002:a05:620a:4096:b0:8b2:74e5:b36 with SMTP id af79cd13be357-8cd5afa5ad6mr133601985a.68.1772610659329; Tue, 03 Mar 2026 23:50:59 -0800 (PST) X-Received: by 2002:a05:620a:4096:b0:8b2:74e5:b36 with SMTP id af79cd13be357-8cd5afa5ad6mr133600485a.68.1772610658856; Tue, 03 Mar 2026 23:50:58 -0800 (PST) Received: from shalem (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b935ac73a5dsm693263366b.25.2026.03.03.23.50.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 23:50:58 -0800 (PST) From: Hans de Goede To: libcamera-devel@lists.libcamera.org, Milan Zamazal Cc: Hans de Goede Subject: [PATCH v5 4/5] software_isp: Log input config from configure() Date: Wed, 4 Mar 2026 08:50:51 +0100 Message-ID: <20260304075052.11599-5-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260304075052.11599-1-johannes.goede@oss.qualcomm.com> References: <20260304075052.11599-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Authority-Analysis: v=2.4 cv=JqL8bc4C c=1 sm=1 tr=0 ts=69a7e464 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=mKg8M22OkPar6P-70WAA:9 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: G4PKVQMS25KC8Fy7LK0fW8Ss69w5gQ2f X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDA2MiBTYWx0ZWRfX1RmgWT/+if/N HPn0tkHuXMmqlDnhQ8CUqQkOt/QzoYAUJzy/QEQYAjH8m5ivyWnbQ91iYFy1JC4N/iYnFDvG8MI 7GvJAPebmwxDyFfE/sTU4YJ6UrEAWxqo287LS167dK+u5czpAKzC15a7NKx5NVVLDXHk3BLSYad 8YvvlRiW9kZLaZvjlWTWp0XY6mFVCwOdTWodkfNRfqCkfQTL/c/hqgBBmAKlb4XVnrR0f3cnEym ocWm9tzLmCohkKOoTPHTzsWraYeqEYzpWhmrKsa0iWXlfarEbMKmw7sZZswM88nLIew/DOmonaL 164Stu657R4Cgzol5+owED0LrthmnuE5AGnVXUSewUpVm56NVKO1wgkiqPuboVbl0oCqYmatU8J C8NZw0PD718M19POdI3xSPeWmImYTw76V+38eqKU5kgT6s54FqWFaAWiuFFCx08PXORLidRQ9uI 7ceMJPLiZmJnyqOGTtQ== X-Proofpoint-GUID: G4PKVQMS25KC8Fy7LK0fW8Ss69w5gQ2f X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51, FMLib:17.12.100.49 definitions=2026-03-04_02,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040062 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" As shown by commit 94d32fdc55a3 ("pipeline: simple: Consider output sizes when choosing pipe config"), the extra pixel columns CPU debayering requires on the input side makes resolution selection non trivial. Add logging of the selected input config on a successful configure() so that the logs clearly show which sensor mode has been selected. Reviewed-by: Milan Zamazal Signed-off-by: Hans de Goede --- Changes in v2: - Move from DebayerCpu::configure() to SoftwareIsp::configure() so that the input fmt also gets logged when using the DebayerEgl class --- src/libcamera/software_isp/software_isp.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index 562cdba22..4cf5639d9 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -21,6 +21,7 @@ #include #include +#include "libcamera/internal/bayer_format.h" #include "libcamera/internal/framebuffer.h" #include "libcamera/internal/ipa_manager.h" #include "libcamera/internal/software_isp/debayer_params.h" @@ -270,7 +271,16 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg, if (ret < 0) return ret; - return debayer_->configure(inputCfg, outputCfgs, ccmEnabled_); + ret = debayer_->configure(inputCfg, outputCfgs, ccmEnabled_); + if (ret < 0) + return ret; + + LOG(SoftwareIsp, Info) + << "Input " << inputCfg.size + << "-" << BayerFormat::fromPixelFormat(inputCfg.pixelFormat) + << " stride " << inputCfg.stride; + + return 0; } /**