From patchwork Tue Mar 3 11:17:41 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 26247 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 59519C0DA4 for ; Tue, 3 Mar 2026 11:17:57 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9C6B26239C; Tue, 3 Mar 2026 12:17:56 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="MPfQBuog"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BZEq/wwx"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F5216238E for ; Tue, 3 Mar 2026 12:17:52 +0100 (CET) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6239n5J4582371 for ; Tue, 3 Mar 2026 11:17:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=8Gvil8HmgAm ctZLXvrxDYw8ceQF1zFMUNkBVOjwGEfg=; b=MPfQBuogKnHaHWjex2Pq8gDiH8q tIzTvJ5q6EsyHyWb+QV9JJsdBgudUrz/q5IFo+SFayrw5JVOtEUXJZCDzuw5jKo0 ML7AKAn8SA//GMo3eAzHUFDIjY4dmim4X6SJC/RkQYBuxmgYcA9E/ua1VSbpG/hf lVJ9/xE6BAq0altuQlyqnSmZgL4Z3X0/soxcDp3fKNDN6ZwYzYdTq2Vdl5e6ztBo G796jQYUMDML8rNui1YH4CPsQiJ82ANZ9D85F6cNXEGtoIfqzQglZcXhBmpz/Dtw w6nFj7O8fs4SWep/e/DEDrcxOJfm2wli5wdNR8sGg0hsQA04JRNshhYjsXQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cnh6uaqd3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Mar 2026 11:17:51 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5033c483b74so54133211cf.2 for ; Tue, 03 Mar 2026 03:17:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772536670; x=1773141470; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8Gvil8HmgAmctZLXvrxDYw8ceQF1zFMUNkBVOjwGEfg=; b=BZEq/wwxatmlrB481uf5huSmkKJFPGDR5GNASU7zQxCBhyucnO5A2115NSs4dyBb7v Uz7J+WcjmO+xnQMHzPYThe/l7irSUfGkiHibsxg1vsZ3BAAKS0TM2rbdfdr3MpRs2olv W96gUp6tlHbmkBTT/CUjbdY6x52f5RGdAeNiyvh/IvYc0kTo+BwXZQKyuhmvau6R5d8L nZ82QcH5dVYwL98qC2UwIx+KTz9RLxV5fcDStxzhbnxw7NONhKr+JGL0fXat4WjngzZQ AHtlSzA35iBeh1RyD1RmWtiX8ME9LXBq++RAdVjgXuw0fXsj5EaHJj2LNHEMOXG1rnej zEuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772536670; x=1773141470; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8Gvil8HmgAmctZLXvrxDYw8ceQF1zFMUNkBVOjwGEfg=; b=fC90qVVtHVf80gL5qKXzIbLyRRkKl6iqoduZ0PorEvkLH+AqJcBLq7Czwg5LAw/t1A 27emaNCWJxpoqA4OJqPYtpdZCLOkFEsFkZYAqeaacqsyIIipnQsuRtdnimn34Is5hTpN t7kRu5j0nw8yW784rIx45MaGCJ+JWGOn9mq0TSLJmNwvIZKkefovAHl/+vDCFPJNJYvV njViqeriaNApk5QQ2NL4lDZDyONujElDGL4DJFifvHrXwuVLBk95Ji1LA0+Ib39V0aij 4rZwSRRSg4lrHXbvDoTAor6OEwYQDLoppDIq/bJ/jl2VHVFjeAVcA/Uw76L65vWNjprx g4Ww== X-Gm-Message-State: AOJu0YwG94wSvbI5X26MXhhKivYqYxrTQJOnf/tnvFusk+orvnHUN7tm Ch1tnn2/OHCvcMe6fn+sGurs/qdLGzQt7OVw0tGs6twg4/UWjdLTgqSChuyw3k1dVZrj+SgpdMN 7vtN66wF2KeGqbAbs6mPbI7yjuTdxN9dGl3B3sL/zsQOdvcrngCCWdXJ6fjP0TvO65TiNaztbOw 5R8tO698n3 X-Gm-Gg: ATEYQzz1uzgzgYrFnm8dyET6AJqQ+BaU8Vkcg+ZnCHkcTHOQTqupE/y2XrMTVDD1ynw EjOAuryi6QSvxrFNnLnSYhHK/vHUYCenQiHql3GJEofbXwjwE8punrHly7VnhXC1YrCcoEx1W0G vcHN18h1J+8+e5iiopQM34JNVRJEjuet2rWlfPAJAmCGnwaw3poYbhQn3QG0sRA4IhdnThjFvzc hLY/FgqfzjIzYLbeFHaWhMI9XG8nyzjRlPZKC8nulaFrq+wpK0UrcdzP8ewArrgKQ62NqgjVJl/ 0fpMom/efqLkZrbWeeIrjBG2s1j2gWC7Gs/XqbkvV4x7AJQ190plSXjHNFWCMdawxm3pZyM9tnI nheBgU2RzR7YOxrIk+afo6cCxFz4sN+yG1hB8RPapYkIdUXh6jezHQT5MJTroZeL11FKecaOmil nvIvnUU/eLIflkuV5SXqxFwHkjC94BuHiAJA== X-Received: by 2002:a05:620a:f0e:b0:8b2:e666:70d with SMTP id af79cd13be357-8cbc8e03a3emr1976829485a.43.1772536670070; Tue, 03 Mar 2026 03:17:50 -0800 (PST) X-Received: by 2002:a05:620a:f0e:b0:8b2:e666:70d with SMTP id af79cd13be357-8cbc8e03a3emr1976826585a.43.1772536669622; Tue, 03 Mar 2026 03:17:49 -0800 (PST) Received: from t14s (2001-1c00-0c32-7800-beb3-9058-f5fe-3f2e.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:beb3:9058:f5fe:3f2e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66003479178sm2958144a12.9.2026.03.03.03.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 03:17:49 -0800 (PST) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Hans de Goede Subject: [PATCH v4 4/4] software_isp: Log input config from configure() Date: Tue, 3 Mar 2026 12:17:41 +0100 Message-ID: <20260303111741.17417-5-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260303111741.17417-1-johannes.goede@oss.qualcomm.com> References: <20260303111741.17417-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAzMDA4NiBTYWx0ZWRfX8+JV4HTK+qix IQ/XKUC/sWrSZEQc/KiFYB3v5+sk2bgEpgpiP0kvCCEBgamlAtYTeCyHFlslIEBACQHkoSN/Hk2 pe+t29ryOicK5WIA0xdJmD6F05nmGLHEJ8AX2Dk4J7U6YtizQo3znGbF7Uu4Bux3ezKKNr/zmGX jX9L8775h6RemE3rPoMiMYMr3g+DaGRWy1M2/9H73BXSxM6XFG8LOyOanaD/un57HJn2hTLpQ4Q wA6WtuMoHHMgfNv5dnsRoFAuKJ3dFeYL1wBRC1xOUpyxWgTfcxckeG5AG6SyDH8DP8Kf3UF2QIb 0uR9F6+VuiXibxVM/kDs7p9eRIKEcSEbQzzxfmIRzVEcZxLQrMHhjsIK1V21UOTiAdtVtKByMxJ vXKqcgeCwy/9xAEjUob6NG4eRr8OMvNiKZ5ns5ubuOXlAmJw0ytJyVeKWpuz0xwZ9NnKsLib4Ps F0NDAxyc5XOzbZEXMDQ== X-Authority-Analysis: v=2.4 cv=MuhfKmae c=1 sm=1 tr=0 ts=69a6c35f cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=mKg8M22OkPar6P-70WAA:9 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: n64Tv9yWasSHCK2RLVsI7F_X4cy4Vi1N X-Proofpoint-GUID: n64Tv9yWasSHCK2RLVsI7F_X4cy4Vi1N X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51, FMLib:17.12.100.49 definitions=2026-03-02_05,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 malwarescore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603030086 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" As shown by commit 94d32fdc55a3 ("pipeline: simple: Consider output sizes when choosing pipe config"), the extra pixel columns CPU debayering requires on the input side makes resolution selection non trivial. Add logging of the selected input config on a successful configure() so that the logs clearly show which sensor mode has been selected. Reviewed-by: Milan Zamazal Signed-off-by: Hans de Goede --- Changes in v2: - Move from DebayerCpu::configure() to SoftwareIsp::configure() so that the input fmt also gets logged when using the DebayerEgl class --- src/libcamera/software_isp/software_isp.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index 562cdba22..4cf5639d9 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -21,6 +21,7 @@ #include #include +#include "libcamera/internal/bayer_format.h" #include "libcamera/internal/framebuffer.h" #include "libcamera/internal/ipa_manager.h" #include "libcamera/internal/software_isp/debayer_params.h" @@ -270,7 +271,16 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg, if (ret < 0) return ret; - return debayer_->configure(inputCfg, outputCfgs, ccmEnabled_); + ret = debayer_->configure(inputCfg, outputCfgs, ccmEnabled_); + if (ret < 0) + return ret; + + LOG(SoftwareIsp, Info) + << "Input " << inputCfg.size + << "-" << BayerFormat::fromPixelFormat(inputCfg.pixelFormat) + << " stride " << inputCfg.stride; + + return 0; } /**