From patchwork Tue Feb 24 19:37:45 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 26236 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E2E51C32C8 for ; Tue, 24 Feb 2026 19:37:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8E106622AB; Tue, 24 Feb 2026 20:37:59 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="hhw1OqXp"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hz+biL5J"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C84C6622AB for ; Tue, 24 Feb 2026 20:37:53 +0100 (CET) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61OFO7C52432689 for ; Tue, 24 Feb 2026 19:37:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=ia9XTQD3rvi OTPlc4kW0P9cX6uRJDrqGvpie2wAkg40=; b=hhw1OqXpkRgRqSHJclFcvs9D4R6 hD7z1t9ilaCGzdNEJ6+kTr2qutl7itHUTuWVOxWX6QEtR6FMbIRS8QuFcVZvFyIZ ssDPkMGFIPa/fainaiLVQMP16gR0WWZC+q/TjJe3iLZgun6MmuDYURTxBkupPd6R ISKbbXORsSNOkcvuj7/44QT6lIRJHQhyktuhJJpH9tCxk46mkjU65GponJwhNZUq MwqZFQzBvdO+uUwaYOiy94KIGGea5x7Jp5AyVJG9DZtartyQAU/x5SVFwWopHNCY TmY3UVTSFz/VTLZh81ZAjByon+jAtWo2kYsk6t+yfDTGnr5o3kZUk+Da8+g== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4chekj8yh1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Feb 2026 19:37:52 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-899b041cc64so41666356d6.3 for ; Tue, 24 Feb 2026 11:37:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771961871; x=1772566671; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ia9XTQD3rviOTPlc4kW0P9cX6uRJDrqGvpie2wAkg40=; b=hz+biL5JAoRVzcNnxxV1S2OZyq7QkmOVB00X0/mlB8CDMvp7RxedC1+uoY5+RtHHdY jD9auW0+3HzqVS8TFMMYXMqgN8D39e940ErLfl1Km398oIQkE7zM/b5ZQlGJFLL/+U00 V2+WCTF1kKt+6XqZCEJrkv7w5sumR68amGY3YkWengX51vI81tHgKkWl1PUrKE+nWzBv zL8V0ApoauHMORQjGf3+fBfxZHdaskxqEkzAz+nQnrOwNwuSd/e2I8ZJYL9i0LdWrXG0 Klw47imS9MB4svEivD5VvkM8/Lx5KdD3EuA2eqYX4MvUDQmBrC3rJu9YDkK8kOdB3I5U rG0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771961871; x=1772566671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ia9XTQD3rviOTPlc4kW0P9cX6uRJDrqGvpie2wAkg40=; b=XvFVPXTY+ZF8QVsJsUPbwCw9uiOAwLqZKOTkgiErSOPjsLPtv1PQR5TyN8+7rzAGiS vMM50rRIW/fti7icCYeQw7Hgb6pR2DAKLXIM1CB5vfOlFnIB1OT8/1YVoOq8arH1SU9G lMJXkwwJWE9Q6gWfGXkJmQGYMlYy/38vKuANjttDzQElVmHZdwxp0YOG6WQ7IoNgKJhV A8mpotxAHkNHOh6MrtPe4PBiZ4w7vwm7fpSjqVd6QSiaxQZghaHKWneSKyZ5DADDl1lB /SO/avt2UDxUB5Zif6EiqXK7d4V1IfZ5dGo8p7fBYtayzNEO6p60Xve0fy/NC3yvkjGC bqAA== X-Gm-Message-State: AOJu0YyMKjT8IL+X8wN8kuRE8doeufds69nb9IA3VQtzzCy8addEycO3 wKWJrKgBlwI9nJoAqyCO+ydrjjLAUMyLpT2oWTl8d/Mr4YIlSs7zaUMCmz3/jDUhSorBN82XTcB T761AKNERJSIzpQ0DQG7C8/QxaZzdCi0pDRiH1xlezeVj2V26TewJ1xWeAJ42DKchDzh/l/LcOH gwANlhIJ+t X-Gm-Gg: AZuq6aIAPYglFSZDu9SvAe5Ty4I6FV8O7BU01YC59tXFDeO9SOpqeGl1YQ5+hVcKKOt QEzeb78jbSkNu2cfypLO+FITagnDJzo/dTuQTKc7ytTrXjfVTaOAkExVIGS57FOhmyL03jD28V7 3VG7ODMZ+ZksCUAR34/8/8lC6DnD5UDfHhvt96rojsohLMnvwb58oyt0k6n9DTWyACWEpWcCuHy A4T7iONEhK1Xun1BhJrShBmSfoMEWqhv/F1lHdKw/2vYJqegyXPf9pPubqOtkGkyffnDCa8xfso WkXKyihLWqa6QBKv45F0BZVe6CVgjkTjXL62zfOds/1Ua+Iu/RN0tk04ihxP7KnUG9YT06msP17 3Cw/2FAnu5UiZn+1RPbgH306XDM/15n9VlSgN/F/7qdvf3/YpiQws5PnbuidBoeYiChDrQTFTgN RxoYY4kla42i4V23WasZWPsAKLwBKjCzUUNFTl X-Received: by 2002:a05:620a:7114:b0:8ca:934a:5e39 with SMTP id af79cd13be357-8cb8c9fe514mr1942639885a.19.1771961871566; Tue, 24 Feb 2026 11:37:51 -0800 (PST) X-Received: by 2002:a05:620a:7114:b0:8ca:934a:5e39 with SMTP id af79cd13be357-8cb8c9fe514mr1942635385a.19.1771961871016; Tue, 24 Feb 2026 11:37:51 -0800 (PST) Received: from shalem (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9084e8cb3fsm458232866b.48.2026.02.24.11.37.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 11:37:50 -0800 (PST) From: Hans de Goede To: libcamera-devel@lists.libcamera.org, Milan Zamazal Cc: Hans de Goede Subject: [PATCH v3 4/4] software_isp: Log input config from configure() Date: Tue, 24 Feb 2026 20:37:45 +0100 Message-ID: <20260224193745.106186-5-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260224193745.106186-1-johannes.goede@oss.qualcomm.com> References: <20260224193745.106186-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Authority-Analysis: v=2.4 cv=RNe+3oi+ c=1 sm=1 tr=0 ts=699dfe10 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=mKg8M22OkPar6P-70WAA:9 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-ORIG-GUID: IZAbtlJY_qdpP7ejR8K79SVZJeoCPAHL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI0MDE2OCBTYWx0ZWRfX/HdZFxqNp/f7 L/DsZs4d7axTsIA4rH2GPSS51jvxzCwXylOun81Ny+Bi5qddijSGZMO7Lu72IvfnHoJnMI+1s61 hsLHuTtMSZufbeDnQSbNxj14qZ4K5fpknBM6eswT9wCmOQiI82MX+rUSVEU2WXpvNOevBG6QE1K 5WxlaAEm0FdRkacpQ8HzTzsQ1WfSHi6uQ04v9for3OPaoBdLQw1IabcdaF/X0QoCSHEyADag9fE Qp9pyVHhJzxC79VXiN2hiyFk1UI45NrEW4/orRfoLcF5ve3oV5cY9XcJC3jgd/7jD6Sq6o09jS2 entoYTWn8ZA3/zP6L0mt+vKPDS9qocAxDRqBbFbLP6jKbPGNzjK1iocdh6jCZmwsyxSai1IrX+S UKBDbXp0bhem+ov1Pscf+CRr0ul8EPieWVOQSir691ZQT5pB5plqskBfhJ2V7gAs0IV9tBZnAEm qWonAenTtUZ2HP+vpsQ== X-Proofpoint-GUID: IZAbtlJY_qdpP7ejR8K79SVZJeoCPAHL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51, FMLib:17.12.100.49 definitions=2026-02-24_02,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 phishscore=0 clxscore=1015 spamscore=0 impostorscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602240168 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" As shown by commit 94d32fdc55a3 ("pipeline: simple: Consider output sizes when choosing pipe config"), the extra pixel columns CPU debayering requires on the input side makes resolution selection non trivial. Add logging of the selected input config on a successful configure() so that the logs clearly show which sensor mode has been selected. Reviewed-by: Milan Zamazal Signed-off-by: Hans de Goede --- Changes in v3: - Move from DebayerCpu::configure() to SoftwareIsp::configure() so that the input fmt also gets logged when using the DebayerEgl class Changes in v2: - New patch in v2 series --- src/libcamera/software_isp/software_isp.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index 562cdba2..4cf5639d 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -21,6 +21,7 @@ #include #include +#include "libcamera/internal/bayer_format.h" #include "libcamera/internal/framebuffer.h" #include "libcamera/internal/ipa_manager.h" #include "libcamera/internal/software_isp/debayer_params.h" @@ -270,7 +271,16 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg, if (ret < 0) return ret; - return debayer_->configure(inputCfg, outputCfgs, ccmEnabled_); + ret = debayer_->configure(inputCfg, outputCfgs, ccmEnabled_); + if (ret < 0) + return ret; + + LOG(SoftwareIsp, Info) + << "Input " << inputCfg.size + << "-" << BayerFormat::fromPixelFormat(inputCfg.pixelFormat) + << " stride " << inputCfg.stride; + + return 0; } /**