From patchwork Mon Feb 23 09:16:22 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 26224 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CA313C0DA4 for ; Mon, 23 Feb 2026 09:16:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B94DA62280; Mon, 23 Feb 2026 10:16:28 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="hn5GaxPf"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B2C461FA0 for ; Mon, 23 Feb 2026 10:16:26 +0100 (CET) Received: from pb-laptop.local (185.221.141.206.nat.pool.zt.hu [185.221.141.206]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 45705308 for ; Mon, 23 Feb 2026 10:15:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1771838130; bh=5WlhAsfwpxDlRr5H3CL1AywIZJFtANayc8uCWN9F7/U=; h=From:To:Subject:Date:From; b=hn5GaxPfFmjh5AjbV7rNuz0O6aOnnC0dzUAAXso3p9w5FqqSJeUMrsgJqnHiEPT1C sciyKE2z62i66Pb3Gur3WVegZrpr/2xt4Rcxc4ZVvxegJg/BwM7i7WhrRiIBlkNU9X 5nV/t2X7BmR119Df0i2prokgbifiNN7bbFS0N41o= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v1] apps: qcam: Fix clang build Date: Mon, 23 Feb 2026 10:16:22 +0100 Message-ID: <20260223091622.322064-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" While gcc ignores attempts to disable unknown warnings, clang does not (`-Wunknown-warning-option`), thus compilation fails due to the recent addition of `-Wno-sfinae-incomplete`. So only add it conditionally. Closes: https://gitlab.freedesktop.org/camera/libcamera/-/issues/315 Fixes: aa2a0812e6692a ("apps: qcam: Disable -Wsfinae-incomplete") Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- I would still love to merge https://patchwork.libcamera.org/patch/26160/ in some form to avoid this in the future. --- src/apps/qcam/meson.build | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.53.0 diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build index 8eb815eed..ef4209389 100644 --- a/src/apps/qcam/meson.build +++ b/src/apps/qcam/meson.build @@ -40,7 +40,6 @@ qt6_cpp_args = [ apps_cpp_args, '-DQT_NO_KEYWORDS', '-Wno-extra-semi', - '-Wno-sfinae-incomplete', ] # gcc 12 and 13 output a false positive variable shadowing warning with Qt @@ -50,6 +49,10 @@ if qt6_dep.version().version_compare('>=6.9.0') and \ qt6_cpp_args += ['-Wno-shadow'] endif +if cxx.get_id() == 'gcc' and cxx.version().version_compare('>=16') + qt6_cpp_args += ['-Wno-sfinae-incomplete'] +endif + resources = qt6.preprocess(moc_headers : qcam_moc_headers, qresources : qcam_resources, dependencies : qt6_dep)