From patchwork Wed Feb 18 16:42:43 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 26190 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 20819C0DA4 for ; Wed, 18 Feb 2026 16:47:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 778236222F; Wed, 18 Feb 2026 17:47:28 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="m9VbCWy8"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D7D9262222 for ; Wed, 18 Feb 2026 17:47:24 +0100 (CET) Received: from ping.linuxembedded.co.uk (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 20913120E; Wed, 18 Feb 2026 17:46:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1771433192; bh=HyB1kZPgnFxfzcRZFBBV2QMSU4fcUweOSvAyR9wRJ6k=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=m9VbCWy8Ui0dJm0OFpY6oElN6il2VNZ9UeFUD0bf8ek+ObyCqutvqZlbb9Zo9hRPV 8s9t8mDjsiQB1ht20nj4BTvHiWWdtGeZefRtFBu+HmSqJ16XGA0htVWb9hZ3B/VYFH s8/IPCqGhRH3b6H5xF+MrvxUJ1TvQYlGK80D3fnU= From: Kieran Bingham Date: Wed, 18 Feb 2026 16:42:43 +0000 Subject: [PATCH v3 3/3] libcamera: software_isp: Fix LIBCAMERA_SOFTISP_MODE log print MIME-Version: 1.0 Message-Id: <20260218-kbingham-awb-cleanup-v3-3-3be1269ef949@ideasonboard.com> References: <20260218-kbingham-awb-cleanup-v3-0-3be1269ef949@ideasonboard.com> In-Reply-To: <20260218-kbingham-awb-cleanup-v3-0-3be1269ef949@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Kieran Bingham , Jacopo Mondi , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , Laurent Pinchart X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1771433243; l=1522; i=kieran.bingham@ideasonboard.com; s=20260207; h=from:subject:message-id; bh=HyB1kZPgnFxfzcRZFBBV2QMSU4fcUweOSvAyR9wRJ6k=; b=9Nq67VH4wcZDAG+GAvjZdgcYkOwC+7vrzTHwYDHw08LF15vr/d9CayCnMxKuK9sq/vYlekE+R RGkxnGQ2+RCDzhrJUixYXUFzPpaVUbhXD+vcDcHmg082yWR8UkB9oit X-Developer-Key: i=kieran.bingham@ideasonboard.com; a=ed25519; pk=FVXKN7YuwHc6UtbRUeTMAmranfsQomA+vnilfglWdaY= X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When an invalid parameter is specified to LIBCAMERA_SOFTISP_MODE, the error log has a typo. Fix the typo and reflow the line while here. Signed-off-by: Kieran Bingham Reviewed-by: Jacopo Mondi Reviewed-by: Barnabás Pőcze Reviewed-by: Laurent Pinchart Signed-off-by: Kieran Bingham --- v3: - Collect tags, - Clean up log message to Laurent's preference --- src/libcamera/software_isp/software_isp.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index a83986b787b7..c2baaf0bf276 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -108,8 +108,10 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor, std::optional softISPMode = configuration.envOption("LIBCAMERA_SOFTISP_MODE", { "software_isp", "mode" }); if (softISPMode) { if (softISPMode != "gpu" && softISPMode != "cpu") { - LOG(SoftwareIsp, Error) << "LIBCAMERA_SOFISP_MODE " << softISPMode.value() << " invalid " - << "must be \"cpu\" or \"gpu\""; + LOG(SoftwareIsp, Error) + << "Invalid LIBCAMERA_SOFTISP_MODE \"" + << softISPMode.value() + << "\", must be \"cpu\" or \"gpu\""; return; } }