From patchwork Sun Feb 15 09:44:17 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 26158 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 23516BDE6B for ; Sun, 15 Feb 2026 09:44:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DF70D621EB; Sun, 15 Feb 2026 10:44:26 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="guW+UQRJ"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MmF9niDH"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E099161FA0 for ; Sun, 15 Feb 2026 10:44:24 +0100 (CET) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61F5iVQb309658 for ; Sun, 15 Feb 2026 09:44:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=4F/ABCUgGqqyRoOW2aPvMIYTQKJ5G9FDZgT odHMLqjo=; b=guW+UQRJNAqCccgjUy4R1BiJiuelxHJChlGxgiSl7K0+dGjP8fC MonyXryllk2fK285gapP7IxzBQx2guczLtF+hCKeki0V7sUGIYIqUWJGda9OfOJu Q6/sZvqjRxWdapGg5l+FR3LDNnryD7Ys+FhsoGaTIP4llhwzW77vB4MzjqRcnd1e c7g33CZXIu6kLUMMhdXHjNIJjuwuShJSq24UzlOGdUqog86bPEgYDUbHmR3DpHlv 5fK7WL95GKDXRPZhGDFKVJz6BUUy4LTIH5CaHx36eg5AqOUMXPRiN5KY7BUZDwZY 6TEn2Su+xFDROjK8Kp4WG2c3rQctgnH4QSg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cagcf26h8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 15 Feb 2026 09:44:23 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8c70b6a5821so998389785a.0 for ; Sun, 15 Feb 2026 01:44:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771148662; x=1771753462; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4F/ABCUgGqqyRoOW2aPvMIYTQKJ5G9FDZgTodHMLqjo=; b=MmF9niDH5qSHJMMu8DJujypZcuML6yTf/n3Ril/3JTTXbHZk/oy/Ks3CHzFGAQLPdd uLJGLqypH02JTKE3rV64lOCSn1TlJNj/dn2m/tgSw2+gm2gajsauuv3DB1rSYCJek5YD nU7CDjVwTVBtNmDPTRlWXCtdCwFBJeUUgSIP02Ep1zBR2QQgRoz+iKgSWXAmzVq0mXD9 OlJzhoVpHoZQeH8gyVDl8yLqMil7QvxKkDkvLYTD4stZcrux6u6pZ5MTmuJMtgEzJXVb Fp1ehwXi0oj4BDkiELi4fTrbvV05ilVTlrkxKmyvBrt+G9aOKhpnMBFMq7jXk219t5F1 eQFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771148662; x=1771753462; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4F/ABCUgGqqyRoOW2aPvMIYTQKJ5G9FDZgTodHMLqjo=; b=VcCCA384wuw0a0Es9Xg3YXaegsLWt4RFf4mHQq89DMfGzpz/TPbTFkGGo4WZeEudMm Tyysm9qq6fFLGxx743gFQeXBvhO09xIVIu+sOYuHVZsTnvBnr58lO9jG7dsfh+/XOYhc Mw/f1yaONpPLOsn2HvIB6ywCvx6CLWjDAgZ54SVNz+ZJp/VLFSOFJTiEnuql2vq5BDhh mHCbT2O6amWr8UkMoq8uO4m9Oo3w2E60e4A/84OyoC662zkMFPeL0ast3dZU8VzqBlh/ P9YqhIgIq0x4M6lJQL571b4LoJnTEihPL3L8NmpF+LphsqoKEX3DDz+NHVK4HlxduRtC TRPQ== X-Gm-Message-State: AOJu0Yybt2RFWP0+3QjxALnrnR90i6F1WVIi35eNEEJecqQlctifAQZX M/qTqUYWeA0CyBpcjQCEgceomVdajLJpiAjjYSxm7VCFMOnicf98yTU2qvoOYp8m5qVnAJ81CYE W2r18quexVXtGh7r0IRus35QGtVqjXuCIWHZ3PgjTHIS+GaxEzIGLTvA5Xx9d0mYU9QM7hkIpUj k1V8+Ya+Z/ X-Gm-Gg: AZuq6aL4gkNKLVQ0x6tpfVXqOfPb2I3h34JbbHDARRnnec4fA1h+r1j02ytEYlJZEKz 7egY8uUfCxiPy+Wd2nP4suRlvAnyetmNCorynFTD0I3ZcTrsHKldipXgHxDFPdNhpN0RHQhiZZz igWHBQk6l8DlgVwdSP1ZVGKRpN9nAaBXddD7POO0Q2j/m11rW61vkaAsd5O/zDq7oiq6MTZpGM/ 1zHuXub0OX3J2hSWJUkBjoP+JYpQRvLi9284cvs4nIjfIMbLA8gc+dKSmOZbHXG03mQjSgyNhg3 uPF+vJ/auS0gWETNxYAj+sxPGjV6QJcGwqFFT2kY7VhS8tkCCMqn6uwCoAy/5byy9xVgvggczmI 1p0UelcIDSmaMJgbpXX4L3lzKfTKSVdb+EtXgp91BtoWzFeiSgiHbT2RL2vrkKKJ0DyzLyA28n1 7wbaas4gDRQ2LP4u1T3+ZsZubnphTsA2OyaB7g X-Received: by 2002:a05:620a:7107:b0:8c6:ed6b:5865 with SMTP id af79cd13be357-8cb4216c99cmr891840985a.0.1771148662444; Sun, 15 Feb 2026 01:44:22 -0800 (PST) X-Received: by 2002:a05:620a:7107:b0:8c6:ed6b:5865 with SMTP id af79cd13be357-8cb4216c99cmr891839785a.0.1771148662005; Sun, 15 Feb 2026 01:44:22 -0800 (PST) Received: from shalem (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65bad3e390bsm1413658a12.17.2026.02.15.01.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Feb 2026 01:44:20 -0800 (PST) From: Hans de Goede To: libcamera-devel@lists.libcamera.org, Milan Zamazal Cc: Hans de Goede Subject: [PATCH v2 1/2] software_isp: benchmark: Add missing _ postfix to measure data member Date: Sun, 15 Feb 2026 10:44:17 +0100 Message-ID: <20260215094418.18642-1-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 X-Proofpoint-GUID: Zmi0Y8vt1644oMnWh2GZ1rcoV3yME6YY X-Proofpoint-ORIG-GUID: Zmi0Y8vt1644oMnWh2GZ1rcoV3yME6YY X-Authority-Analysis: v=2.4 cv=Sc76t/Ru c=1 sm=1 tr=0 ts=69919577 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=2M7dtBtliclCZGfxGjwA:9 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE1MDA3NiBTYWx0ZWRfXyxFjhxICnVOb aSowIPSk3SbAFs6FhMqCEVOf1USQfAEtGCYBnFa7/BgqP+z/TLVWgCmUJVTkQRrCpns6RjNle0s VcDGxJiVYXAbMeLOGXbfF5K1Bdm8rezPR00+weZlJocT5ai+/fWvbXrOjGuxdsfbDOlmTS7p04n 9425XHqx8Hatna0LV8GBq3WcAD+4MaFTn/BReL4hlnwpWWpKSy017PK1NU6YA2v5Id4B7p1iBUE 5xaK2YoYrR+qkTawa6u56pzMR88c/G9WsTaVJ+i/sqwvfHUApzaEdrKsSFyj232hkL26DzL8hzI VxZK7PpZrOKvYsFfdSafSuRmT4GefU4nIsp69CXoBMpyv3ptdkfIHtq/CfOLo86+q/akBNkPrTY jRzdWxij0PqrNdsLomUNmpYh4UH4UTMMNa07QDivhZXKNrEVLEBxwhV8BZzBTo9kE61GO5krXKF aUCZygvnT+rWRBjRVTQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51, FMLib:17.12.100.49 definitions=2026-02-15_03,2026-02-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 impostorscore=0 spamscore=0 clxscore=1015 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602150076 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" All class data members should have a _ postifx, add the missing _ postfix to the Benchmark::measure_ data member. Signed-off-by: Hans de Goede --- include/libcamera/internal/software_isp/benchmark.h | 2 +- src/libcamera/software_isp/benchmark.cpp | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/libcamera/internal/software_isp/benchmark.h b/include/libcamera/internal/software_isp/benchmark.h index 0680d6cd..46bdb86d 100644 --- a/include/libcamera/internal/software_isp/benchmark.h +++ b/include/libcamera/internal/software_isp/benchmark.h @@ -28,7 +28,7 @@ public: private: timespec frameStartTime_; - bool measure; + bool measure_; /* Skip 30 frames for things to stabilize then measure 30 frames */ unsigned int encounteredFrames_ = 0; int64_t frameProcessTime_ = 0; diff --git a/src/libcamera/software_isp/benchmark.cpp b/src/libcamera/software_isp/benchmark.cpp index 1a00ae56..4ffb6773 100644 --- a/src/libcamera/software_isp/benchmark.cpp +++ b/src/libcamera/software_isp/benchmark.cpp @@ -54,11 +54,11 @@ static inline int64_t timeDiff(timespec &after, timespec &before) */ void Benchmark::startFrame(void) { - measure = framesToMeasure_ > 0 && - encounteredFrames_ < skipBeforeMeasure_ + framesToMeasure_ && - ++encounteredFrames_ > skipBeforeMeasure_; + measure_ = framesToMeasure_ > 0 && + encounteredFrames_ < skipBeforeMeasure_ + framesToMeasure_ && + ++encounteredFrames_ > skipBeforeMeasure_; - if (measure) { + if (measure_) { frameStartTime_ = {}; clock_gettime(CLOCK_MONOTONIC_RAW, &frameStartTime_); } @@ -75,7 +75,7 @@ void Benchmark::startFrame(void) */ void Benchmark::finishFrame(void) { - if (measure) { + if (measure_) { timespec frameEndTime = {}; clock_gettime(CLOCK_MONOTONIC_RAW, &frameEndTime); frameProcessTime_ += timeDiff(frameEndTime, frameStartTime_);